Skip to content

Unintended exit when version check has error (only when using binaries) #85

@jvogt

Description

@jvogt

If version checker fails with error (IE if can't reach github to check for version), an exception is raised (and caught), and an error is logged. This has the unintended behavior of exiting in a pyinstaller-produced binary, but when running from source, it continues with the rest of the script (intended behavior).

To reproduce:

  1. Edit the upgrade_url to a non-working URL in https://github.com/lacework/extensible-reporting/blob/v1.0.2/modules/utils.py#L117
  2. Build a new binary
  3. Execute it

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions