chore: remove scanShortLivedInstances boolean from aws sidekick (#1804)

Author: lokesh-vadlamudi

api/cloud_accounts_aws_sidekick.go

@@ -71,7 +71,6 @@ type AwsSidekickData struct {
 	ScanHostVulnerabilities bool `json:"scanHostVulnerabilities"`
 	ScanMultiVolume         bool `json:"scanMultiVolume"`
 	ScanStoppedInstances    bool `json:"scanStoppedInstances"`
-	ScanShortLivedInstances bool `json:"scanShortLivedInstances"`
 
 	AccountID         string                             `json:"awsAccountId,omitempty"`
 	BucketArn         string                             `json:"bucketArn,omitempty"`

api/cloud_accounts_aws_sidekick_org.go

@@ -72,7 +72,6 @@ type AwsSidekickOrgData struct {
 	ScanHostVulnerabilities bool `json:"scanHostVulnerabilities"`
 	ScanMultiVolume         bool `json:"scanMultiVolume"`
 	ScanStoppedInstances    bool `json:"scanStoppedInstances"`
-	ScanShortLivedInstances bool `json:"scanShortLivedInstances"`
 
 	//Properties specific to the AWS organization integration type
 	ScanningAccount   string `json:"scanningAccount"`

api/cloud_accounts_aws_sidekick_org_test.go

@@ -193,7 +193,6 @@ func singleAwsSidekickOrgCloudAccount(id string) string {
 	  "scanFrequency": 24,
 	  "scanContainers": true,
 	  "scanHostVulnerabilities": true,
-	  "scanShortLivedInstances": false,
 	  "scanStoppedInstances": true,
 	  "scanMultiVolume": false,
 	  "managementAccount": "000123456789",

api/cloud_accounts_aws_sidekick_test.go

@@ -151,7 +151,6 @@ func singleAwsSidekickCloudAccount(id string) string {
 	  "scanFrequency": 24,
 	  "scanContainers": true,
 	  "scanHostVulnerabilities": true,
-	  "scanShortLivedInstances": false,
 	  "scanStoppedInstances": true,
 	  "scanMultiVolume": false
     },