test(cli): mock awsiam.go clients (#1124)

Fixes RAIN-47429

Signed-off-by: nschmeller <[email protected]>

Author: nschmeller

cli/cmd/awsiam.go

@@ -173,11 +173,11 @@ func setupSSMRole(c *iam.Client, roleName string) (types.Role, error) {
 	}
 }
 
-type IAMGetRoleAPI interface {
+type iamGetRoleFromNameAPI interface {
 	GetRole(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error)
 }
 
-func getRoleFromName(c IAMGetRoleAPI, roleName string) (types.Role, error) {
+func getRoleFromName(c iamGetRoleFromNameAPI, roleName string) (types.Role, error) {
 	cli.Log.Debug("fetching info about role", roleName)
 	output, err := c.GetRole(
 		context.Background(),
@@ -192,9 +192,14 @@ func getRoleFromName(c IAMGetRoleAPI, roleName string) (types.Role, error) {
 	return *output.Role, nil
 }
 
+type iamCreateSSMRoleAPI interface {
+	GetRole(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error)
+	CreateRole(ctx context.Context, params *iam.CreateRoleInput, optFns ...func(*iam.Options)) (*iam.CreateRoleOutput, error)
+}
+
 // createSSMRole makes a call to the AWS API to create an IAM role.
 // Returns information about the newly created role and any errors.
-func createSSMRole(c *iam.Client) (types.Role, error) {
+func createSSMRole(c iamCreateSSMRoleAPI) (types.Role, error) {
 	cli.Log.Debug("check if role already exists") // intended for after interrupt or error
 	getOutput, err := c.GetRole(
 		context.Background(),

cli/cmd/awsiam_test.go

@@ -29,38 +29,108 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
+// AWS SDK mocks
+
 type mockGetRoleAPI func(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error)
 
 func (m mockGetRoleAPI) GetRole(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error) {
 	return m(ctx, params, optFns...)
 }
 
+type mockCreateRoleAPI func(ctx context.Context, params *iam.CreateRoleInput, optFns ...func(*iam.Options)) (*iam.CreateRoleOutput, error)
+
+func (m mockCreateRoleAPI) CreateRole(ctx context.Context, params *iam.CreateRoleInput, optFns ...func(*iam.Options)) (*iam.CreateRoleOutput, error) {
+	return m(ctx, params, optFns...)
+}
+
+// ------------------------------------------------------------
+
+// getRoleFromName tests
+
+type mockGetRoleFromNameClient struct {
+	getRoleMethod mockGetRoleAPI
+}
+
+func (m mockGetRoleFromNameClient) GetRole(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error) {
+	return m.getRoleMethod(ctx, params, optFns...)
+}
+
 func TestGetRoleFromName(t *testing.T) {
 	testRoleName := "test_role_name"
 	cases := []struct {
-		client   func(t *testing.T) IAMGetRoleAPI
+		client   iamGetRoleFromNameAPI
 		roleName string
 	}{
 		{
-			client: func(t *testing.T) IAMGetRoleAPI {
-				return mockGetRoleAPI(func(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error) {
+			client: mockGetRoleFromNameClient{
+				getRoleMethod: mockGetRoleAPI(func(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error) {
 					return &iam.GetRoleOutput{
 						Role: &types.Role{
 							RoleName: aws.String(testRoleName),
 						},
 					}, nil
+				}),
+			},
+			roleName: testRoleName,
+		},
+	}
+
+	for i, tt := range cases {
+		t.Run(strconv.Itoa(i), func(t *testing.T) {
+			role, err := getRoleFromName(tt.client, tt.roleName)
+			assert.NoError(t, err)
+			assert.Equal(t, *role.RoleName, tt.roleName)
+		})
+	}
+}
 
-				})
+// createSSMRole tests
+
+type mockCreateSSMRoleClient struct {
+	getRoleMethod    mockGetRoleAPI
+	createRoleMethod mockCreateRoleAPI
+}
+
+func (m mockCreateSSMRoleClient) GetRole(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error) {
+	return m.getRoleMethod(ctx, params, optFns...)
+}
+
+func (m mockCreateSSMRoleClient) CreateRole(ctx context.Context, params *iam.CreateRoleInput, optFns ...func(*iam.Options)) (*iam.CreateRoleOutput, error) {
+	return m.createRoleMethod(ctx, params, optFns...)
+}
+
+func TestCreateSSMRole(t *testing.T) {
+	testRoleName := "test_role_name"
+	cases := []struct {
+		client   iamCreateSSMRoleAPI
+		roleName string
+	}{
+		{
+			client: mockCreateSSMRoleClient{
+				getRoleMethod: mockGetRoleAPI(func(ctx context.Context, params *iam.GetRoleInput, optFns ...func(*iam.Options)) (*iam.GetRoleOutput, error) {
+					return &iam.GetRoleOutput{
+						Role: &types.Role{
+							RoleName: aws.String(testRoleName),
+						},
+					}, nil
+				}),
+				createRoleMethod: mockCreateRoleAPI(func(ctx context.Context, params *iam.CreateRoleInput, optFns ...func(*iam.Options)) (*iam.CreateRoleOutput, error) {
+					return &iam.CreateRoleOutput{
+						Role: &types.Role{
+							RoleName: aws.String(testRoleName),
+						},
+					}, nil
+				}),
 			},
 			roleName: testRoleName,
 		},
 	}
 
 	for i, tt := range cases {
 		t.Run(strconv.Itoa(i), func(t *testing.T) {
-			role, err := getRoleFromName(tt.client(t), tt.roleName)
+			role, err := createSSMRole(tt.client)
 			assert.NoError(t, err)
-			assert.Equal(t, *role.RoleName, testRoleName)
+			assert.Equal(t, *role.RoleName, tt.roleName)
 		})
 	}
 }