fix: use buffered channel for downloadComplete to prevent blocking (#1617)

Matt Cadorette · web-flow · commit 7ddbd389bc81 · 2024-04-25T14:22:59.000-04:00
Prior to this commit if an error occurred before the download progress
function could start, the CLI would block writing to the
downloadComplete channel
diff --git a/cli/cmd/component.go b/cli/cmd/component.go
@@ -413,7 +413,7 @@ func runComponentsInstall(cmd *cobra.Command, args []string) (err error) {
 func installComponent(args []string) (err error) {
 	var (
 		componentName    string                 = args[0]
-		downloadComplete                        = make(chan int8)
+		downloadComplete                        = make(chan int8, 1)
 		params           map[string]interface{} = make(map[string]interface{})
 		start            time.Time
 	)

Original file line number	Diff line number	Diff line change
`@@ -413,7 +413,7 @@ func runComponentsInstall(cmd *cobra.Command, args []string) (err error) {`
`413`	`413`	`func installComponent(args []string) (err error) {`
`414`	`414`	`var (`
`415`	`415`	`componentName string = args[0]`
`416`		`- downloadComplete = make(chan int8)`
	`416`	`+ downloadComplete = make(chan int8, 1)`
`417`	`417`	`params map[string]interface{} = make(map[string]interface{})`
`418`	`418`	`start time.Time`
`419`	`419`	`)`