feat: disallow extra arguments on sub-commands (#48)

Signed-off-by: Salim Afiune Maya <[email protected]>

Author: afiune

cli/cmd/api.go

@@ -64,7 +64,7 @@ func init() {
 	)
 }
 
-func runApiCommand(cmd *cobra.Command, args []string) error {
+func runApiCommand(_ *cobra.Command, args []string) error {
 	switch args[0] {
 	case "post", "patch":
 		if apiData == "" {

cli/cmd/configure.go

@@ -44,7 +44,8 @@ var (
 	configureCmd = &cobra.Command{
 		Use:   "configure",
 		Short: "Set up your Lacework cli",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		Args:  cobra.NoArgs,
+		RunE: func(_ *cobra.Command, _ []string) error {
 			var (
 				promptAccount = promptui.Prompt{
 					Label:   "Account",

cli/cmd/integration.go

@@ -38,7 +38,8 @@ var (
 	integrationListCmd = &cobra.Command{
 		Use:   "list",
 		Short: "List all available external integrations",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		Args:  cobra.NoArgs,
+		RunE: func(_ *cobra.Command, _ []string) error {
 			lacework, err := api.NewClient(cli.Account,
 				api.WithLogLevel(cli.LogLevel),
 				api.WithApiKeys(cli.KeyID, cli.Secret),
@@ -62,7 +63,8 @@ var (
 		Use:    "create",
 		Hidden: true,
 		Short:  "Create an external integrations",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		Args:   cobra.NoArgs,
+		RunE: func(_ *cobra.Command, _ []string) error {
 			return nil
 		},
 	}
@@ -72,7 +74,8 @@ var (
 		Use:    "update",
 		Hidden: true,
 		Short:  "Update an external integrations",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		Args:   cobra.NoArgs,
+		RunE: func(_ *cobra.Command, _ []string) error {
 			return nil
 		},
 	}
@@ -82,7 +85,8 @@ var (
 		Use:    "delete",
 		Hidden: true,
 		Short:  "Delete an external integrations",
-		RunE: func(cmd *cobra.Command, args []string) error {
+		Args:   cobra.NoArgs,
+		RunE: func(_ *cobra.Command, _ []string) error {
 			return nil
 		},
 	}

cli/cmd/version.go

@@ -40,7 +40,8 @@ var (
 	versionCmd = &cobra.Command{
 		Use:   "version",
 		Short: "Print the Lacework cli version",
-		Run: func(cmd *cobra.Command, args []string) {
+		Args:  cobra.NoArgs,
+		Run: func(_ *cobra.Command, _ []string) {
 			fmt.Printf("lacework v%s (sha:%s) (time:%s)\n", Version, GitSHA, BuildTime)
 		},
 	}