Skip to content

Commit fa93e65

Browse files
author
Matt Cadorette
authored
fix(GROW-2556): enable azure storage account infra encryption (#1431)
Enable Infrastructure Encryption by default when creating a new Azure Storage Account for activity log integration.
1 parent 9df44a2 commit fa93e65

10 files changed

+75
-60
lines changed

‎lwgenerate/azure/azure.go‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,12 @@ func createActivityLog(args *GenerateAzureTfConfigurationArgs) ([]*hclwrite.Bloc
468468
attributes["storage_account_resource_group"] = args.StorageAccountResourceGroup
469469
}
470470

471+
// if a new storage account is being created (i.e., ExistingStorageAccount is false), enable infrastructure
472+
// encryption
473+
if !args.ExistingStorageAccount {
474+
attributes["infrastructure_encryption_enabled"] = true
475+
}
476+
471477
// Set the location if needed
472478
if args.StorageLocation != "" {
473479
attributes["location"] = args.StorageLocation

‎lwgenerate/azure/test-data/activity-log-with-all-subscriptions.tf‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@ module "az_ad_application" {
2121
}
2222

2323
module "az_activity_log" {
24-
source = "lacework/activity-log/azure"
25-
version = "~> 2.0"
26-
all_subscriptions = true
27-
application_id = module.az_ad_application.application_id
28-
application_password = module.az_ad_application.application_password
29-
service_principal_id = module.az_ad_application.service_principal_id
30-
use_existing_ad_application = true
24+
source = "lacework/activity-log/azure"
25+
version = "~> 2.0"
26+
all_subscriptions = true
27+
application_id = module.az_ad_application.application_id
28+
application_password = module.az_ad_application.application_password
29+
infrastructure_encryption_enabled = true
30+
service_principal_id = module.az_ad_application.service_principal_id
31+
use_existing_ad_application = true
3132
}

‎lwgenerate/azure/test-data/activity-log-with-lacework-profile.tf‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,11 @@ module "az_ad_application" {
2525
}
2626

2727
module "az_activity_log" {
28-
source = "lacework/activity-log/azure"
29-
version = "~> 2.0"
30-
application_id = module.az_ad_application.application_id
31-
application_password = module.az_ad_application.application_password
32-
service_principal_id = module.az_ad_application.service_principal_id
33-
use_existing_ad_application = true
28+
source = "lacework/activity-log/azure"
29+
version = "~> 2.0"
30+
application_id = module.az_ad_application.application_id
31+
application_password = module.az_ad_application.application_password
32+
infrastructure_encryption_enabled = true
33+
service_principal_id = module.az_ad_application.service_principal_id
34+
use_existing_ad_application = true
3435
}

‎lwgenerate/azure/test-data/activity-log-with-list-subscriptions.tf‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@ module "az_ad_application" {
2121
}
2222

2323
module "az_activity_log" {
24-
source = "lacework/activity-log/azure"
25-
version = "~> 2.0"
26-
application_id = module.az_ad_application.application_id
27-
application_password = module.az_ad_application.application_password
28-
service_principal_id = module.az_ad_application.service_principal_id
29-
subscription_ids = ["test-id-1", "test-id-2", "test-id-3"]
30-
use_existing_ad_application = true
24+
source = "lacework/activity-log/azure"
25+
version = "~> 2.0"
26+
application_id = module.az_ad_application.application_id
27+
application_password = module.az_ad_application.application_password
28+
infrastructure_encryption_enabled = true
29+
service_principal_id = module.az_ad_application.service_principal_id
30+
subscription_ids = ["test-id-1", "test-id-2", "test-id-3"]
31+
use_existing_ad_application = true
3132
}

‎lwgenerate/azure/test-data/activity-log-with-location.tf‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@ module "az_ad_application" {
2121
}
2222

2323
module "az_activity_log" {
24-
source = "lacework/activity-log/azure"
25-
version = "~> 2.0"
26-
application_id = module.az_ad_application.application_id
27-
application_password = module.az_ad_application.application_password
28-
location = "West US 2"
29-
service_principal_id = module.az_ad_application.service_principal_id
30-
use_existing_ad_application = true
24+
source = "lacework/activity-log/azure"
25+
version = "~> 2.0"
26+
application_id = module.az_ad_application.application_id
27+
application_password = module.az_ad_application.application_password
28+
infrastructure_encryption_enabled = true
29+
location = "West US 2"
30+
service_principal_id = module.az_ad_application.service_principal_id
31+
use_existing_ad_application = true
3132
}

‎lwgenerate/azure/test-data/activity_log_with_config.tf‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,11 @@ module "az_config" {
3030
}
3131

3232
module "az_activity_log" {
33-
source = "lacework/activity-log/azure"
34-
version = "~> 2.0"
35-
application_id = module.az_ad_application.application_id
36-
application_password = module.az_ad_application.application_password
37-
service_principal_id = module.az_ad_application.service_principal_id
38-
use_existing_ad_application = true
33+
source = "lacework/activity-log/azure"
34+
version = "~> 2.0"
35+
application_id = module.az_ad_application.application_id
36+
application_password = module.az_ad_application.application_password
37+
infrastructure_encryption_enabled = true
38+
service_principal_id = module.az_ad_application.service_principal_id
39+
use_existing_ad_application = true
3940
}

‎lwgenerate/azure/test-data/activity_log_without_config.tf‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ module "az_ad_application" {
2121
}
2222

2323
module "az_activity_log" {
24-
source = "lacework/activity-log/azure"
25-
version = "~> 2.0"
26-
application_id = module.az_ad_application.application_id
27-
application_password = module.az_ad_application.application_password
28-
service_principal_id = module.az_ad_application.service_principal_id
29-
use_existing_ad_application = true
24+
source = "lacework/activity-log/azure"
25+
version = "~> 2.0"
26+
application_id = module.az_ad_application.application_id
27+
application_password = module.az_ad_application.application_password
28+
infrastructure_encryption_enabled = true
29+
service_principal_id = module.az_ad_application.service_principal_id
30+
use_existing_ad_application = true
3031
}

‎lwgenerate/azure/test-data/customer-ad-details.tf‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,12 @@ module "az_config" {
2626
}
2727

2828
module "az_activity_log" {
29-
source = "lacework/activity-log/azure"
30-
version = "~> 2.0"
31-
application_id = "AD-Test-Application-ID"
32-
application_password = "AD-Test-Password"
33-
lacework_integration_name = "Test Activity Log Rename"
34-
service_principal_id = "AD-Test-Principal-ID"
35-
use_existing_ad_application = true
29+
source = "lacework/activity-log/azure"
30+
version = "~> 2.0"
31+
application_id = "AD-Test-Application-ID"
32+
application_password = "AD-Test-Password"
33+
infrastructure_encryption_enabled = true
34+
lacework_integration_name = "Test Activity Log Rename"
35+
service_principal_id = "AD-Test-Principal-ID"
36+
use_existing_ad_application = true
3637
}

‎lwgenerate/azure/test-data/renamed_activity_log.tf‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,12 @@ module "az_ad_application" {
2121
}
2222

2323
module "az_activity_log" {
24-
source = "lacework/activity-log/azure"
25-
version = "~> 2.0"
26-
application_id = module.az_ad_application.application_id
27-
application_password = module.az_ad_application.application_password
28-
lacework_integration_name = "Test Activity Log Rename"
29-
service_principal_id = module.az_ad_application.service_principal_id
30-
use_existing_ad_application = true
24+
source = "lacework/activity-log/azure"
25+
version = "~> 2.0"
26+
application_id = module.az_ad_application.application_id
27+
application_password = module.az_ad_application.application_password
28+
infrastructure_encryption_enabled = true
29+
lacework_integration_name = "Test Activity Log Rename"
30+
service_principal_id = module.az_ad_application.service_principal_id
31+
use_existing_ad_application = true
3132
}

‎lwgenerate/azure/test-data/renamed_config_and_activity_log.tf‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ module "az_config" {
3131
}
3232

3333
module "az_activity_log" {
34-
source = "lacework/activity-log/azure"
35-
version = "~> 2.0"
36-
application_id = module.az_ad_application.application_id
37-
application_password = module.az_ad_application.application_password
38-
lacework_integration_name = "Test Activity Log Rename"
39-
service_principal_id = module.az_ad_application.service_principal_id
40-
use_existing_ad_application = true
34+
source = "lacework/activity-log/azure"
35+
version = "~> 2.0"
36+
application_id = module.az_ad_application.application_id
37+
application_password = module.az_ad_application.application_password
38+
infrastructure_encryption_enabled = true
39+
lacework_integration_name = "Test Activity Log Rename"
40+
service_principal_id = module.az_ad_application.service_principal_id
41+
use_existing_ad_application = true
4142
}

0 commit comments

Comments
 (0)