fix: added buttons to 404 and 500 pages, ensure that page rendered not just for 500

titanism · titanism · commit 5be07e44f923 · 2022-06-03T01:44:32.000-05:00
diff --git a/404.html b/404.html
@@ -55,6 +55,7 @@
 <body>
     <h1>Page Not Found</h1>
     <p>Sorry, but the page you were trying to view does not exist.</p>
+    <button onclick="javascript:window.location = '/';">Go to homepage</button>
 </body>
 </html>
 <!-- IE needs 512+ bytes: https://docs.microsoft.com/en-us/archive/blogs/ieinternals/friendly-http-error-pages -->
diff --git a/500.html b/500.html
@@ -55,6 +55,7 @@
 <body>
     <h1>Internal Server Error</h1>
     <p>An internal server error occurred.</p>
+    <button onclick="javascript:document.location.reload(true);">Try again</button>
 </body>
 </html>
 <!-- IE needs 512+ bytes: https://docs.microsoft.com/en-us/archive/blogs/ieinternals/friendly-http-error-pages -->
diff --git a/index.js b/index.js
@@ -53,6 +53,9 @@ const opts = {
   encoding: 'utf8'
 };
 
+//
+// TODO: we could eventually use this https://github.com/alexphelps/server-error-pages/
+//
 // error pages were inspired by HTML5 Boilerplate's default 404.html page
 // https://github.com/h5bp/html5-boilerplate/blob/master/src/404.html
 const _404 = fs.readFileSync(path.join(__dirname, '404.html'), opts);
@@ -192,15 +195,15 @@ function errorHandler(
           } else {
             this.body = _404;
           }
-        } else if (noReferrer || this.status === 500) {
+        } else if (noReferrer) {
           // this prevents a redirect loop by detecting an empty Referrer
           // ...otherwise it would reach the next conditional block which
           // would endlessly rediret the user with `this.redirect('back')`
 
           // flash an error message
           if (hasFlash) this.flash('error', err.message);
 
-          // render the 500 page
+          // render the 5xx page
           if (hasRender) {
             try {
               await this.render('500');
