fix: 400 status code set on ValidationError

Author: niftylettuce

README.md

@@ -191,7 +191,7 @@ try {
 {
   "statusCode": 400,
   "error": "Bad Request",
-  "message": "<ul class=\"text-xs-left mb-0\"><li>Path `company_logo` is required.</li><li>Gig description must be 100-300 characters.</li></ul>"
+  "message": "<ul class=\"text-left mb-0\"><li>Path `company_logo` is required.</li><li>Gig description must be 100-300 characters.</li></ul>"
 }
 ```
 

package.json

@@ -9,38 +9,41 @@
       "@commitlint/config-conventional"
     ]
   },
+  "contributors": [
+    "Nick Baugh <[email protected]>"
+  ],
   "dependencies": {
     "boom": "5.1.0",
     "co": "^4.6.0",
     "debug": "^4.1.1",
-    "lodash": "^4.17.11",
+    "lodash": "^4.17.15",
     "underscore.string": "^3.3.5"
   },
   "devDependencies": {
-    "@commitlint/cli": "^7.5.2",
-    "@commitlint/config-conventional": "^7.5.0",
-    "ava": "^1.4.0",
+    "@commitlint/cli": "^8.1.0",
+    "@commitlint/config-conventional": "^8.1.0",
+    "ava": "^2.3.0",
     "babel-cli": "^6.26.0",
     "babel-preset-env": "^1.7.0",
-    "codecov": "^3.2.0",
-    "cross-env": "^5.2.0",
-    "eslint": "^5.15.3",
+    "codecov": "^3.5.0",
+    "cross-env": "^5.2.1",
+    "eslint": "^6.3.0",
     "eslint-config-xo-lass": "^1.0.3",
     "fixpack": "^2.3.1",
-    "husky": "^1.3.1",
-    "koa": "^2.7.0",
+    "husky": "^3.0.5",
+    "koa": "^2.8.1",
     "koa-404-handler": "^0.0.2",
     "koa-basic-auth": "https://github.com/niftylettuce/basic-auth",
     "koa-connect-flash": "^0.1.2",
     "koa-convert": "^1.2.0",
     "koa-generic-session": "^2.0.1",
-    "koa-redis": "^3.1.3",
+    "koa-redis": "^4.0.0",
     "koa-router": "^7.4.0",
-    "lint-staged": "^8.1.5",
-    "nyc": "^13.3.0",
+    "lint-staged": "^9.2.5",
+    "nyc": "^14.1.1",
     "redis": "^2.8.0",
-    "remark-cli": "^6.0.1",
-    "remark-preset-github": "^0.0.13",
+    "remark-cli": "^7.0.0",
+    "remark-preset-github": "^0.0.16",
     "supertest": "^4.0.2",
     "xo": "^0.24.0"
   },

src/index.js

@@ -221,19 +221,25 @@ function parseValidationError(ctx, err) {
     return error;
   });
 
+  // translate messages
+  const translate = message =>
+    _.isFunction(ctx.request.t) ? ctx.request.t(message) : message;
+
   // loop over the errors object of the Validation Error
   // with support for HTML error lists
   if (_.values(err.errors).length === 1) {
-    err.message = _.values(err.errors)[0].message;
+    err.message = translate(_.values(err.errors)[0].message);
   } else {
-    const errors = _.map(_.values(err.errors), 'message');
+    const errors = _.map(_.map(_.values(err.errors), 'message'), translate);
     err.message = ctx.api
       ? errors.join(', ')
-      : `<ul class="text-xs-left mb-0"><li>${errors.join(
-          '</li><li>'
-        )}</li></ul>`;
+      : `<ul class="text-left mb-0"><li>${errors.join('</li><li>')}</li></ul>`;
   }
 
+  // this ensures the error shows up client-side
+  err.status = 400;
+  err.statusCode = 400;
+
   return err;
 }