Merge pull request #296 from lae/develop

Release 1.9.2

Author: lae

README.md

@@ -25,6 +25,8 @@ With clustering enabled, this role does (or allows you to do) the following:
   - Setup Ceph on a PVE cluster
   - Create and manage high availability groups
 
+WARNING: Support for servers provisioned using the Proxmox ISO installer is limited. Use Debian as your base.
+
 ## Support/Contributing
 
 For support or if you'd like to contribute to this role but want guidance, feel
@@ -57,8 +59,8 @@ Copy the following playbook to a file like `install_proxmox.yml`:
               - clock.nyc.he.net
         - role: lae.proxmox
           vars:
-            - pve_group: all
-            - pve_reboot_on_kernel_update: true
+            pve_group: all
+            pve_reboot_on_kernel_update: true
 
 Install this role and a role for configuring NTP:
 
@@ -905,6 +907,7 @@ It can be later removed by unsetting this role variable.
 ## Troubleshooting
 
 ### The APT installation of proxmox-ve no longer responds, Ansible aborts, the SSH session stops.
+
 Add this section to your ``ansible.cfg``.
 
 ```yaml
@@ -913,6 +916,19 @@ ssh_args = -o ServerAliveInterval=20
 ```
 [Reference Issue](https://github.com/lae/ansible-role-proxmox/issues/279)
 
+### Proxmox doesn't boot/does not update GRUB config correctly.
+
+There is no known issue for this, however the following error message is silently ignored because of a false positive on certain systems using ZFS:
+
+```
+$ sudo update-grub
+<...>
+/usr/sbin/grub-probe: error: unknown filesystem.
+<...>
+```
+
+While this error is outside the scope of this role to fix, please open an issue with details if this ignore masks a true positive for your system.
+
 ## Developer Notes
 
 When developing new features or fixing something in this role, you can test out

handlers/main.yml

@@ -39,5 +39,10 @@
 - name: update-grub
   command: update-grub
   register: _pve_grub_update
-  failed_when: ('error' in _pve_grub_update.stderr)
+  failed_when: >-
+    'error' in (
+      _pve_grub_update.stderr_lines |
+      reject('equalto', '/usr/sbin/grub-probe: error: unknown filesystem.') |
+      join('\n')
+    )
   tags: skiponlxc

tasks/main.yml

@@ -132,6 +132,10 @@
     name: os-prober
     state: absent
 
+- ansible.builtin.import_tasks: remove_enterprise_repos.yml
+  when:
+    - "'pve-no-subscription' in pve_repository_line"
+
 - name: Add Proxmox repository
   apt_repository:
     repo: "{{ pve_repository_line }}"
@@ -195,14 +199,7 @@
   until: _proxmox_install is succeeded
 
 - block:
-    - name: Remove automatically installed PVE Enterprise repo configuration
-      apt_repository:
-        repo: "{{ item }}"
-        filename: pve-enterprise
-        state: absent
-      with_items:
-        - "deb https://enterprise.proxmox.com/debian {{ ansible_distribution_release }} pve-enterprise"
-        - "deb https://enterprise.proxmox.com/debian/pve {{ ansible_distribution_release }} pve-enterprise"
+    - ansible.builtin.import_tasks: remove_enterprise_repos.yml
 
     - name: Remove subscription check wrapper function in web UI
       ansible.builtin.lineinfile:

tasks/remove_enterprise_repos.yml

@@ -0,0 +1,10 @@
+- name: Remove automatically installed PVE Enterprise repo configuration
+  ansible.builtin.apt_repository:
+    repo: "{{ item }}"
+    filename: pve-enterprise
+    state: absent
+    update_cache: false
+  with_items:
+    - "deb https://enterprise.proxmox.com/debian {{ ansible_distribution_release }} pve-enterprise"
+    - "deb https://enterprise.proxmox.com/debian/pve {{ ansible_distribution_release }} pve-enterprise"
+    - "deb https://enterprise.proxmox.com/debian/ceph-quincy {{ ansible_distribution_release }} enterprise"