Merge pull request #184 from btravouillon/fix/no_pve_manage_ssh

Check for pve_manage_ssh in pve_add_node.yml

Author: lae

README.md

@@ -224,7 +224,7 @@ joining the cluster, the PVE cluster needs to communicate once via SSH.
 would make to your SSH server config. This is useful if you use another role
 to manage your SSH server. Note that setting this to false is not officially
 supported, you're on your own to replicate the changes normally made in
-ssh_cluster_config.yml.
+`ssh_cluster_config.yml` and `pve_add_node.yml`.
 
 `interfaces_template` is set to the path of a template we'll use for configuring
 the network on these Debian machines. This is only necessary if you want to

tasks/pve_add_node.yml

@@ -1,16 +1,18 @@
 ---
-- name: Identify the SSH public key and SSH addresses of initial cluster host
-  ansible.builtin.set_fact:
-    _pve_cluster_host_key: "{{ ' '.join((hostvars[_init_node]._pve_ssh_public_key.content | b64decode).split()[:-1]) }}"
-    _pve_cluster_host_addresses: "{{ hostvars[_init_node].pve_cluster_ssh_addrs | join(',') }}"
+- block:
+  - name: Identify the SSH public key and SSH addresses of initial cluster host
+    ansible.builtin.set_fact:
+      _pve_cluster_host_key: "{{ ' '.join((hostvars[_init_node]._pve_ssh_public_key.content | b64decode).split()[:-1]) }}"
+      _pve_cluster_host_addresses: "{{ hostvars[_init_node].pve_cluster_ssh_addrs | join(',') }}"
 
-- name: Temporarily mark that cluster host as known in root user's known_hosts
-  ansible.builtin.blockinfile:
-    dest: /root/.ssh/known_hosts
-    create: yes
-    mode: 0600
-    marker: "# {mark}: cluster host key for joining"
-    content: "{{ _pve_cluster_host_addresses }} {{ _pve_cluster_host_key }}"
+  - name: Temporarily mark that cluster host as known in root user's known_hosts
+    ansible.builtin.blockinfile:
+      dest: /root/.ssh/known_hosts
+      create: yes
+      mode: 0600
+      marker: "# {mark}: cluster host key for joining"
+      content: "{{ _pve_cluster_host_addresses }} {{ _pve_cluster_host_key }}"
+  when: "pve_manage_ssh | bool"
 
 - name: Add node to Proxmox cluster
   ansible.builtin.command: >-
@@ -30,3 +32,4 @@
     state: absent
     mode: 0600
     marker: "# {mark}: cluster host key for joining"
+  when: "pve_manage_ssh | bool"