Never allow an empty password to validate (go-gitea#9682) (go-gitea#9684)

zeripath · lafriks · commit 0e5126da22a1 · 2020-01-11T13:14:03.000+02:00
* Restore IsPasswordSet previous value

* Update models/user.go
diff --git a/models/user.go b/models/user.go
@@ -502,7 +502,7 @@ func (u *User) ValidatePassword(passwd string) bool {
 
 // IsPasswordSet checks if the password is set or left empty
 func (u *User) IsPasswordSet() bool {
-	return len(u.Passwd) > 0
+	return !u.ValidatePassword("")
 }
 
 // UploadAvatar saves custom avatar for user.

Original file line number	Diff line number	Diff line change
`@@ -502,7 +502,7 @@ func (u *User) ValidatePassword(passwd string) bool {`
`502`	`502`
`503`	`503`	`// IsPasswordSet checks if the password is set or left empty`
`504`	`504`	`func (u *User) IsPasswordSet() bool {`
`505`		`- return len(u.Passwd) > 0`
	`505`	`+ return !u.ValidatePassword("")`
`506`	`506`	`}`
`507`	`507`
`508`	`508`	`// UploadAvatar saves custom avatar for user.`