Fix back button will appear twice on certain conditions (aws#4363)

also, enable back button consistently

Author: Will-ShaoHua

plugins/core/webview/src/q-ui/components/awsProfileForm.vue

@@ -2,14 +2,6 @@
 <!-- SPDX-License-Identifier: Apache-2.0 -->
 
 <template>
-    <button class="back-button" @click="handleBackButtonClick">
-        <svg width="13" height="11" viewBox="0 0 13 11" fill="none" xmlns="http://www.w3.org/2000/svg">
-            <path
-                d="M4.98667 0.0933332L5.73333 0.786666L1.57333 4.94667H12.0267V5.96H1.57333L5.73333 10.0667L4.98667 10.8133L0.0266666 5.8V5.10667L4.98667 0.0933332Z"
-                fill="#21A2FF"
-            />
-        </svg>
-    </button>
     <div class="title no-bold font-amazon">Profile Name</div>
     <div class="hint font-amazon">The identifier for these credentials</div>
     <input class="iamInput font-amazon" type="text" id="profileName" name="profileName" v-model="profileName"/>
@@ -49,9 +41,6 @@ export default defineComponent({
         async handleContinueClick() {
             this.$emit('login',  new LongLivedIAM(this.profileName, this.accessKey, this.secretKey))
         },
-        handleBackButtonClick() {
-            this.$emit('backToMenu')
-        },
     }
 })
 </script>

plugins/core/webview/src/q-ui/components/login.vue

@@ -9,7 +9,7 @@
             :is-connected="stage === 'CONNECTED'"
         />
 
-        <button v-if="cancellable" class="back-button" @click="handleBackButtonClick" tabindex="-1">
+        <button v-if="stage !== 'START' || cancellable" class="back-button" @click="handleBackButtonClick" tabindex="-1">
             <svg width="24" height="24" viewBox="0 -3 13 16" fill="none" xmlns="http://www.w3.org/2000/svg">
                 <path
                     d="M4.98667 0.0933332L5.73333 0.786666L1.57333 4.94667H12.0267V5.96H1.57333L5.73333 10.0667L4.98667 10.8133L0.0266666 5.8V5.10667L4.98667 0.0933332Z"
@@ -116,7 +116,7 @@ export default defineComponent({
             this.$store.commit('setStage', stage)
         },
         handleBackButtonClick() {
-            if (this.cancellable && this.stage === 'START') {
+            if (this.cancellable) {
                 window.ideApi.postMessage({ command: 'toggleBrowser' })
             }
             this.mutateStage('START')

plugins/core/webview/src/q-ui/components/loginOptions.vue

@@ -34,9 +34,6 @@ export default defineComponent({
         toggleItemSelection(itemId: number) {
             this.selectedLoginOption = itemId
         },
-        handleBackButtonClick() {
-            this.$emit('backToMenu')
-        },
         stageChanged(stage: Stage) {
             this.$emit('stageChanged', stage)
         },

plugins/core/webview/src/q-ui/components/ssoLoginForm.vue

@@ -2,14 +2,6 @@
 <!-- SPDX-License-Identifier: Apache-2.0 -->
 
 <template>
-    <button class="back-button" @click="handleBackButtonClick" tabindex="-1">
-        <svg width="24" height="24" viewBox="0 -3 13 16" fill="none" xmlns="http://www.w3.org/2000/svg">
-            <path
-                d="M4.98667 0.0933332L5.73333 0.786666L1.57333 4.94667H12.0267V5.96H1.57333L5.73333 10.0667L4.98667 10.8133L0.0266666 5.8V5.10667L4.98667 0.0933332Z"
-                fill="#21A2FF"
-            />
-        </svg>
-    </button>
     <div class="font-amazon" @keydown.enter="handleContinueClick">
         <div class="bottom-small-gap">
             <div class="title">Sign in with SSO:</div>
@@ -112,9 +104,6 @@ export default defineComponent({
         handleUrlInput() {
             this.isInputValid = this.startUrl != "" && this.selectedRegion != "";
         },
-        handleBackButtonClick() {
-            this.$emit('backToMenu')
-        },
         async handleContinueClick() {
             if (!this.isInputValid) {
                 return

plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/webview/ToolkitLoginWebview.kt

@@ -196,7 +196,12 @@ class ToolkitWebviewBrowser(val project: Project) : LoginBrowser(project, Toolki
         val regionJson = objectMapper.writeValueAsString(regions)
 
         // TODO: if codecatalyst connection expires, set stage to 'REAUTH'
-        val stage = "START"
+        // TODO: make these strings type safe
+        val stage = if (state.feature == FeatureId.Codecatalyst) {
+            "SSO_FORM"
+        } else {
+            "START"
+        }
 
         val jsonData = """
             {