revert jcef browser prop createImmediately as it's causing unexpected behavior when browser is created before jcef query (aws#4391)

Will-ShaoHua · manodnyab · web-flow · commit 7c924e32c243 · 2024-04-26T18:25:22.000-07:00
Co-authored-by: manodnyab &lt;66754471+manodnyab@users.noreply.github.com&gt;
diff --git a/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/util/JcefBrowserUtil.kt b/plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/util/JcefBrowserUtil.kt
@@ -17,6 +17,5 @@ fun createBrowser(parent: Disposable): JBCefBrowserBase {
     return JBCefBrowserBuilder()
         .setClient(client)
         .setOffScreenRendering(true)
-        .setCreateImmediately(true)
         .build()
 }
diff --git a/plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/webview/ToolkitLoginWebview.kt b/plugins/toolkit/jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/webview/ToolkitLoginWebview.kt
@@ -151,7 +151,6 @@ class ToolkitWebviewBrowser(val project: Project, private val parentDisposable:
         JBCefBrowserBuilder()
             .setClient(client)
             .setOffScreenRendering(true)
-            .setCreateImmediately(true)
             .build()
     }
     override val query: JBCefJSQuery = JBCefJSQuery.create(jcefBrowser)

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,5 @@ fun createBrowser(parent: Disposable): JBCefBrowserBase {`
`17`	`17`	`return JBCefBrowserBuilder()`
`18`	`18`	`.setClient(client)`
`19`	`19`	`.setOffScreenRendering(true)`
`20`		`- .setCreateImmediately(true)`
`21`	`20`	`.build()`
`22`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,6 @@ class ToolkitWebviewBrowser(val project: Project, private val parentDisposable:`
`151`	`151`	`JBCefBrowserBuilder()`
`152`	`152`	`.setClient(client)`
`153`	`153`	`.setOffScreenRendering(true)`
`154`		`- .setCreateImmediately(true)`
`155`	`154`	`.build()`
`156`	`155`	`}`
`157`	`156`	`override val query: JBCefJSQuery = JBCefJSQuery.create(jcefBrowser)`