Skip to content

Commit 081c9b3

Browse files
liuzulinsjc25-test
andauthored
feat(sagemakerunifiedstudio): Add S3 nodes and Redshift nodes to SageMaker Unified Studio data explorer (aws#2182)
## Problem Need to implement S3 nodes and Redshift nodes for SageMaker Unified Studio data explorer ## Solution 1. For files under shared/client: Implement or update following files: datazoneClient.ts, gluePrivateClient.ts, S3Client.ts, sqlWorkbenchClient.ts 2. For files under explorer/nodes: Start with sageMakerUnifiedStudioProjectNode. it will simply load a new data node sageMakerUnifedStudioDataNode , this file will then based on the connection type render nodes with s3Strategy and redshiftStrategy 3. Common types and utils are extracted into types.ts and utils.ts --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Zulin Liu <[email protected]>
1 parent 8033b63 commit 081c9b3

27 files changed

+10672
-235
lines changed

package-lock.json

Lines changed: 186 additions & 157 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@
7474
"webpack-merge": "^5.10.0"
7575
},
7676
"dependencies": {
77-
"@aws-sdk/client-datazone": "^3.835.0",
7877
"@types/node": "^22.7.5",
7978
"jaro-winkler": "^0.2.8",
8079
"vscode-nls": "^5.2.0",

packages/core/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -539,6 +539,7 @@
539539
"@aws-sdk/client-cloudwatch-logs": "<3.731.0",
540540
"@aws-sdk/client-codecatalyst": "<3.731.0",
541541
"@aws-sdk/client-cognito-identity": "<3.731.0",
542+
"@aws-sdk/client-datazone": "^3.848.0",
542543
"@aws-sdk/client-docdb": "<3.731.0",
543544
"@aws-sdk/client-docdb-elastic": "<3.731.0",
544545
"@aws-sdk/client-ec2": "<3.731.0",

packages/core/scripts/build/generateServiceClient.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,14 @@ void (async () => {
241241
serviceJsonPath: 'src/codewhisperer/client/user-service-2.json',
242242
serviceName: 'CodeWhispererUserClient',
243243
},
244+
{
245+
serviceJsonPath: 'src/sagemakerunifiedstudio/shared/client/gluecatalogapi.json',
246+
serviceName: 'GlueCatalogApi',
247+
},
248+
{
249+
serviceJsonPath: 'src/sagemakerunifiedstudio/shared/client/sqlworkbench.json',
250+
serviceName: 'SQLWorkbench',
251+
},
244252
]
245253
await generateServiceClients(serviceClientDefinitions)
246254
})()

0 commit comments

Comments
 (0)