Skip to content

Commit 5881a76

Browse files
authored
Merge branch 'aws:master' into master
2 parents 282317c + 9afc587 commit 5881a76

File tree

81 files changed

+2584
-496
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

81 files changed

+2584
-496
lines changed

buildspec/release/70checkmarketplace.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,32 @@ phases:
2222
build:
2323
commands:
2424
- VERSION=$(node -e "console.log(require('./packages/${TARGET_EXTENSION}/package.json').version);")
25-
# get extension name
25+
# get extension name, if in beta, use some hard-coded recent version
2626
- |
2727
if [ "${TARGET_EXTENSION}" = "amazonq" ]; then
2828
extension_name="amazonwebservices.amazon-q-vscode"
29+
[ "$STAGE" != "prod" ] && VERSION="1.43.0" || true
2930
elif [ "${TARGET_EXTENSION}" = "toolkit" ]; then
3031
extension_name="amazonwebservices.aws-toolkit-vscode"
32+
[ "$STAGE" != "prod" ] && VERSION="3.42.0" || true
3133
else
3234
echo checkmarketplace: "Unknown TARGET_EXTENSION: ${TARGET_EXTENSION}"
3335
exit 1
3436
fi
35-
# keep reinstalling the extension until the desired version is updated. Otherwise fail on codebuild timeout (1 hour).
37+
if [ "$STAGE" != "prod" ]; then
38+
echo "checkmarketplace: Non-production stage detected. Installing hardcoded version '${VERSION}'."
39+
fi
40+
# keep installing the desired extension version until successful. Otherwise fail on codebuild timeout (1 hour).
3641
- |
3742
while true; do
3843
code --uninstall-extension "${extension_name}" --no-sandbox --user-data-dir /tmp/vscode
39-
code --install-extension ${extension_name} --no-sandbox --user-data-dir /tmp/vscode
44+
code --install-extension "${extension_name}@${VERSION}" --no-sandbox --user-data-dir /tmp/vscode || true
4045
cur_version=$(code --list-extensions --show-versions --no-sandbox --user-data-dir /tmp/vscode | grep ${extension_name} | cut -d'@' -f2)
4146
if [ "${cur_version}" = "${VERSION}" ]; then
4247
echo "checkmarketplace: Extension ${extension_name} is updated to version '${cur_version}.'"
4348
break
4449
else
45-
echo "checkmarketplace: Current version '${cur_version}' does not match expected version '${VERSION}'. Retrying..."
50+
echo "checkmarketplace: Expected extension version '${VERSION}' has not been successfully installed. Retrying..."
4651
fi
4752
sleep 120 # Wait for 2 minutes before retrying
4853
done

docs/web.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ You can run the Web mode implementation of the extension in the following ways.
1616
- To see logs, using the Command Palette search: `Toggle Developer Tools`. Then go to the `Console` tab. In web mode VS Code seems to duplicate log messages, idk how to fix this.
1717
- The difference between web mode and Node.js/desktop is that in web mode everything runs in browser environment so certain things like Node.js modules will **not** be available.
1818

19-
## Running in an actual Browser
19+
## Running in an actual Browser (Recommended)
2020

2121
The following steps will result in a Chrome window running with VS Code
2222
and the web version of the AWS Toolkit extension installed:
@@ -43,7 +43,7 @@ and the web version of the AWS Toolkit extension installed:
4343
const context = browser
4444
```
4545

46-
2. In the `Run & Debug` menu select the `Extension (Chrome)` option
46+
2. In the `Run & Debug` menu select the `Extension Web` option
4747

4848
> Note: To stop the debug session, you need to click the read `Disconnect` button multiple times
4949

@@ -62,6 +62,12 @@ do the following:
6262

6363
Now when you run the extension in the browser it will do CORS checks.
6464

65+
### Troubleshooting
66+
67+
- `Extension Web` fails to launch
68+
- Update `@vscode/test-web` by running `$ npm install @vscode/test-web@latest`
69+
- Update/install playwright with `$ npx playwright install`. This will be mentioned in one of the build tasks outputs.
70+
6571
## Running in [vscode.dev](https://vscode.dev)
6672

6773
The following will explain how to get your latest local development changes running in the actual `vscode.dev`. Use this if you want to test on an actual VS Code Web instance.

0 commit comments

Comments
 (0)