Skip to content

Commit 5cd0fef

Browse files
committed
CW: Code Refactoring
1 parent 9494050 commit 5cd0fef

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

src/codewhisperer/util/dependencyGraph/rubyDependencyGraph.ts

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -71,38 +71,29 @@ export class RubyDependencyGraph extends DependencyGraph {
7171
} = DependencyGraphConstants
7272

7373
let keyword: string | undefined
74-
let indexOfKeyword: number | undefined
7574

7675
switch (true) {
7776
case importStr.startsWith(requireRelativeKeyword):
7877
keyword = requireRelativeKeyword
79-
indexOfKeyword = importStr.indexOf(requireRelativeKeyword)
8078
break
8179
case importStr.startsWith(requireKeyword):
8280
keyword = requireKeyword
83-
indexOfKeyword = importStr.indexOf(requireKeyword)
8481
break
8582
case importStr.startsWith(includeKeyword):
8683
keyword = includeKeyword
87-
indexOfKeyword = importStr.indexOf(includeKeyword)
8884
break
8985
case importStr.startsWith(extendKeyword):
9086
keyword = extendKeyword
91-
indexOfKeyword = importStr.indexOf(extendKeyword)
9287
break
9388
case importStr.startsWith(loadKeyword):
9489
keyword = loadKeyword
95-
indexOfKeyword = importStr.indexOf(loadKeyword)
9690
break
9791
default:
9892
break
9993
}
10094

101-
if (keyword && indexOfKeyword !== -1 && keyword !== undefined && indexOfKeyword !== undefined) {
102-
const modulePathStr = importStr
103-
.substring(indexOfKeyword + keyword.length)
104-
.trim()
105-
.replace(/\s+/g, '')
95+
if (keyword && keyword !== undefined) {
96+
const modulePathStr = importStr.substring(keyword.length).trim().replace(/\s+/g, '')
10697
modulePaths = this.getModulePath(modulePathStr)
10798
}
10899

@@ -162,9 +153,9 @@ export class RubyDependencyGraph extends DependencyGraph {
162153
const content: string = await readFileAsString(uri.fsPath)
163154
const imports = await this.readImports(content)
164155
const dependencies = this.getDependencies(uri, imports)
165-
dependencies.forEach(dependency => {
156+
for (const dependency of dependencies) {
166157
q.push(dependency)
167-
})
158+
}
168159
}
169160
}
170161
return this._pickedSourceFiles

0 commit comments

Comments
 (0)