Skip to content

Commit 990def6

Browse files
committed
Merge master branch and resolve conflicts
2 parents c5b9976 + 6c7f040 commit 990def6

31 files changed

+82
-1302
lines changed

package-lock.json

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"date": "2025-07-19",
3+
"version": "1.85.0",
4+
"entries": []
5+
}

packages/amazonq/.changes/next-release/Bug Fix-316fb610-0ea9-40d1-bdb7-d371a6be4a4e.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/amazonq/.changes/next-release/Bug Fix-9d694e40-7fc7-4504-b08c-6b22a5ebcb1c.json

Lines changed: 0 additions & 4 deletions
This file was deleted.

packages/amazonq/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 1.85.0 2025-07-19
2+
3+
- Miscellaneous non-user-facing changes
4+
15
## 1.84.0 2025-07-17
26

37
- **Bug Fix** Slightly delay rendering inline completion when user is typing

packages/amazonq/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "amazon-q-vscode",
33
"displayName": "Amazon Q",
44
"description": "The most capable generative AI-powered assistant for building, operating, and transforming software, with advanced capabilities for managing data and AI",
5-
"version": "1.85.0-SNAPSHOT",
5+
"version": "1.86.0-SNAPSHOT",
66
"extensionKind": [
77
"workspace"
88
],

packages/amazonq/src/app/inline/EditRendering/imageRenderer.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ export async function showEdits(
2929
const { svgImage, startLine, newCode, origionalCodeHighlightRange } =
3030
await svgGenerationService.generateDiffSvg(currentFile, item.insertText as string)
3131

32-
// TODO: To investigate why it fails and patch [generateDiffSvg]
33-
if (newCode.length === 0) {
34-
getLogger('nextEditPrediction').warn('not able to apply provided edit suggestion, skip rendering')
35-
return
36-
}
37-
3832
if (svgImage) {
3933
// display the SVG image
4034
await displaySvgDecoration(

packages/amazonq/src/app/inline/completion.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -241,12 +241,6 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
241241
return []
242242
}
243243

244-
const isAutoTrigger = context.triggerKind === InlineCompletionTriggerKind.Automatic
245-
if (isAutoTrigger && !CodeSuggestionsState.instance.isSuggestionsEnabled()) {
246-
// return early when suggestions are disabled with auto trigger
247-
return []
248-
}
249-
250244
// yield event loop to let the document listen catch updates
251245
await sleep(1)
252246
// prevent user deletion invoking auto trigger
@@ -260,6 +254,12 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
260254
try {
261255
const t0 = performance.now()
262256
vsCodeState.isRecommendationsActive = true
257+
const isAutoTrigger = context.triggerKind === InlineCompletionTriggerKind.Automatic
258+
if (isAutoTrigger && !CodeSuggestionsState.instance.isSuggestionsEnabled()) {
259+
// return early when suggestions are disabled with auto trigger
260+
return []
261+
}
262+
263263
// handling previous session
264264
const prevSession = this.sessionManager.getActiveSession()
265265
const prevSessionId = prevSession?.sessionId
@@ -335,8 +335,7 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
335335
context,
336336
token,
337337
isAutoTrigger,
338-
getAllRecommendationsOptions,
339-
this.documentEventListener.getLastDocumentChangeEvent(document.uri.fsPath)?.event
338+
getAllRecommendationsOptions
340339
)
341340
// get active item from session for displaying
342341
const items = this.sessionManager.getActiveRecommendation()

packages/amazonq/src/app/inline/documentEventListener.ts

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ export class DocumentEventListener {
2121
this.lastDocumentChangeEventMap.clear()
2222
}
2323
this.lastDocumentChangeEventMap.set(e.document.uri.fsPath, { event: e, timestamp: performance.now() })
24-
// The VS Code provideInlineCompletionCallback may not trigger when Enter is pressed, especially in Python files
25-
// manually make this trigger. In case of duplicate, the provideInlineCompletionCallback is already debounced
26-
if (this.isEnter(e) && vscode.window.activeTextEditor) {
27-
void vscode.commands.executeCommand('editor.action.inlineSuggest.trigger')
28-
}
2924
}
3025
})
3126
}
@@ -52,18 +47,4 @@ export class DocumentEventListener {
5247
this.documentChangeListener.dispose()
5348
}
5449
}
55-
56-
private isEnter(e: vscode.TextDocumentChangeEvent): boolean {
57-
if (e.contentChanges.length !== 1) {
58-
return false
59-
}
60-
const str = e.contentChanges[0].text
61-
if (str.length === 0) {
62-
return false
63-
}
64-
return (
65-
(str.startsWith('\r\n') && str.substring(2).trim() === '') ||
66-
(str[0] === '\n' && str.substring(1).trim() === '')
67-
)
68-
}
6950
}

packages/amazonq/src/app/inline/recommendationService.ts

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@
22
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
33
* SPDX-License-Identifier: Apache-2.0
44
*/
5-
import * as vscode from 'vscode'
65
import {
76
InlineCompletionListWithReferences,
87
InlineCompletionWithReferencesParams,
98
inlineCompletionWithReferencesRequestType,
10-
TextDocumentContentChangeEvent,
119
} from '@aws/language-server-runtimes/protocol'
1210
import { CancellationToken, InlineCompletionContext, Position, TextDocument } from 'vscode'
1311
import { LanguageClient } from 'vscode-languageclient'
@@ -42,28 +40,17 @@ export class RecommendationService {
4240
context: InlineCompletionContext,
4341
token: CancellationToken,
4442
isAutoTrigger: boolean,
45-
options: GetAllRecommendationsOptions = { emitTelemetry: true, showUi: true },
46-
documentChangeEvent?: vscode.TextDocumentChangeEvent
43+
options: GetAllRecommendationsOptions = { emitTelemetry: true, showUi: true }
4744
) {
4845
// Record that a regular request is being made
4946
this.cursorUpdateRecorder?.recordCompletionRequest()
50-
const documentChangeParams = documentChangeEvent
51-
? {
52-
textDocument: {
53-
uri: document.uri.toString(),
54-
version: document.version,
55-
},
56-
contentChanges: documentChangeEvent.contentChanges.map((x) => x as TextDocumentContentChangeEvent),
57-
}
58-
: undefined
5947

6048
let request: InlineCompletionWithReferencesParams = {
6149
textDocument: {
6250
uri: document.uri.toString(),
6351
},
6452
position,
6553
context,
66-
documentChangeParams: documentChangeParams,
6754
}
6855
if (options.editsStreakToken) {
6956
request = { ...request, partialResultToken: options.editsStreakToken }

0 commit comments

Comments
 (0)