Skip to content

Commit 9a04527

Browse files
committed
Removing statusCode from the UTG telemetry event
1 parent f5e043e commit 9a04527

File tree

5 files changed

+100
-79
lines changed

5 files changed

+100
-79
lines changed

packages/core/src/amazonqTest/error.ts

Lines changed: 13 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,69 +11,57 @@ export class TestGenError extends ToolkitError {
1111
constructor(
1212
error: string,
1313
code: string,
14-
public statusCode: number,
1514
public uiMessage: string
1615
) {
1716
super(error, { code })
1817
}
1918
}
2019
export class ProjectZipError extends TestGenError {
2120
constructor(error: string) {
22-
super(error, 'ProjectZipError', 400, defaultTestGenErrorMessage)
21+
super(error, 'ProjectZipError', defaultTestGenErrorMessage)
2322
}
2423
}
2524
export class InvalidSourceZipError extends TestGenError {
2625
constructor() {
27-
super('Failed to create valid source zip', 'InvalidSourceZipError', 400, defaultTestGenErrorMessage)
26+
super('Failed to create valid source zip', 'InvalidSourceZipError', defaultTestGenErrorMessage)
2827
}
2928
}
3029
export class CreateUploadUrlError extends TestGenError {
31-
constructor(errorMessage: string, errorCode: number) {
32-
super(errorMessage, 'CreateUploadUrlError', errorCode, technicalErrorCustomerFacingMessage)
30+
constructor(errorMessage: string) {
31+
super(errorMessage, 'CreateUploadUrlError', technicalErrorCustomerFacingMessage)
3332
}
3433
}
3534
export class UploadTestArtifactToS3Error extends TestGenError {
36-
constructor(error: string, statusCode?: number) {
37-
super(error, 'UploadTestArtifactToS3Error', statusCode ?? 400, technicalErrorCustomerFacingMessage)
35+
constructor(error: string) {
36+
super(error, 'UploadTestArtifactToS3Error', technicalErrorCustomerFacingMessage)
3837
}
3938
}
4039
export class CreateTestJobError extends TestGenError {
41-
constructor(error: string, statusCode: number) {
42-
super(error, 'CreateTestJobError', statusCode, technicalErrorCustomerFacingMessage)
40+
constructor(error: string) {
41+
super(error, 'CreateTestJobError', technicalErrorCustomerFacingMessage)
4342
}
4443
}
4544
export class TestGenTimedOutError extends TestGenError {
4645
constructor() {
4746
super(
4847
'Test generation failed. Amazon Q timed out.',
4948
'TestGenTimedOutError',
50-
500,
5149
technicalErrorCustomerFacingMessage
5250
)
5351
}
5452
}
5553
export class TestGenStoppedError extends TestGenError {
5654
constructor() {
57-
super('Unit test generation cancelled.', 'TestGenCancelled', 400, 'Unit test generation cancelled.')
55+
super('Unit test generation cancelled.', 'TestGenCancelled', 'Unit test generation cancelled.')
5856
}
5957
}
6058
export class TestGenFailedError extends TestGenError {
61-
constructor(statusCode: number, error?: string) {
62-
super(
63-
error ?? 'Test generation failed',
64-
'TestGenFailedError',
65-
statusCode,
66-
error ?? technicalErrorCustomerFacingMessage
67-
)
59+
constructor(error?: string) {
60+
super(error ?? 'Test generation failed', 'TestGenFailedError', error ?? technicalErrorCustomerFacingMessage)
6861
}
6962
}
7063
export class ExportResultsArchiveError extends TestGenError {
71-
constructor(error?: string, statusCode?: number) {
72-
super(
73-
error ?? 'Test generation failed',
74-
'ExportResultsArchiveError',
75-
statusCode ?? 400,
76-
technicalErrorCustomerFacingMessage
77-
)
64+
constructor(error?: string) {
65+
super(error ?? 'Test generation failed', 'ExportResultsArchiveError', technicalErrorCustomerFacingMessage)
7866
}
7967
}

packages/core/src/codewhisperer/commands/startTestGeneration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export async function startTestGenerationProcess(
122122
// TODO: Send status to test summary
123123
if (jobStatus === TestGenerationJobStatus.FAILED) {
124124
logger.verbose(`Test generation failed.`)
125-
throw new TestGenFailedError(500)
125+
throw new TestGenFailedError()
126126
}
127127
throwIfCancelled()
128128
if (!shouldContinueRunning(tabID)) {

packages/core/src/codewhisperer/service/securityScanHandler.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -384,9 +384,7 @@ export async function uploadArtifactToS3(
384384
} else {
385385
errorMessage = errorDesc ?? defaultMessage
386386
}
387-
throw isCodeScan
388-
? new UploadArtifactToS3Error(errorMessage)
389-
: new UploadTestArtifactToS3Error(errorMessage, (error as any).statusCode)
387+
throw isCodeScan ? new UploadArtifactToS3Error(errorMessage) : new UploadTestArtifactToS3Error(errorMessage)
390388
}
391389
}
392390

packages/core/src/codewhisperer/service/testGenHandler.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export async function getPresignedUrlAndUploadTestGen(zipMetadata: ZipMetadata)
5555
logger.verbose(`Prepare for uploading src context...`)
5656
const srcResp = await codeWhisperer.codeWhispererClient.createUploadUrl(srcReq).catch((err) => {
5757
getLogger().error(`Failed getting presigned url for uploading src context. Request id: ${err.requestId}`)
58-
throw new CreateUploadUrlError(err.message, err.code)
58+
throw new CreateUploadUrlError(err.message)
5959
})
6060
logger.verbose(`CreateUploadUrlRequest requestId: ${srcResp.$response.requestId}`)
6161
logger.verbose(`Complete Getting presigned Url for uploading src context.`)
@@ -104,7 +104,7 @@ export async function createTestJob(
104104
const resp = await codewhispererClient.codeWhispererClient.startTestGeneration(req).catch((err) => {
105105
ChatSessionManager.Instance.getSession().startTestGenerationRequestId = err.requestId
106106
logger.error(`Failed creating test job. Request id: ${err.requestId}`)
107-
throw new CreateTestJobError(err.message, err.statusCode)
107+
throw new CreateTestJobError(err.message)
108108
})
109109
logger.info('Unit test generation request id: %s', resp.$response.requestId)
110110
logger.debug('Unit test generation data: %O', resp.$response.data)
@@ -159,7 +159,7 @@ export async function pollTestJobStatus(
159159
// Stop the Unit test generation workflow if IDE receive stopIteration = true
160160
if (shortAnswer.stopIteration === 'true') {
161161
session.stopIteration = true
162-
throw new TestGenFailedError(400, shortAnswer.planSummary)
162+
throw new TestGenFailedError(shortAnswer.planSummary)
163163
}
164164
if (shortAnswer.numberOfTestMethods) {
165165
session.numberOfTestsGenerated = Number(shortAnswer.numberOfTestMethods)
@@ -297,7 +297,7 @@ export async function downloadResultArchive(
297297
} catch (e: any) {
298298
downloadErrorMessage = (e as Error).message
299299
getLogger().error(`Unit Test Generation: ExportResultArchive error = ${downloadErrorMessage}`)
300-
throw new ExportResultsArchiveError(downloadErrorMessage, e.statusCode)
300+
throw new ExportResultsArchiveError(downloadErrorMessage)
301301
} finally {
302302
cwStreamingClient.destroy()
303303
}

0 commit comments

Comments
 (0)