Skip to content

Commit 9a97f8a

Browse files
authored
ci(run_and_report): remove workaround for vscode 1.68 aws#6121
## Problem Ignore pattern that is only needed on the vscode minimum version of 1.68, but we have bumped to 1.83.0. ## Solution Remove pattern for this case.
1 parent c4f965f commit 9a97f8a

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

buildspec/shared/common.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,9 @@
66

77
# Ignore these patterns when deciding if the build should fail.
88
# - "waiting for browser": from `ssoAccessTokenProvider.test.ts`, unclear how to fix it.
9-
# - "Webview is disposed": only happens on vscode "minimum" (1.68.0)
109
# - "HTTPError: Response code …": caused by github rate-limiting.
1110
# - "npm WARN deprecated querystring": transitive dep of aws sdk v2 (check `npm ls querystring`), so that's blocked until we migrate to v3.
1211
_ignore_pat='Timed-out waiting for browser login flow\|HTTPError: Response code 403\|HTTPError: Response code 404\|npm WARN deprecated querystring\|npm WARN deprecated'
13-
if [ "$VSCODE_TEST_VERSION" = 'minimum' ]; then
14-
_ignore_pat="$_ignore_pat"'\|Webview is disposed'
15-
fi
1612

1713
# Do not print (noisy) lines matching these patterns.
1814
# - "ERROR:bus… Failed to connect to the bus": noise related to "xvfb". https://github.com/cypress-io/cypress/issues/19299

0 commit comments

Comments
 (0)