Skip to content

Commit aa43192

Browse files
committed
fix: passing nextToken to Flare for Edits
1 parent c4f99f3 commit aa43192

File tree

4 files changed

+22
-12
lines changed

4 files changed

+22
-12
lines changed

packages/amazonq/src/app/inline/EditRendering/displayImage.ts

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -318,18 +318,20 @@ export async function displaySvgDecoration(
318318
isInlineEdit: true,
319319
}
320320
languageClient.sendNotification('aws/logInlineCompletionSessionResults', params)
321-
if (inlineCompletionProvider) {
322-
await inlineCompletionProvider.provideInlineCompletionItems(
323-
editor.document,
324-
endPosition,
325-
{
326-
triggerKind: vscode.InlineCompletionTriggerKind.Automatic,
327-
selectedCompletionInfo: undefined,
328-
},
329-
new vscode.CancellationTokenSource().token,
330-
{ emitTelemetry: false, showUi: false, editsStreakToken: session.editsStreakPartialResultToken }
331-
)
332-
}
321+
session.triggerOnAcceptance = true
322+
// VS Code triggers suggestion on every keystroke, temporarily disable trigger on acceptance
323+
// if (inlineCompletionProvider) {
324+
// await inlineCompletionProvider.provideInlineCompletionItems(
325+
// editor.document,
326+
// endPosition,
327+
// {
328+
// triggerKind: vscode.InlineCompletionTriggerKind.Automatic,
329+
// selectedCompletionInfo: undefined,
330+
// },
331+
// new vscode.CancellationTokenSource().token,
332+
// { emitTelemetry: false, showUi: false, editsStreakToken: session.editsStreakPartialResultToken }
333+
// )
334+
// }
333335
},
334336
async () => {
335337
// Handle reject

packages/amazonq/src/app/inline/completion.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -253,6 +253,12 @@ export class AmazonQInlineCompletionItemProvider implements InlineCompletionItem
253253
const prevSessionId = prevSession?.sessionId
254254
const prevItemId = this.sessionManager.getActiveRecommendation()?.[0]?.itemId
255255
const prevStartPosition = prevSession?.startPosition
256+
if (prevSession?.triggerOnAcceptance) {
257+
getAllRecommendationsOptions = {
258+
...getAllRecommendationsOptions,
259+
editsStreakToken: prevSession?.editsStreakPartialResultToken,
260+
}
261+
}
256262
const editor = window.activeTextEditor
257263
if (prevSession && prevSessionId && prevItemId && prevStartPosition) {
258264
const prefix = document.getText(new Range(prevStartPosition, position))

packages/amazonq/src/app/inline/recommendationService.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export class RecommendationService {
7777
textDocument: request.textDocument,
7878
position: request.position,
7979
context: request.context,
80+
partialResultToken: request.partialResultToken,
8081
},
8182
})
8283
let result: InlineCompletionListWithReferences = await languageClient.sendRequest(

packages/amazonq/src/app/inline/sessionManager.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export interface CodeWhispererSession {
1616
startPosition: vscode.Position
1717
// partialResultToken for the next trigger if user accepts an EDITS suggestion
1818
editsStreakPartialResultToken?: number | string
19+
triggerOnAcceptance?: boolean
1920
}
2021

2122
export class SessionManager {

0 commit comments

Comments
 (0)