fix: using event-driven approach instead of arbitary values for fixing the icon missing issue

Author: laileni-aws

packages/amazonq/src/lsp/chat/messages.ts

@@ -48,6 +48,7 @@ import {
     LINK_CLICK_NOTIFICATION_METHOD,
     LinkClickParams,
     INFO_LINK_CLICK_NOTIFICATION_METHOD,
+    READY_NOTIFICATION_METHOD,
     buttonClickRequestType,
     ButtonClickResult,
     CancellationTokenSource,
@@ -114,37 +115,6 @@ export function registerLanguageServerEventListener(languageClient: LanguageClie
         chatOptions.quickActions.quickActionsCommandGroups[0].groupName = 'Quick Actions'
     }
 
-    provider.onDidResolveWebview(() => {
-        // Give the webview a moment to fully initialize before sending messages
-        setTimeout(() => {
-            if (provider.webview) {
-                // Ensure webview is ready and properly initialized
-                const sendPromise = provider.webview
-                    .postMessage({
-                        command: CHAT_OPTIONS,
-                        params: chatOptions,
-                    })
-                    .then(() => {
-                        // Log success only after message is confirmed sent
-                        const quickActionCommands =
-                            chatOptions?.quickActions?.quickActionsCommandGroups?.[0]?.commands || []
-                        const quickActionsDisplay = quickActionCommands.map((cmd: any) => cmd.command).join(', ')
-                        languageClient.info(
-                            `[VSCode Client] Chat options flags: mcpServers=${chatOptions?.mcpServers}, history=${chatOptions?.history}, export=${chatOptions?.export}, quickActions=[${quickActionsDisplay}]`
-                        )
-                    })
-
-                // Handle potential errors separately since PromiseLike might not have catch
-                sendPromise.then(undefined, (err: Error) => {
-                    // Log any errors that occur during message sending
-                    languageClient.error(`[VSCode Client] Failed to send CHAT_OPTIONS: ${err.message}`)
-                })
-            } else {
-                languageClient.warn(`[VSCode Client] Cannot send CHAT_OPTIONS: webview is not available`)
-            }
-        }, 100) // Short delay of 100ms to ensure webview is ready
-    })
-
     // This passes through metric data from LSP events to Toolkit telemetry with all fields from the LSP server
     languageClient.onTelemetry((e) => {
         const telemetryName: string = e.name
@@ -177,6 +147,10 @@ export function registerMessageListeners(
     encryptionKey: Buffer
 ) {
     const chatStreamTokens = new Map<string, CancellationTokenSource>() // tab id -> token
+
+    // Keep track of pending chat options to send when webview UI is ready
+    const pendingChatOptions = languageClient.initializeResult?.awsServerCapabilities?.chatOptions
+
     provider.webview?.onDidReceiveMessage(async (message) => {
         languageClient.info(`[VSCode Client]  Received ${JSON.stringify(message)} from chat`)
 
@@ -190,7 +164,32 @@ export function registerMessageListeners(
         }
 
         const webview = provider.webview
+
         switch (message.command) {
+            // Handle "aws/chat/ready" event
+            case READY_NOTIFICATION_METHOD:
+                languageClient.info(`[VSCode Client] "aws/chat/ready" event is received, sending chat options`)
+                if (webview && pendingChatOptions) {
+                    try {
+                        await webview.postMessage({
+                            command: CHAT_OPTIONS,
+                            params: pendingChatOptions,
+                        })
+
+                        // Display a more readable representation of quick actions
+                        const quickActionCommands =
+                            pendingChatOptions?.quickActions?.quickActionsCommandGroups?.[0]?.commands || []
+                        const quickActionsDisplay = quickActionCommands.map((cmd: any) => cmd.command).join(', ')
+                        languageClient.info(
+                            `[VSCode Client] Chat options flags: mcpServers=${pendingChatOptions?.mcpServers}, history=${pendingChatOptions?.history}, export=${pendingChatOptions?.export}, quickActions=[${quickActionsDisplay}]`
+                        )
+                    } catch (err) {
+                        languageClient.error(
+                            `[VSCode Client] Failed to send CHAT_OPTIONS after "aws/chat/ready" event: ${(err as Error).message}`
+                        )
+                    }
+                }
+                break
             case COPY_TO_CLIPBOARD:
                 languageClient.info('[VSCode Client] Copy to clipboard event received')
                 try {