Skip to content

Commit c6845d1

Browse files
committed
replacing customerFacingMessage with UiMessage
1 parent b59dc27 commit c6845d1

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

packages/core/src/amazonqTest/chat/controller/controller.ts

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ export class TestController {
242242
// eslint-disable-next-line unicorn/no-null
243243
this.messenger.sendUpdatePromptProgress(data.tabID, null)
244244
const session = this.sessionStorage.getSession()
245-
const isCancel = data.error.customerFacingMessage === unitTestGenerationCancelMessage
245+
const isCancel = data.error.uiMessage === unitTestGenerationCancelMessage
246246
telemetry.amazonq_utgGenerateTests.emit({
247247
cwsprChatProgrammingLanguage: session.fileLanguage ?? 'plaintext',
248248
jobId: session.listOfTestGenerationJobId[0], // For RIV, UTG does only one StartTestGeneration API call
@@ -255,17 +255,18 @@ export class TestController {
255255
artifactsUploadDuration: session.artifactsUploadDuration,
256256
perfClientLatency: performance.now() - session.testGenerationStartTime,
257257
result: isCancel ? 'Cancelled' : 'Failed',
258+
reason: data.error.code,
258259
reasonDesc: getTelemetryReasonDesc(data.error),
259260
isSupportedLanguage: true,
260261
credentialStartUrl: AuthUtil.instance.startUrl,
261262
httpStatusCode: data.error.statusCode ?? 0, // If status code is 0, need to investigate where this is originating from.
262263
})
263264
if (session.stopIteration) {
264265
// Error from Science
265-
this.messenger.sendMessage(data.error.customerFacingMessage.replaceAll('```', ''), data.tabID, 'answer')
266+
this.messenger.sendMessage(data.error.uiMessage.replaceAll('```', ''), data.tabID, 'answer')
266267
} else {
267268
isCancel
268-
? this.messenger.sendMessage(data.error.customerFacingMessage, data.tabID, 'answer')
269+
? this.messenger.sendMessage(data.error.uiMessage, data.tabID, 'answer')
269270
: this.sendErrorMessage(data)
270271
}
271272
await this.sessionCleanUp()
@@ -274,7 +275,7 @@ export class TestController {
274275
// Client side error messages
275276
private sendErrorMessage(data: {
276277
tabID: string
277-
error: { customerFacingMessage: string; message: string; code: string; statusCode: string }
278+
error: { uiMessage: string; message: string; code: string; statusCode: string }
278279
}) {
279280
const { error, tabID } = data
280281

@@ -308,7 +309,7 @@ export class TestController {
308309
}
309310
} else {
310311
// other unexpected errors (TODO enumerate all other failure cases)
311-
getLogger().error('Other error message: %s', error.customerFacingMessage)
312+
getLogger().error('Other error message: %s', error.uiMessage)
312313
this.messenger.sendErrorMessage('', tabID)
313314
}
314315
}
@@ -720,12 +721,7 @@ export class TestController {
720721
//this.messenger.sendMessage('Accepted', message.tabID, 'prompt')
721722
telemetry.ui_click.emit({ elementId: 'unitTestGeneration_acceptDiff' })
722723
getLogger().info(
723-
session.fileLanguage ?? 'plaintext',
724-
session.listOfTestGenerationJobId[0],
725-
session.testGenerationJobGroupName,
726-
'Succeeded',
727-
AuthUtil.instance.startUrl,
728-
'200'
724+
`Generated unit tests are accepted for ${session.fileLanguage ?? 'plaintext'} language with jobId: ${session.listOfTestGenerationJobId[0]}, jobGroupName: ${session.testGenerationJobGroupName}, result: Succeeded`
729725
)
730726
telemetry.amazonq_utgGenerateTests.emit({
731727
generatedCount: session.numberOfTestsGenerated,

packages/core/src/amazonqTest/error.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export class TestGenError extends ToolkitError {
1212
error: string,
1313
code: string,
1414
public statusCode: string,
15-
public customerFacingMessage: string
15+
public uiMessage: string
1616
) {
1717
super(error, { code })
1818
}

0 commit comments

Comments
 (0)