Ux changes in feedback mechanism V2 version

Author: laileni-aws

packages/core/src/amazonq/webview/ui/apps/testChatConnector.ts

@@ -86,6 +86,7 @@ export class Connector extends BaseConnector {
 
     onCustomFormAction(
         tabId: string,
+        messageId: string,
         action: {
             id: string
             text?: string | undefined
@@ -105,6 +106,34 @@ export class Connector extends BaseConnector {
             tabID: tabId,
             description: action.description,
         })
+
+        if (this.onChatAnswerUpdated === undefined) {
+            return
+        }
+        const answer: ChatItem = {
+            type: ChatItemType.ANSWER,
+            messageId: messageId,
+            buttons: [],
+        }
+
+        switch (action.id) {
+            case 'Provide-Feedback':
+                answer.buttons = [
+                    {
+                        keepCardAfterClick: true,
+                        text: 'Thanks for providing feedback.',
+                        id: 'utg_provided_feedback',
+                        status: 'success',
+                        position: 'outside',
+                        disabled: true,
+                    },
+                ]
+                break
+            default:
+                console.warn(`Unhandled action ID: ${action.id}`)
+                break
+        }
+        this.onChatAnswerUpdated(tabId, answer)
     }
 
     onFileDiff = (tabID: string, filePath: string, deleted: boolean, messageId?: string): void => {

packages/core/src/amazonq/webview/ui/connector.ts

@@ -681,7 +681,7 @@ export class Connector {
                 this.gumbyChatConnector.onCustomFormAction(tabId, action)
                 break
             case 'testgen':
-                this.testChatConnector.onCustomFormAction(tabId, action)
+                this.testChatConnector.onCustomFormAction(tabId, messageId ?? '', action)
                 break
             case 'review':
                 this.scanChatConnector.onCustomFormAction(tabId, action)

packages/core/src/amazonqTest/chat/controller/controller.ts

@@ -388,11 +388,6 @@ export class TestController {
                 getFeedbackCommentData = `Q Test Generation: RequestId: ${this.sessionStorage.getSession().startTestGenerationRequestId}, TestGenerationJobId: ${this.sessionStorage.getSession().testGenerationJob?.testGenerationJobId}`
                 void submitFeedback(placeholder, 'Amazon Q', getFeedbackCommentData)
                 telemetry.ui_click.emit({ elementId: 'unitTestGeneration_provideFeedback' })
-                this.messenger.sendMessage(
-                    'Unit test generation completed. Thanks for providing feedback.',
-                    data.tabID,
-                    'answer'
-                )
                 break
         }
     }
@@ -427,7 +422,7 @@ export class TestController {
         const buttons: ChatItemButton[] = []
         if (Auth.instance.isInternalAmazonUser()) {
             buttons.push({
-                keepCardAfterClick: false,
+                keepCardAfterClick: true,
                 text: 'How can we make /test better?',
                 id: ButtonActions.PROVIDE_FEEDBACK,
                 disabled: false, // allow button to be re-clicked