Skip to content

Commit f0988b2

Browse files
authored
fix(amazonq): align inline completion document selectors (aws#6827)
## Problem The inline completion document selectors between vscode's currently implementation and the new implementation aren't aligned ## Solution Rather than providing our own implementation that was originally stolen from [here](https://github.com/aws/language-servers/blob/main/client/vscode/src/inlineCompletionActivation.ts#L22) and expanding it, we should just use the exact document selectors that vscode already uses from [here](https://github.com/aws/aws-toolkit-vscode/blob/master/packages/core/src/codewhisperer/models/constants.ts#L104) --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 119d2f4 commit f0988b2

File tree

1 file changed

+2
-31
lines changed

1 file changed

+2
-31
lines changed

packages/amazonq/src/app/inline/completion.ts

Lines changed: 2 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -22,40 +22,11 @@ import {
2222
logInlineCompletionSessionResultsNotificationType,
2323
LogInlineCompletionSessionResultsParams,
2424
} from '@aws/language-server-runtimes/protocol'
25-
26-
export const CodewhispererInlineCompletionLanguages = [
27-
{ scheme: 'file', language: 'typescript' },
28-
{ scheme: 'file', language: 'javascript' },
29-
{ scheme: 'file', language: 'json' },
30-
{ scheme: 'file', language: 'yaml' },
31-
{ scheme: 'file', language: 'java' },
32-
{ scheme: 'file', language: 'go' },
33-
{ scheme: 'file', language: 'php' },
34-
{ scheme: 'file', language: 'rust' },
35-
{ scheme: 'file', language: 'kotlin' },
36-
{ scheme: 'file', language: 'terraform' },
37-
{ scheme: 'file', language: 'ruby' },
38-
{ scheme: 'file', language: 'shellscript' },
39-
{ scheme: 'file', language: 'dart' },
40-
{ scheme: 'file', language: 'lua' },
41-
{ scheme: 'file', language: 'powershell' },
42-
{ scheme: 'file', language: 'r' },
43-
{ scheme: 'file', language: 'swift' },
44-
{ scheme: 'file', language: 'systemverilog' },
45-
{ scheme: 'file', language: 'scala' },
46-
{ scheme: 'file', language: 'vue' },
47-
{ scheme: 'file', language: 'csharp' },
48-
{ scheme: 'file', language: 'python' },
49-
{ scheme: 'file', language: 'c' },
50-
{ scheme: 'file', language: 'cpp' },
51-
{ scheme: 'file', language: 'sql' },
52-
{ scheme: 'file', language: 'tsx' },
53-
{ scheme: 'file', language: 'jsx' },
54-
]
25+
import { CodeWhispererConstants } from 'aws-core-vscode/codewhisperer'
5526

5627
export function registerInlineCompletion(languageClient: LanguageClient) {
5728
const inlineCompletionProvider = new AmazonQInlineCompletionItemProvider(languageClient)
58-
languages.registerInlineCompletionItemProvider(CodewhispererInlineCompletionLanguages, inlineCompletionProvider)
29+
languages.registerInlineCompletionItemProvider(CodeWhispererConstants.platformLanguageIds, inlineCompletionProvider)
5930

6031
const onInlineAcceptance = async (
6132
sessionId: string,

0 commit comments

Comments
 (0)