telemetry(lambda): change toolId to 'localstack' on installation through walkthrough

But add ts-ignore until this value gets added to metric definitions [1]

[1]: https://github.com/aws/aws-toolkit-common/blob/8c88537fae2ac7e6524fb2b29ae336c606850eeb/telemetry/definitions/commonDefinitions.json#L2215-L2221

Author: valerena

packages/core/src/awsService/appBuilder/walkthrough.ts

@@ -350,8 +350,9 @@ export async function getOrInstallCliWrapper(toolId: AwsClis, source: string) {
 
 export async function installLocalStackExtension(source: string) {
     await telemetry.appBuilder_installTool.run(async (span) => {
-        // TODO: update `toolId` to "localstack" after updating the telemetry definitions: https://github.com/aws/aws-toolkit-common/blob/8c88537fae2ac7e6524fb2b29ae336c606850eeb/telemetry/definitions/commonDefinitions.json#L2215-L2221
-        const toolId: ToolId = 'sam-cli'
+        // TODO: Update `ToolId` accepted values: https://github.com/aws/aws-toolkit-common/blob/8c88537fae2ac7e6524fb2b29ae336c606850eeb/telemetry/definitions/commonDefinitions.json#L2215-L2221
+        // @ts-ignore
+        const toolId: ToolId = 'localstack'
         span.record({ source, toolId })
         const extensionId = 'localstack.localstack'
         const extension = vscode.extensions.getExtension(extensionId)

packages/core/src/test/awsService/appBuilder/walkthrough.test.ts

@@ -26,6 +26,7 @@ import { ChildProcess } from '../../../shared/utilities/processUtils'
 import { assertTelemetryCurried } from '../../testUtil'
 import { HttpResourceFetcher } from '../../../shared/resourcefetcher/node/httpResourceFetcher'
 import { SamCliInfoInvocation } from '../../../shared/sam/cli/samCliInfo'
+import type { ToolId } from '../../../shared/telemetry/telemetry'
 import { CodeScansState } from '../../../codewhisperer'
 
 interface TestScenario {
@@ -463,7 +464,8 @@ describe('AppBuilder Walkthrough', function () {
         })
 
         describe('Install LocalStack Extension', function () {
-            const expectedLocalStackToolId = 'sam-cli' // temporarily until toolkit-common changes
+            // @ts-ignore until TODO from src/awsService/appBuilder/walkthrough.ts:installLocalStackExtension
+            const expectedLocalStackToolId: ToolId = 'localstack'
 
             it('should show already installed message when extension exists', async function () {
                 const mockExtension = { id: 'localstack.localstack' }
@@ -485,7 +487,7 @@ describe('AppBuilder Walkthrough', function () {
                 assertTelemetry({
                     result: 'Succeeded',
                     source: 'test-source',
-                    toolId: expectedLocalStackToolId, // Note: currently uses sam-cli as toolId per TODO comment
+                    toolId: expectedLocalStackToolId,
                 })
             })