chore: remove useless conversion + rename var

Author: WilliamTakeshi

crypto/lakers-crypto-rustcrypto/src/lib.rs

@@ -88,27 +88,27 @@ impl<Rng: rand_core::RngCore + rand_core::CryptoRng> CryptoTrait for Crypto<Rng>
         )]
         match Tag::LEN {
             8 => {
-                let tag = AesCcm16_64_128::new(key.into())
+                let enc = AesCcm16_64_128::new(key.into())
                     .encrypt_in_place_detached(
                         iv.into(),
                         ad,
                         &mut outbuffer.content[..plaintext.len()],
                     )
                     .expect("Preconfigured sizes should not allow encryption to fail");
 
-                outbuffer.extend_from_slice(&tag).unwrap()
+                outbuffer.extend_from_slice(&enc).unwrap()
             }
 
             16 => {
-                let tag = AesCcm16_128_128::new(key.into())
+                let enc = AesCcm16_128_128::new(key.into())
                     .encrypt_in_place_detached(
                         iv.into(),
                         ad,
                         &mut outbuffer.content[..plaintext.len()],
                     )
                     .expect("Preconfigured sizes should not allow encryption to fail");
 
-                outbuffer.extend_from_slice(&tag).unwrap()
+                outbuffer.extend_from_slice(&enc).unwrap()
             }
 
             _ => unreachable!(), // CcmTagLen bound guarantees this

shared/src/crypto.rs

@@ -106,13 +106,11 @@ pub mod test_helper {
         let key: BytesCcmKeyLen = [
             0x26, 0x51, 0x1f, 0xb5, 0x1f, 0xcf, 0xa7, 0x5c, 0xb4, 0xb4, 0x4d, 0xa7, 0x5a, 0x6e,
             0x5a, 0x0e,
-        ]
-        .into();
+        ];
 
         let iv: BytesCcmIvLen = [
             0x5a, 0x8a, 0xa4, 0x85, 0xc3, 0x16, 0xe9, 0x40, 0x3a, 0xff, 0x85, 0x9f, 0xbb,
-        ]
-        .into();
+        ];
 
         let ad = [
             0xa1, 0x6a, 0x2e, 0x74, 0x1f, 0x1c, 0xd9, 0x71, 0x72, 0x85, 0xb6, 0xd8, 0x82, 0xc1,
@@ -139,13 +137,11 @@ pub mod test_helper {
         let key: BytesCcmKeyLen = [
             0x36, 0x8f, 0x35, 0xa1, 0xf8, 0x0e, 0xaa, 0xac, 0xd6, 0xbb, 0x13, 0x66, 0x09, 0x38,
             0x97, 0x27,
-        ]
-        .into();
+        ];
 
         let iv: BytesCcmIvLen = [
             0x84, 0x2a, 0x84, 0x45, 0x84, 0x75, 0x02, 0xea, 0x77, 0x36, 0x3a, 0x16, 0xb6,
-        ]
-        .into();
+        ];
 
         let ad = [
             0x34, 0x39, 0x6d, 0xfc, 0xfa, 0x6f, 0x74, 0x2a, 0xea, 0x70, 0x40, 0x97, 0x6b, 0xd5,
@@ -182,13 +178,11 @@ pub mod test_helper {
         let key: BytesCcmKeyLen = [
             0x41, 0x89, 0x35, 0x1b, 0x5c, 0xae, 0xa3, 0x75, 0xa0, 0x29, 0x9e, 0x81, 0xc6, 0x21,
             0xbf, 0x43,
-        ]
-        .into();
+        ];
 
         let iv: BytesCcmIvLen = [
             0x48, 0xc0, 0x90, 0x69, 0x30, 0x56, 0x1e, 0x0a, 0xb0, 0xef, 0x4c, 0xd9, 0x72,
-        ]
-        .into();
+        ];
 
         let ad = [
             0x40, 0xa2, 0x7c, 0x1d, 0x1e, 0x23, 0xea, 0x3d, 0xbe, 0x80, 0x56, 0xb2, 0x77, 0x48,