Minor Changes

lakshaykamat · lakshaykamat · commit 1632aea22a0b · 2024-03-04T00:22:34.000+05:30
- Add Title of ejs
- create error middle ware
diff --git a/routes/song.js b/routes/song.js
@@ -6,66 +6,5 @@ const router = express.Router();
 
 router.route("/").get(getAllSongs);
 router.route("/new").post(newSong);
-// /**
-//  * @route   GET /songs
-//  * @desc    Get all songs
-//  * @access  Public
-//  */
-// router.get("/", async (req, res) => {
-//   try {
-//     const songs = await getAllSongs();
-//     return res.json(songs);
-//   } catch (error) {
-//     console.error("Error fetching songs:", error.message);
-//     res.status(500).json({ error: "Internal Server Error" });
-//   }
-// });
-
-// /**
-//  * @route   POST /songs/new
-//  * @desc    Create new songs and update associated album
-//  * @access  Public
-//  */
-// router.post("/new", async (req, res) => {
-//   try {
-//     const songsData = req.body;
-//     console.log(songsData);
-
-//     // Ensure songsData is an array
-//     if (!Array.isArray(songsData)) {
-//       return res
-//         .status(400)
-//         .json({ error: "Invalid request. Expected an array of songs." });
-//     }
-
-//     const savedSongs = [];
-
-//     for (const { name, artist, albumId, duration } of songsData) {
-//       // Create a new song
-//       const song = new Song({ name, artist, albumId, duration });
-//       const savedSong = await song.save();
-
-//       // Update the associated album with the new song's ID
-//       const validAlbum = await getAlbum(albumId);
-
-//       if (!validAlbum) {
-//         return res.status(404).json({ error: "Album not found" });
-//       }
-
-//       // Add the new song's ID to the album's tracks array
-//       validAlbum.tracks.push(savedSong._id);
-//       await validAlbum.save();
-
-//       savedSongs.push(savedSong);
-//     }
-
-//     res.json(savedSongs);
-//   } catch (error) {
-//     console.error("Error creating songs and updating album:", error.message);
-//     res.status(500).json({ error: "Internal Server Error" });
-//   }
-// });
-
-// module.exports = router;
 
 module.exports = router;
diff --git a/views/index.ejs b/views/index.ejs
@@ -3,7 +3,9 @@
   <head>
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <title>Taylor Swift API</title>
+    <title>
+      Taylor Swift API | Open Source API for Taylor Swift Albums and Songs
+    </title>
     <!-- Include Tailwind CSS via CDN -->
     <link
       href="https://cdn.jsdelivr.net/npm/tailwindcss@2.2.19/dist/tailwind.min.css"
@@ -151,11 +153,11 @@
                   >GET</span
                 >
                 <a
-                  href="https://taylor-swift-api.onrender.com/album/65e41600f129029a20653d42"
+                  href="https://taylor-swift-api.onrender.com/album/Taylor%20Swift"
                   class="bg-gray-200 px-2 hover:underline py-1 rounded"
                   target="_blank"
                 >
-                  <code>/album/:id</code>
+                  <code>/album/:name</code>
                 </a>
               </div>
 
@@ -192,11 +194,11 @@
                   >GET</span
                 >
                 <a
-                  href="https://taylor-swift-api.onrender.com/songs"
+                  href="https://taylor-swift-api.onrender.com/song/Time%20McGraw"
                   class="bg-gray-200 px-2 hover:underline py-1 rounded"
                   target="_blank"
                 >
-                  <code>/song/:id</code>
+                  <code>/song/:name</code>
                 </a>
               </div>
               <p class="text-base">
@@ -206,9 +208,11 @@
           </li>
         </ol>
         <hr />
-        <button class="bg-gray-300 mt-4 text-center py-2 text-black w-full">
+        <button
+          class="flex sm:hidden bg-gray-300 mt-4 text-center py-2 text-black w-full"
+        >
           <a
-            class="flex sm:hidden items-center justify-center gap-2"
+            class="items-center justify-center gap-2"
             href="https://github.com/lakshaykamat/taylor-swift-api"
             target="_blank"
           >
