Skip to content

Commit fda329c

Browse files
committed
remove all instances of logger.py (see issue #1)
1 parent 3596bae commit fda329c

File tree

16 files changed

+215
-378
lines changed

16 files changed

+215
-378
lines changed

docs/development.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ kicad-mcp/
6161
│ ├── kicad_utils.py # KiCad-specific functions
6262
│ ├── python_path.py # Python path setup for KiCad modules
6363
│ ├── drc_history.py # DRC history tracking
64-
│ ├── env.py # Environment variable handling
65-
│ └── logger.py # Logging utilities
64+
│ └── env.py # Environment variable handling
6665
```
6766

6867
## Adding New Features
@@ -254,8 +253,7 @@ For debugging, use:
254253

255254
1. The Python debugger (pdb)
256255
2. Print statements to the console (captured in Claude Desktop logs)
257-
3. Structured logging via the Logger class
258-
4. The MCP Inspector tool
256+
3. The MCP Inspector tool
259257

260258
## Performance Considerations
261259

kicad_mcp/context.py

Lines changed: 13 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,12 @@
33
"""
44
from contextlib import asynccontextmanager
55
from dataclasses import dataclass
6-
from typing import AsyncIterator, Optional, Dict, Any
6+
from typing import AsyncIterator, Dict, Any
77

88
from mcp.server.fastmcp import FastMCP
99

10-
from kicad_mcp.utils.logger import Logger
1110
from kicad_mcp.utils.python_path import setup_kicad_python_path
1211

13-
# Create logger for this module
14-
logger = Logger()
15-
1612
@dataclass
1713
class KiCadAppContext:
1814
"""Type-safe context for KiCad MCP server."""
@@ -36,12 +32,12 @@ async def kicad_lifespan(server: FastMCP) -> AsyncIterator[KiCadAppContext]:
3632
Yields:
3733
KiCadAppContext: A typed context object shared across all handlers
3834
"""
39-
logger.info("Starting KiCad MCP server initialization")
35+
print("Starting KiCad MCP server initialization")
4036

4137
# Initialize resources on startup
42-
logger.info("Setting up KiCad Python modules")
38+
print("Setting up KiCad Python modules")
4339
kicad_modules_available = setup_kicad_python_path()
44-
logger.info(f"KiCad Python modules available: {kicad_modules_available}")
40+
print(f"KiCad Python modules available: {kicad_modules_available}")
4541

4642
# Create in-memory cache for expensive operations
4743
cache: Dict[str, Any] = {}
@@ -53,37 +49,37 @@ async def kicad_lifespan(server: FastMCP) -> AsyncIterator[KiCadAppContext]:
5349
# Import any KiCad modules that should be preloaded
5450
if kicad_modules_available:
5551
try:
56-
logger.info("Preloading KiCad Python modules")
52+
print("Preloading KiCad Python modules")
5753

5854
# Core PCB module used in multiple tools
5955
import pcbnew
60-
logger.info(f"Successfully preloaded pcbnew module: {getattr(pcbnew, 'GetBuildVersion', lambda: 'unknown')()}")
56+
print(f"Successfully preloaded pcbnew module: {getattr(pcbnew, 'GetBuildVersion', lambda: 'unknown')()}")
6157
cache["pcbnew_version"] = getattr(pcbnew, "GetBuildVersion", lambda: "unknown")()
6258
except ImportError as e:
63-
logger.warning(f"Failed to preload some KiCad modules: {str(e)}")
59+
print(f"Failed to preload some KiCad modules: {str(e)}")
6460

6561
# Yield the context to the server - server runs during this time
66-
logger.info("KiCad MCP server initialization complete")
62+
print("KiCad MCP server initialization complete")
6763
yield KiCadAppContext(
6864
kicad_modules_available=kicad_modules_available,
6965
cache=cache
7066
)
7167
finally:
7268
# Clean up resources when server shuts down
73-
logger.info("Shutting down KiCad MCP server")
69+
print("Shutting down KiCad MCP server")
7470

7571
# Clear the cache
7672
if cache:
77-
logger.debug(f"Clearing cache with {len(cache)} entries")
73+
print(f"Clearing cache with {len(cache)} entries")
7874
cache.clear()
7975

8076
# Clean up any temporary directories
8177
import shutil
8278
for temp_dir in created_temp_dirs:
8379
try:
84-
logger.debug(f"Removing temporary directory: {temp_dir}")
80+
print(f"Removing temporary directory: {temp_dir}")
8581
shutil.rmtree(temp_dir, ignore_errors=True)
8682
except Exception as e:
87-
logger.error(f"Error cleaning up temporary directory {temp_dir}: {str(e)}")
83+
print(f"Error cleaning up temporary directory {temp_dir}: {str(e)}")
8884

89-
logger.info("KiCad MCP server shutdown complete")
85+
print("KiCad MCP server shutdown complete")

kicad_mcp/resources/drc_resources.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,13 @@
22
Design Rule Check (DRC) resources for KiCad PCB files.
33
"""
44
import os
5-
import json
6-
import tempfile
7-
from typing import Dict, Any, List
5+
86
from mcp.server.fastmcp import FastMCP
97

108
from kicad_mcp.utils.file_utils import get_project_files
11-
from kicad_mcp.utils.logger import Logger
129
from kicad_mcp.utils.drc_history import get_drc_history
1310
from kicad_mcp.tools.drc_impl.cli_drc import run_drc_via_cli
1411

15-
# Create logger for this module
16-
logger = Logger()
17-
1812
def register_drc_resources(mcp: FastMCP) -> None:
1913
"""Register DRC resources with the MCP server.
2014
@@ -32,7 +26,7 @@ def get_drc_history_report(project_path: str) -> str:
3226
Returns:
3327
Markdown-formatted DRC history report
3428
"""
35-
logger.info(f"Generating DRC history report for project: {project_path}")
29+
print(f"Generating DRC history report for project: {project_path}")
3630

3731
if not os.path.exists(project_path):
3832
return f"Project not found: {project_path}"
@@ -151,7 +145,7 @@ def get_drc_report(project_path: str) -> str:
151145
Returns:
152146
Markdown-formatted DRC report
153147
"""
154-
logger.info(f"Generating DRC report for project: {project_path}")
148+
print(f"Generating DRC report for project: {project_path}")
155149

156150
if not os.path.exists(project_path):
157151
return f"Project not found: {project_path}"
@@ -162,7 +156,7 @@ def get_drc_report(project_path: str) -> str:
162156
return "PCB file not found in project"
163157

164158
pcb_file = files["pcb"]
165-
logger.info(f"Found PCB file: {pcb_file}")
159+
print(f"Found PCB file: {pcb_file}")
166160

167161
# Try to run DRC via command line
168162
drc_results = run_drc_via_cli(pcb_file)

kicad_mcp/server.py

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,33 +28,29 @@
2828
from kicad_mcp.prompts.pattern_prompts import register_pattern_prompts
2929

3030
# Import utils
31-
from kicad_mcp.utils.logger import Logger
3231
from kicad_mcp.utils.python_path import setup_kicad_python_path
3332

3433
# Import context management
3534
from kicad_mcp.context import kicad_lifespan
3635

37-
# Create logger for this module
38-
logger = Logger()
39-
4036
def create_server() -> FastMCP:
4137
"""Create and configure the KiCad MCP server."""
42-
logger.info("Initializing KiCad MCP server")
38+
print("Initializing KiCad MCP server")
4339

4440
# Try to set up KiCad Python path
4541
kicad_modules_available = setup_kicad_python_path()
4642

4743
if kicad_modules_available:
48-
logger.info("KiCad Python modules successfully configured")
44+
print("KiCad Python modules successfully configured")
4945
else:
50-
logger.warning("KiCad Python modules not available - some features will be disabled")
46+
print("KiCad Python modules not available - some features will be disabled")
5147

5248
# Initialize FastMCP server
5349
mcp = FastMCP("KiCad", lifespan=kicad_lifespan)
54-
logger.info("Created FastMCP server instance with lifespan management")
50+
print("Created FastMCP server instance with lifespan management")
5551

5652
# Register resources
57-
logger.debug("Registering resources...")
53+
print("Registering resources...")
5854
register_project_resources(mcp)
5955
register_file_resources(mcp)
6056
register_drc_resources(mcp)
@@ -63,7 +59,7 @@ def create_server() -> FastMCP:
6359
register_pattern_resources(mcp)
6460

6561
# Register tools
66-
logger.debug("Registering tools...")
62+
print("Registering tools...")
6763
register_project_tools(mcp)
6864
register_analysis_tools(mcp)
6965
register_export_tools(mcp)
@@ -73,11 +69,11 @@ def create_server() -> FastMCP:
7369
register_pattern_tools(mcp)
7470

7571
# Register prompts
76-
logger.debug("Registering prompts...")
72+
print("Registering prompts...")
7773
register_prompts(mcp)
7874
register_drc_prompts(mcp)
7975
register_bom_prompts(mcp)
8076
register_pattern_prompts(mcp)
8177

82-
logger.info("Server initialization complete")
78+
print("Server initialization complete")
8379
return mcp

0 commit comments

Comments
 (0)