Skip to content

Commit 8d83b00

Browse files
MegaRedHandManuelBilbao
authored andcommitted
fix(l1): continue on PeerTable call timeout (#5642)
**Motivation** We're having an error where snap-sync exits due to an internal timeout in a call to `PeerTable`. We're still looking into why this timeout happens, but when this happens, we should simply retry. **Description** This PR copies the `inspect_err().unwrap_or(None)` pattern from `request_account_range` to `request_storage_ranges` and `request_bytecodes`. Closes #5637
1 parent 6e3e189 commit 8d83b00

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

crates/networking/p2p/peer_handler.rs

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ impl PeerHandler {
744744
.peer_table
745745
.get_best_peer(&SUPPORTED_ETH_CAPABILITIES)
746746
.await
747-
.inspect_err(|err| error!(err= ?err, "Error requesting a peer for account range"))
747+
.inspect_err(|err| warn!(%err, "Error requesting a peer for account range"))
748748
.unwrap_or(None)
749749
else {
750750
// Log ~ once every 10 seconds
@@ -1030,7 +1030,9 @@ impl PeerHandler {
10301030
let Some((peer_id, mut connection)) = self
10311031
.peer_table
10321032
.get_best_peer(&SUPPORTED_ETH_CAPABILITIES)
1033-
.await?
1033+
.await
1034+
.inspect_err(|err| warn!(%err, "Error requesting a peer for bytecodes"))
1035+
.unwrap_or(None)
10341036
else {
10351037
// Log ~ once every 10 seconds
10361038
if logged_no_free_peers_count == 0 {
@@ -1554,7 +1556,9 @@ impl PeerHandler {
15541556
let Some((peer_id, connection)) = self
15551557
.peer_table
15561558
.get_best_peer(&SUPPORTED_ETH_CAPABILITIES)
1557-
.await?
1559+
.await
1560+
.inspect_err(|err| warn!(%err, "Error requesting a peer for storage ranges"))
1561+
.unwrap_or(None)
15581562
else {
15591563
// Log ~ once every 10 seconds
15601564
if logged_no_free_peers_count == 0 {

0 commit comments

Comments
 (0)