chore(l2): bump ZisK to 0.15.0 & add modexp syscall (#5694)

0.15.0 introduces a new modexp syscall and fixes for the existing
patches, apart from other optimizations (see
https://github.com/0xPolygonHermez/zisk/releases/tag/v0.15.0)

we found a regression some time ago in main, probably related to a ZisK
patch, in which some blocks failed to execute with a gas mismatch error.
We tested those blocks again and the regression was gone. So the new
patches' versions contain fixes too.

Author: xqft

Cargo.lock

@@ -105,9 +105,7 @@ pub fn prove(
         .into());
     }
 
-    let proof_bytes = std::fs::read(format!(
-        "{OUTPUT_DIR_PATH}/vadcop_final_proof.compressed.bin"
-    ))?;
+    let proof_bytes = std::fs::read(format!("{OUTPUT_DIR_PATH}/vadcop_final_proof.bin"))?;
     let output = ProveOutput(proof_bytes);
     Ok(output)
 }

crates/l2/prover/src/backend/zisk.rs

@@ -6,7 +6,7 @@ edition = "2024"
 [workspace]
 
 [dependencies]
-ziskos = { git = "https://github.com/0xPolygonHermez/zisk.git", tag = "v0.14.0" }
+ziskos = { git = "https://github.com/0xPolygonHermez/zisk.git", tag = "v0.15.0" }
 sha2 = "0.10.9"
 rkyv = { version = "0.8.10", features = ["std", "unaligned"] }
 
@@ -22,13 +22,13 @@ ethrex-blockchain = { path = "../../../../../../blockchain", default-features =
 ] }
 
 [patch.crates-io]
-sha2 = { git = "https://github.com/0xPolygonHermez/zisk-patch-hashes.git", tag = "patch-sha2-0.10.9-zisk-0.14.0" }
-sha3 = { git = "https://github.com/0xPolygonHermez/zisk-patch-hashes.git", tag = "patch-sha3-0.10.8-zisk-0.14.0" }
-k256 = { git = "https://github.com/0xPolygonHermez/zisk-patch-elliptic-curves.git", tag = "patch-k256-0.13.4-zisk-0.14.0" }
-substrate-bn = { git = "https://github.com/0xPolygonHermez/zisk-patch-bn.git", tag = "patch-0.6.0-zisk-0.14.0" }
-sp1_bls12_381 = { git = "https://github.com/0xPolygonHermez/zisk-patch-bls12-381", tag = "patch-0.8.0-zisk-0.14.0" }
-tiny-keccak = { git = "https://github.com/0xPolygonHermez/zisk-patch-tiny-keccak/", branch = "zisk" }
-kzg-rs = { git = "https://github.com/0xPolygonHermez/zisk-patch-kzg/", tag = "patch-0.2.7-zisk-0.14.0" }
+sha2 = { git = "https://github.com/0xPolygonHermez/zisk-patch-hashes.git", tag = "patch-sha2-0.10.9-zisk-0.15.0" }
+sha3 = { git = "https://github.com/0xPolygonHermez/zisk-patch-hashes.git", tag = "patch-sha3-0.10.8-zisk-0.15.0" }
+k256 = { git = "https://github.com/0xPolygonHermez/zisk-patch-elliptic-curves.git", tag = "patch-k256-0.13.4-zisk-0.15.0" }
+substrate-bn = { git = "https://github.com/0xPolygonHermez/zisk-patch-bn.git", tag = "patch-0.6.0-zisk-0.15.0" }
+sp1_bls12_381 = { git = "https://github.com/0xPolygonHermez/zisk-patch-bls12-381", tag = "patch-0.8.0-zisk-0.15.0" }
+tiny-keccak = { git = "https://github.com/0xPolygonHermez/zisk-patch-tiny-keccak/", tag = "patch-2.0.2-zisk-0.15.0" }
+kzg-rs = { git = "https://github.com/0xPolygonHermez/zisk-patch-kzg/", tag = "patch-0.2.7-zisk-0.15.0" }
 
 [features]
 l2 = ["guest_program/l2"]

crates/l2/prover/src/guest_program/src/zisk/Cargo.lock

@@ -43,7 +43,7 @@ strum = { version = "0.27.1", features = ["derive"] }
 k256.workspace = true
 substrate-bn = { version = "0.6.0", optional = true }
 secp256k1 = { workspace = true, optional = true }
-ziskos = { git = "https://github.com/0xPolygonHermez/zisk.git", tag = "v0.14.0", optional = true }
+ziskos = { git = "https://github.com/0xPolygonHermez/zisk.git", tag = "v0.15.0", optional = true }
 
 bitvec = { version = "1.0.1", features = ["alloc"] }
 

crates/l2/prover/src/guest_program/src/zisk/Cargo.toml

@@ -189,10 +189,10 @@ impl<'a> VM<'a> {
 
         #[cfg(feature = "zisk")]
         let product_mod = {
-            use ziskos::zisklib::mulmod256_ptr;
+            use ziskos::zisklib::mulmod256_c;
             let mut product_mod = U256::zero();
             unsafe {
-                mulmod256_ptr(
+                mulmod256_c(
                     multiplicand.0.as_ptr(),
                     multiplier.0.as_ptr(),
                     modulus.0.as_ptr(),

crates/l2/tee/quote-gen/Cargo.lock

@@ -687,8 +687,22 @@ fn mod_exp(base: Natural, exponent: Natural, modulus: Natural) -> Natural {
     } else if exponent == Natural::ZERO {
         Natural::from(1_u8) % modulus
     } else {
-        let base_mod = base % &modulus; // malachite requires base to be reduced to modulus first
-        base_mod.mod_pow(&exponent, &modulus)
+        #[cfg(not(feature = "zisk"))]
+        {
+            let base_mod = base % &modulus; // malachite requires base to be reduced to modulus first
+            base_mod.mod_pow(&exponent, &modulus)
+        }
+
+        #[cfg(feature = "zisk")]
+        {
+            use ziskos::zisklib::modexp_u64;
+            let (mut base, mut exponent, mut modulus) = (base, exponent, modulus);
+            let base_limbs = base.to_limbs_asc();
+            let exponent_limbs = exponent.to_limbs_asc();
+            let modulus_limbs = modulus.to_limbs_asc();
+            let result_limbs = modexp_u64(&base_limbs, &exponent_limbs, &modulus_limbs);
+            Natural::from_owned_limbs_asc(result_limbs)
+        }
     }
 }