-
Notifications
You must be signed in to change notification settings - Fork 117
Open
Description
High Priority Improvements:
- Add structured logs. In tracing this means having the structure of log_name = variable as an argument to the tracing macros. (Let's change it as we find it, and where appropiate).
- Change snapsync logs to be a genserver/generic metrics mechanism that can be exported to grafana rather than a mutex/lock based mechanism. (Delayed until snapsync rewrite)
- Fix snapsync logs so that it shows a percentage of the storage insertion. (chore(l1): improved snapync logs #4983)
- Remove the WARN of
WARN ethrex_p2p::rlpx::utils: unknown/[0x6e1c…8cb0(xx.xx.xx.xx:48226)]: Reached target peer connections, discarding., this is a debug / log (chore(l1): change the log of target peer to debug from warn #4984) - Remove ASCII color markers of the logs and replace them with colorize (which also wont show up due to a tracing subscriber isse) (chore(l1): improved snapync logs #4983)
- Add logs on FCU, indicating if the FCU wants us to produce a block chore(l1): improved logs for engine calls #4987
- Add logs on getPayload chore(l1): improved logs for engine calls #4987
- Remove get pending logs in store (chore(l1): remove pending logs #5076)
- Review "Executing payload" that only gets appended to the pending logs
- Review P2P logs
- Ethrex storage existing column families shouldn't be info (chore(l1): review peer handler and misc logs #5150)
- Global allocator shouldn't be info (chore(l1): review peer handler and misc logs #5150)
- Add a --color flag so that even in a non terminal context tracing still lets colors through. (feat(l1,l2): add CLI option to force color output mode #5034)
- Fix Snapsync logs to include properly the headers (fix(l1): headers snapsync logs #5082)
- Review "Failed to send transactions hashes" log (chore(l1): review peer handler and misc logs #5150)
- Review "Received invalid account range" log (chore(l1): review peer handler and misc logs #5150)
- Review
gas_tip_estimator.rslogs (chore(l1): review peer handler and misc logs #5150) - Review healing logs (chore(l1): improve healing logs #5138)
- Downgrade "Didn't receive block bodies from peer" to debug (chore(l1): review peer handler and misc logs #5150)
- Fix the step of request accounts if pivot is stale there
- Fix the step of validate state and storage
- Fix the issue of snap sync logging once when going to fullsync
Low Priority Improvements:
- Make the snap sync logs prettier and have data show up in easily readable columns (chore(l1): improve snapsync log #5077)
- Use thousand markers for numbers