Skip to content

perf(levm): improve compatibility of blake2b's NEON implementation #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf(levm): improve compatibility of blake2b's NEON implementation #5158

wants to merge 2 commits into from

Conversation

@azteca1998
Copy link
Contributor

@azteca1998 azteca1998 commented Nov 3, 2025

Motivation

The current implementation requires CPUs to implement SHA3 feat.

Description

Make it so that NEON can still be used when there's no XAR instruction available.

@github-actions github-actions bot added levm Lambda EVM implementation performance labels Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Lines of code report

Total lines added: 32
Total lines removed: 0
Total lines changed: 32

Detailed view 
+------------------------------------------------+-------+------+
| File                                           | Lines | Diff |
+------------------------------------------------+-------+------+
| ethrex/crates/common/crypto/blake2f/aarch64.rs | 255   | +30  |
+------------------------------------------------+-------+------+
| ethrex/crates/common/crypto/blake2f/mod.rs     | 55    | +2   |
+------------------------------------------------+-------+------+

@azteca1998 azteca1998 marked this pull request as ready for review November 3, 2025 09:54
@azteca1998 azteca1998 requested a review from a team as a code owner November 3, 2025 09:54
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark Block Execution Results Comparison Against Main

Command Mean [s] Min [s] Max [s] Relative
base 135.802 ± 0.257 135.384 136.172 1.00 ± 0.00
head 135.703 ± 0.220 135.255 136.117 1.00

MegaRedHand
MegaRedHand reviewed Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the performance improvements this gives us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MegaRedHand MegaRedHand MegaRedHand left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@azteca1998 azteca1998

Labels

levm Lambda EVM implementation performance

Projects

ethrex_l1
Status: No status
ethrex_performance
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azteca1998 @MegaRedHand