Skip to content

chore(l2): replace RLP decoding of tries with rkyv in stateless execution #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

chore(l2): replace RLP decoding of tries with rkyv in stateless execution #5163

wants to merge 25 commits into from
+324 −160

Conversation

@xqft
Copy link
Contributor

@xqft xqft commented Nov 3, 2025

Motivation

Description

Closes #issue_number

@xqft xqft changed the title chore(l2): replace RLP decoding of tries in stateless execution for rkyv chore(l2): replace RLP decoding of tries with rkyv in stateless execution Nov 3, 2025
@github-actions github-actions bot added the L2 Rollup client label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025 •
edited
Loading

Lines of code report

Total lines added: 153
Total lines removed: 16
Total lines changed: 169

Detailed view 
+------------------------------------------------------------+-------+------+
| File                                                       | Lines | Diff |
+------------------------------------------------------------+-------+------+
| ethrex/crates/blockchain/blockchain.rs                     | 957   | +2   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/rkyv_utils.rs                         | 301   | +59  |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/db.rs                            | 75    | -14  |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/nibbles.rs                       | 314   | +2   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/node.rs                          | 267   | +34  |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/branch.rs                   | 555   | +1   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/extension.rs                | 500   | +1   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/leaf.rs                     | 285   | +1   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/node_hash.rs                     | 108   | +4   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/trie/rkyv_utils.rs                    | 34    | +34  |
+------------------------------------------------------------+-------+------+
| ethrex/crates/common/types/block_execution_witness.rs      | 420   | -2   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/l2/prover/src/guest_program/src/execution.rs | 413   | +2   |
+------------------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/debug/execution_witness.rs    | 156   | +13  |
+------------------------------------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark for 55e00cb

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 40.4±2.75ms 40.0±2.14ms -0.99%
Trie/cita-trie insert 1k 3.5±0.13ms 3.5±0.02ms 0.00%
Trie/ethrex-trie insert 10k 34.2±1.06ms 34.3±1.49ms +0.29%
Trie/ethrex-trie insert 1k 2.8±0.05ms 2.8±0.02ms 0.00%

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark for c5dde8e

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 41.7±1.70ms 38.1±1.61ms -8.63%
Trie/cita-trie insert 1k 3.5±0.02ms 3.5±0.20ms 0.00%
Trie/ethrex-trie insert 10k 34.2±0.77ms 32.2±1.89ms -5.85%
Trie/ethrex-trie insert 1k 2.8±0.01ms 2.8±0.06ms 0.00%

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark for f9bd293

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 35.2±0.70ms 35.7±1.22ms +1.42%
Trie/cita-trie insert 1k 3.6±0.02ms 3.5±0.02ms -2.78%
Trie/ethrex-trie insert 10k 31.0±0.57ms 31.1±0.51ms +0.32%
Trie/ethrex-trie insert 1k 2.8±0.01ms 2.8±0.14ms 0.00%

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark for 3efcb45

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 35.1±0.81ms 36.1±0.81ms +2.85%
Trie/cita-trie insert 1k 3.6±0.02ms 3.6±0.02ms 0.00%
Trie/ethrex-trie insert 10k 37.4±2.72ms 34.7±1.07ms -7.22%
Trie/ethrex-trie insert 1k 2.8±0.04ms 2.9±0.08ms +3.57%

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

Benchmark for 6f39818

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 34.7±0.39ms 34.9±0.89ms +0.58%
Trie/cita-trie insert 1k 3.5±0.01ms 3.5±0.17ms 0.00%
Trie/ethrex-trie insert 10k 31.2±0.63ms 31.4±0.41ms +0.64%
Trie/ethrex-trie insert 1k 2.8±0.08ms 2.8±0.02ms 0.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 2 approving reviews are required to merge this pull request.

Assignees

@xqft xqft

Labels

L2 Rollup client

Projects

ethrex_l2
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xqft