fix: skipped spec tests in electra (#1427)

Author: rodrigo-o

test/spec/runners/bls.ex

@@ -6,22 +6,6 @@ defmodule BlsTestRunner do
   use ExUnit.CaseTemplate
   use TestRunner
 
-  # Remove handler from here once you implement the corresponding functions
-  @disabled_handlers [
-    # "sign",
-    # "verify",
-    # "aggregate",
-    # "fast_aggregate_verify",
-    # "aggregate_verify",
-    # "eth_aggregate_pubkeys"
-    # "eth_fast_aggregate_verify"
-  ]
-
-  @impl TestRunner
-  def skip?(%SpecTestCase{} = testcase) do
-    Enum.member?(@disabled_handlers, testcase.handler)
-  end
-
   @impl TestRunner
   def run_test_case(%SpecTestCase{} = testcase) do
     case_dir = SpecTestCase.dir(testcase)

test/spec/runners/epoch_processing.ex

@@ -9,22 +9,9 @@ defmodule EpochProcessingTestRunner do
   use ExUnit.CaseTemplate
   use TestRunner
 
-  # Remove handler from here once you implement the corresponding functions
+  # TODO: We need to make sure this 2 are still needed to be here
   @disabled_handlers [
-    # "justification_and_finalization",
-    # "inactivity_updates",
-    # "rewards_and_penalties",
-    # "registry_updates",
-    # "slashings",
-    # "effective_balance_updates",
-    # "eth1_data_reset",
-    # "slashings_reset",
-    # "randao_mixes_reset",
-    # "historical_summaries_update",
     "participation_record_updates"
-
-    # "participation_flag_updates",
-    # "sync_committee_updates"
   ]
 
   @deprecated_handlers [
@@ -36,10 +23,7 @@ defmodule EpochProcessingTestRunner do
     Enum.member?(@disabled_handlers ++ @deprecated_handlers, handler)
   end
 
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "deneb"}), do: false
-  def skip?(%SpecTestCase{fork: "electra"}), do: false
-  def skip?(_), do: true
+  def skip?(_), do: false
 
   @impl TestRunner
   def run_test_case(%SpecTestCase{} = testcase) do

test/spec/runners/finality.ex

@@ -6,27 +6,6 @@ defmodule FinalityTestRunner do
   use ExUnit.CaseTemplate
   use TestRunner
 
-  @disabled_cases [
-    # "finality_no_updates_at_genesis",
-    # "finality_rule_1",
-    # "finality_rule_2",
-    # "finality_rule_3",
-    # "finality_rule_4"
-  ]
-
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "capella", case: testcase}) do
-    Enum.member?(@disabled_cases, testcase)
-  end
-
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "deneb", case: testcase}) do
-    Enum.member?(@disabled_cases, testcase)
-  end
-
-  @impl TestRunner
-  def skip?(_), do: true
-
   @impl TestRunner
   def run_test_case(testcase) do
     Helpers.ProcessBlocks.process_blocks(testcase)

test/spec/runners/fork_choice.ex

@@ -23,12 +23,6 @@ defmodule ForkChoiceTestRunner do
     :ok
   end
 
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "capella"}), do: false
-  def skip?(%SpecTestCase{fork: "deneb"}), do: false
-  def skip?(%SpecTestCase{fork: "electra"}), do: false
-  def skip?(_testcase), do: true
-
   @impl TestRunner
   def run_test_case(testcase) do
     case_dir = SpecTestCase.dir(testcase)

test/spec/runners/kzg.ex

@@ -6,21 +6,6 @@ defmodule KzgTestRunner do
   use ExUnit.CaseTemplate
   use TestRunner
 
-  # Remove handler from here once you implement the corresponding functions
-  @disabled_handlers [
-    # "blob_to_kzg_commitment"
-    # "compute_kzg_proof",
-    # "verify_kzg_proof",
-    # "compute_blob_kzg_proof",
-    # "verify_blob_kzg_proof",
-    # "verify_blob_kzg_proof_batch"
-  ]
-
-  @impl TestRunner
-  def skip?(%SpecTestCase{} = testcase) do
-    Enum.member?(@disabled_handlers, testcase.handler)
-  end
-
   @impl TestRunner
   def run_test_case(%SpecTestCase{} = testcase) do
     case_dir = SpecTestCase.dir(testcase)

test/spec/runners/light_client.ex

@@ -19,15 +19,8 @@ defmodule LightClientTestRunner do
     Enum.member?(@disabled_handlers, testcase.handler)
   end
 
-  def skip?(%SpecTestCase{fork: "deneb"} = _testcase) do
-    # TODO: all of them fail
-    true
-  end
-
-  @impl TestRunner
-  def skip?(_testcase) do
-    true
-  end
+  # TODO: We didn't implement lightclient functions yet
+  def skip?(%SpecTestCase{fork: fork}) when fork in ["deneb", "electra"], do: true
 
   @impl TestRunner
   def run_test_case(%SpecTestCase{} = testcase) do

test/spec/runners/operations.ex

@@ -53,49 +53,6 @@ defmodule OperationsTestRunner do
     # "deposit_receipt" => "deposit_receipt" Not yet implemented
   }
 
-  # Remove handler from here once you implement the corresponding functions
-  # "deposit_receipt" handler is not yet implemented
-  @disabled_handlers [
-    # "attester_slashing",
-    # "attestation",
-    # "block_header",
-    # "deposit",
-    # "proposer_slashing",
-    # "voluntary_exit",
-    # "sync_aggregate",
-    # "execution_payload",
-    # "withdrawals",
-    # "bls_to_execution_change"
-  ]
-
-  @disabled_handlers_deneb [
-    # "attester_slashing",
-    # "attestation",
-    # "block_header",
-    # "deposit",
-    # "proposer_slashing",
-    # "voluntary_exit"
-    # "sync_aggregate",
-    # "execution_payload",
-    # "withdrawals",
-    # "bls_to_execution_change"
-  ]
-
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "capella", handler: handler}) do
-    Enum.member?(@disabled_handlers, handler)
-  end
-
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "deneb", handler: handler}) do
-    Enum.member?(@disabled_handlers_deneb, handler)
-  end
-
-  @impl TestRunner
-  def skip?(_testcase) do
-    true
-  end
-
   @impl TestRunner
   def run_test_case(%SpecTestCase{handler: handler} = testcase) do
     case_dir = SpecTestCase.dir(testcase) <> "/"

test/spec/runners/random.ex

@@ -6,12 +6,6 @@ defmodule RandomTestRunner do
   use ExUnit.CaseTemplate
   use TestRunner
 
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "capella"}), do: false
-  def skip?(%SpecTestCase{fork: "deneb"}), do: false
-  def skip?(%SpecTestCase{fork: "electra"}), do: false
-  def skip?(_), do: true
-
   @impl TestRunner
   def run_test_case(testcase) do
     Helpers.ProcessBlocks.process_blocks(testcase)

test/spec/runners/rewards.ex

@@ -6,21 +6,6 @@ defmodule RewardsTestRunner do
   use TestRunner
   alias Types.BeaconState
 
-  @disabled [
-    # "basic",
-    # "leak",
-    # "random"
-  ]
-
-  @impl TestRunner
-  def skip?(%SpecTestCase{fork: "capella", handler: handler}) do
-    Enum.member?(@disabled, handler)
-  end
-
-  def skip?(%SpecTestCase{fork: "deneb"}), do: false
-  def skip?(%SpecTestCase{fork: "electra"}), do: false
-  def skip?(_), do: true
-
   @impl TestRunner
   def run_test_case(%SpecTestCase{} = testcase) do
     case_dir = SpecTestCase.dir(testcase)

test/spec/runners/sanity.ex

@@ -10,109 +10,17 @@ defmodule SanityTestRunner do
   alias LambdaEthereumConsensus.Utils.Diff
   alias Types.BeaconState
 
-  @disabled_block_cases [
-    # "activate_and_partial_withdrawal_max_effective_balance",
-    # "activate_and_partial_withdrawal_overdeposit",
-    # "attestation",
-    # "attester_slashing",
-    # "balance_driven_status_transitions",
-    # "bls_change",
-    # "deposit_and_bls_change",
-    # "deposit_in_block",
-    # "deposit_top_up",
-    # "duplicate_attestation_same_block",
-    # "invalid_is_execution_enabled_false",
-    # "empty_block_transition",
-    # "empty_block_transition_large_validator_set",
-    # "empty_block_transition_no_tx",
-    # "empty_block_transition_randomized_payload",
-    # "empty_epoch_transition",
-    # "empty_epoch_transition_large_validator_set",
-    # "empty_epoch_transition_not_finalizing",
-    # "eth1_data_votes_consensus",
-    # "eth1_data_votes_no_consensus",
-    # "exit_and_bls_change",
-    # "full_random_operations_0",
-    # "full_random_operations_1",
-    # "full_random_operations_2",
-    # "full_random_operations_3",
-    # "full_withdrawal_in_epoch_transition",
-    # "high_proposer_index",
-    # "historical_batch",
-    # "inactivity_scores_full_participation_leaking",
-    # "inactivity_scores_leaking",
-    # "invalid_all_zeroed_sig",
-    # "invalid_duplicate_attester_slashing_same_block",
-    # "invalid_duplicate_bls_changes_same_block",
-    # "invalid_duplicate_deposit_same_block",
-    # "invalid_duplicate_proposer_slashings_same_block",
-    # "invalid_duplicate_validator_exit_same_block",
-    # "invalid_incorrect_block_sig",
-    # "invalid_incorrect_proposer_index_sig_from_expected_proposer",
-    # "invalid_incorrect_proposer_index_sig_from_proposer_index",
-    # "invalid_incorrect_state_root",
-    # "invalid_only_increase_deposit_count",
-    # "invalid_parent_from_same_slot",
-    # "invalid_prev_slot_block_transition",
-    # "invalid_same_slot_block_transition",
-    # "invalid_similar_proposer_slashings_same_block",
-    # "invalid_two_bls_changes_of_different_addresses_same_validator_same_block",
-    # "invalid_withdrawal_fail_second_block_payload_isnt_compatible",
-    # "is_execution_enabled_false",
-    # "many_partial_withdrawals_in_epoch_transition",
-    # "multiple_attester_slashings_no_overlap",
-    # "multiple_attester_slashings_partial_overlap",
-    # "multiple_different_proposer_slashings_same_block",
-    # "multiple_different_validator_exits_same_block",
-    # "partial_withdrawal_in_epoch_transition",
-    # "proposer_after_inactive_index",
-    # "proposer_self_slashing",
-    # "proposer_slashing",
-    # "skipped_slots",
-    # "slash_and_exit_diff_index",
-    # "slash_and_exit_same_index"
-    # "sync_committee_committee__empty",
-    # "sync_committee_committee__full",
-    # "sync_committee_committee__half",
-    # "sync_committee_committee_genesis__empty",
-    # "sync_committee_committee_genesis__full",
-    # "sync_committee_committee_genesis__half",
-    # "top_up_and_partial_withdrawable_validator",
-    # "top_up_to_fully_withdrawn_validator",
-    # "voluntary_exit",
-    # "withdrawal_success_two_blocks"
-  ]
-
+  # TODO: We need to make sure this is still needed to be here
   @disabled_slot_cases [
-    # "empty_epoch",
-    # "slots_1",
-    # "slots_2",
-    # "over_epoch_boundary",
-    # NOTE: too long to run in CI
-    # TODO: optimize
     "historical_accumulator"
-
-    # "double_empty_epoch"
   ]
 
   @impl TestRunner
-  def skip?(%SpecTestCase{fork: "capella", handler: "blocks", case: testcase}) do
-    Enum.member?(@disabled_block_cases, testcase)
-  end
-
-  def skip?(%SpecTestCase{fork: "capella", handler: "slots", case: testcase}) do
-    Enum.member?(@disabled_slot_cases, testcase)
-  end
-
-  def skip?(%SpecTestCase{fork: "deneb", handler: "blocks", case: testcase}) do
-    Enum.member?(@disabled_block_cases, testcase)
-  end
-
-  def skip?(%SpecTestCase{fork: "deneb", handler: "slots", case: testcase}) do
+  def skip?(%SpecTestCase{handler: "slots", case: testcase}) do
     Enum.member?(@disabled_slot_cases, testcase)
   end
 
-  def skip?(_), do: true
+  def skip?(_), do: false
 
   @impl TestRunner
   def run_test_case(%SpecTestCase{handler: "slots"} = testcase) do