Prepare for the release of the CLJC deep-diff2

Move namespaces to use a "2" suffix, we have breaking changes and we don't want
to break existing consumers. We will bundle both namespaces with and without the
suffix in the released artifact.

Move the printer and diff namespaces to printer-impl and diff-impl, for two
reasons. This way we can keep the same top level API at
least (lambdaisland.deep-diff2/printer, lambdaisland.deep-diff2/diff), since in
ClojureScript names of functions and namespaces are not allowed to overlap.

The second reason is that the -impl suffix signals that these are internal and
basically have to be treated as private. This allows us to make the functions in
there to be public, which makes it possible to unit test them. Before we used
alter-meta! to make them public at the start of the test, but this only works in
Clojure.

Inline Puget, we've made extensive changes to make this work, which we don't
expect to go upstream, so we should not release these under puget.* namespaces.

Make Puget dispatch based on value rather than type for both Clojure and
ClojureScript. Clean up and further unify the print handlers for
platform-specific types.

Contains a fix to the round-trip generative test, since ##NaN (on js/cljs) can
not be compared for equality it leads to false negatives.

Author: plexus

deps.edn

@@ -1,14 +1,9 @@
 {:paths ["resources" "src" "test"]
- :deps  {org.clojure/clojure           {:mvn/version "1.10.0"}
-         ;;mvxcvi/puget                {:mvn/version "1.1.2"}
-         github-lambdaisland/puget     {:git/url "https://github.com/lambdaisland/puget"
-                                        :sha "ea860be1f0c6a5e406c45a414802c41e902d010c"}
-         fipp                          {:mvn/version "0.6.17"}
-         org.clojure/core.rrb-vector   {:mvn/version "0.0.14"}
-         ;;tech.droit/clj-diff         {:mvn/version "1.0.1"}
+ :deps  {org.clojure/clojure           {:mvn/version "1.10.1"}
+         fipp                          {:mvn/version "0.6.22"}
+         org.clojure/core.rrb-vector   {:mvn/version "0.1.1"}
          org.clojars.rymndhng/clj-diff {:mvn/version "1.1.1-SNAPSHOT"}
-         mvxcvi/arrangement            {:mvn/version "1.2.0"}
-         com.andrewmcveigh/cljs-time   {:mvn/version "0.5.2"}}
+         mvxcvi/arrangement            {:mvn/version "1.2.0"}}
 
  :aliases {:cljs
            {:extra-deps {org.clojure/clojurescript   {:mvn/version "1.10.597"}}}

src/lambdaisland/deep_diff/printer.cljc

@@ -1,8 +1,8 @@
-(ns lambdaisland.deep-diff
-  (:require [lambdaisland.deep-diff.diff :as diff]
-            [lambdaisland.deep-diff.printer :as printer]))
+(ns lambdaisland.deep-diff2
+  (:require [lambdaisland.deep-diff2.diff-impl :as diff-impl]
+            [lambdaisland.deep-diff2.printer-impl :as printer-impl]))
 
-(defn call-diff
+(defn diff
   "Compare two values recursively.
 
   The result is a data structure similar to the ones passed in, but with
@@ -19,16 +19,16 @@
   [expected actual]
   (diff/diff expected actual))
 
-(defn build-printer
+(defn printer
   "Construct a Puget printer instance suitable for printing diffs.
 
   Extra options are passed on to Puget. Extra type handlers can be provides as
   `:extra-handlers` (a map from symbol to function), or by
   using [[lambdaisland.deep-diff.printer/register-print-handler!]]"
   ([]
-   (build-printer {}))
+   (printer {}))
   ([opts]
-   (printer/puget-printer opts)))
+   (printer-impl/puget-printer opts)))
 
 (defn pretty-print
   "Pretty print a diff.
@@ -39,5 +39,5 @@
    (pretty-print diff (build-printer)))
   ([diff printer]
    (-> diff
-       (printer/format-doc printer)
-       (printer/print-doc printer))))
+       (printer-impl/format-doc printer)
+       (printer-impl/print-doc printer))))

src/lambdaisland/deep_diff.cljc src/lambdaisland/deep_diff2.cljcsrc/lambdaisland/deep_diff.cljc renamed to src/lambdaisland/deep_diff2.cljc

@@ -1,4 +1,4 @@
-(ns lambdaisland.deep-diff.diff
+(ns lambdaisland.deep-diff2.diff-impl
   (:require [clojure.data :as data]
             [clj-diff.core :as seq-diff]))
 
@@ -134,8 +134,12 @@
     (-diff-similar x y)))
 
 (defn diffable? [exp]
-  (or (implements? Diff exp)
-      (satisfies? Diff exp)))
+  (satisfies? Diff exp))
+
+;; ClojureScript has this, Clojure doesn't
+#?(:clj
+   (defn array? [x]
+     (and x (.isArray (class x)))))
 
 (defn diff [exp act]
   (cond