Feature/split-threshold (#206)

* split threshold per trading pair

* add fn ensure_can_enable_trading_pair

* split threshold add unit tests

* Refactoring code

* Refactoring code

* replace HashSet to vec

* add trait MarginProtocolLiquidityPoolsManager

* remove Hash

* remove action from _enp_and_ell_risk_threshold_of_pool and _risk_threshold_of_trader

* add margin _check_trader and _check_pool unit cases

Author: zjb0807

modules/liquidity-pools/base/src/lib.rs

@@ -12,15 +12,15 @@ use sp_runtime::{
 	DispatchResult, ModuleId,
 };
 use sp_std::{prelude::*, result};
-use traits::{LiquidityPoolManager, LiquidityPools, OnDisableLiquidityPool, OnRemoveLiquidityPool};
+use traits::{BaseLiquidityPoolManager, LiquidityPools, OnDisableLiquidityPool, OnRemoveLiquidityPool};
 
 mod mock;
 mod tests;
 
 pub trait Trait<I: Instance = DefaultInstance>: system::Trait {
 	type Event: From<Event<Self, I>> + Into<<Self as frame_system::Trait>::Event>;
 	type LiquidityCurrency: BasicCurrency<Self::AccountId, Balance = Balance>;
-	type PoolManager: LiquidityPoolManager<LiquidityPoolId, Balance>;
+	type PoolManager: BaseLiquidityPoolManager<LiquidityPoolId, Balance>;
 	type ExistentialDeposit: Get<Balance>;
 	type ModuleId: Get<ModuleId>;
 	type OnDisableLiquidityPool: OnDisableLiquidityPool;

modules/liquidity-pools/base/src/mock.rs

@@ -86,7 +86,7 @@ impl orml_tokens::Trait for Runtime {
 }
 
 pub struct PoolManager;
-impl LiquidityPoolManager<LiquidityPoolId, Balance> for PoolManager {
+impl BaseLiquidityPoolManager<LiquidityPoolId, Balance> for PoolManager {
 	fn can_remove(_pool_id: LiquidityPoolId) -> bool {
 		true
 	}

modules/liquidity-pools/margin/src/lib.rs

@@ -16,7 +16,10 @@ use primitives::{AccumulateConfig, Balance, CurrencyId, Leverage, Leverages, Liq
 use sp_arithmetic::Fixed128;
 use sp_runtime::{traits::Saturating, DispatchResult, ModuleId, RuntimeDebug};
 use sp_std::{cmp::max, prelude::*};
-use traits::{LiquidityPools, MarginProtocolLiquidityPools, OnDisableLiquidityPool, OnRemoveLiquidityPool};
+use traits::{
+	LiquidityPools, MarginProtocolLiquidityPools, MarginProtocolLiquidityPoolsManager, OnDisableLiquidityPool,
+	OnRemoveLiquidityPool,
+};
 
 #[cfg(feature = "std")]
 use serde::{Deserialize, Serialize};
@@ -40,6 +43,7 @@ pub const MODULE_ID: ModuleId = ModuleId(*b"lami/mlp");
 pub trait Trait: frame_system::Trait {
 	type Event: From<Event<Self>> + Into<<Self as system::Trait>::Event>;
 	type BaseLiquidityPools: LiquidityPools<Self::AccountId>;
+	type PoolManager: MarginProtocolLiquidityPoolsManager;
 	type MultiCurrency: MultiCurrency<Self::AccountId, Balance = Balance, CurrencyId = CurrencyId>;
 	type UpdateOrigin: EnsureOrigin<Self::Origin>;
 	type MaxSwap: Get<Fixed128>;
@@ -192,6 +196,9 @@ decl_module! {
 			let who = ensure_signed(origin)?;
 			ensure!(Self::is_owner(pool_id, &who), Error::<T>::NoPermission);
 			ensure!(Self::enabled_trading_pair(&pair).is_some(), Error::<T>::TradingPairNotEnabled);
+
+			<T::PoolManager as MarginProtocolLiquidityPoolsManager>::ensure_can_enable_trading_pair(pool_id, pair)?;
+
 			LiquidityPoolEnabledTradingPairs::insert(&pool_id, &pair, true);
 			Self::deposit_event(RawEvent::LiquidityPoolTradingPairEnabled(pair))
 		}

modules/liquidity-pools/margin/src/mock.rs

@@ -14,7 +14,7 @@ use sp_runtime::{
 use orml_currencies::Currency;
 
 use primitives::{Balance, CurrencyId, LiquidityPoolId};
-use traits::LiquidityPoolManager;
+use traits::{BaseLiquidityPoolManager, MarginProtocolLiquidityPoolsManager};
 
 pub type BlockNumber = u64;
 pub type AccountId = u32;
@@ -89,7 +89,7 @@ impl orml_tokens::Trait for Runtime {
 }
 
 pub struct PoolManager;
-impl LiquidityPoolManager<LiquidityPoolId, Balance> for PoolManager {
+impl BaseLiquidityPoolManager<LiquidityPoolId, Balance> for PoolManager {
 	fn can_remove(_pool_id: LiquidityPoolId) -> bool {
 		true
 	}
@@ -115,9 +115,17 @@ impl module_base_liquidity_pools::Trait<MarginInstance> for Runtime {
 }
 pub type BaseLiquidityPools = module_base_liquidity_pools::Module<Runtime, MarginInstance>;
 
+pub struct DummyPoolManager;
+impl MarginProtocolLiquidityPoolsManager for DummyPoolManager {
+	fn ensure_can_enable_trading_pair(_pool_id: LiquidityPoolId, _pair: TradingPair) -> DispatchResult {
+		Ok(())
+	}
+}
+
 impl Trait for Runtime {
 	type Event = ();
 	type BaseLiquidityPools = module_base_liquidity_pools::Module<Runtime, MarginInstance>;
+	type PoolManager = DummyPoolManager;
 	type MultiCurrency = orml_currencies::Module<Runtime>;
 	type UpdateOrigin = EnsureSignedBy<One, AccountId>;
 	type MaxSwap = MaxSwap;

modules/liquidity-pools/synthetic/src/mock.rs

@@ -13,7 +13,7 @@ use sp_runtime::{
 
 use orml_currencies::Currency;
 use primitives::{Balance, CurrencyId, LiquidityPoolId};
-use traits::LiquidityPoolManager;
+use traits::BaseLiquidityPoolManager;
 
 pub type BlockNumber = u64;
 pub type AccountId = u32;
@@ -88,7 +88,7 @@ impl orml_tokens::Trait for Runtime {
 
 pub struct PoolManager;
 
-impl LiquidityPoolManager<LiquidityPoolId, Balance> for PoolManager {
+impl BaseLiquidityPoolManager<LiquidityPoolId, Balance> for PoolManager {
 	fn can_remove(_pool_id: LiquidityPoolId) -> bool {
 		true
 	}