phpunit

Signed-off-by: Gary Gitton <[email protected]>

Author: garygitton

test/Bootstrap.php

@@ -28,7 +28,7 @@ class Bootstrap
 
     public static function init(): void
     {
-        if(self::$initialized) {
+        if(static::$initialized) {
             return;
         }
 
@@ -85,8 +85,7 @@ public static function getService(string $name)
         return $serviceManager->get($name);
     }
 
-
-    public static function getConfig(string $name): array
+    public static function getConfig(): array
     {
         $serviceManager = self::getServiceManager();
         /** @psalm-suppress MixedAssignment */

test/Integration/InputFilter/LaminasTest.php

@@ -4,7 +4,9 @@
 
 namespace LaminasIntegrationTest\ApiTools\Admin\InputFilter;
 
+use Exception;
 use Laminas\InputFilter\InputFilter;
+use Laminas\InputFilter\InputFilterInterface;
 use Laminas\InputFilter\InputFilterPluginManager;
 use LaminasTest\ApiTools\Admin\Bootstrap;
 use PHPUnit\Framework\TestCase;
@@ -15,30 +17,57 @@ class LaminasTest extends TestCase
 {
     /**
      * @test
+     * @throws Exception
      */
     public function inputFilterServiceKeyWillReturnInputFilter(): void
     {
-        /**
-         * @psalm-suppress MixedAssignment
-         */
-        $inputFilterManager = Bootstrap::getService(InputFilterPluginManager::class);
-        $inputFilterConfig = Bootstrap::getConfig('input_filters');
-        /**
-         * @psalm-suppress MixedArgument
-         */
-        $inputFilterKeys = array_keys($inputFilterConfig['aliases']);
+        $inputFilterConfig = $this->getInputFilterAliases();
+        $inputFilterKeys = array_keys($inputFilterConfig);
 
+        /** @var string $key */
         foreach ($inputFilterKeys as $key) {
-            if(!is_string($key)) {
-                throw new \UnexpectedValueException('$key must be a string.');
-            }
-
-            /**
-             * @psalm-suppress MixedAssignment
-             * @psalm-suppress MixedMethodCall
-             */
-            $inputFilter = $inputFilterManager->get($key);
+            $inputFilter = $this->getInputFilter($key);
             $this->assertInstanceOf(InputFilter::class, $inputFilter);
         }
     }
+
+    private function getInputFilterManager(): InputFilterPluginManager
+    {
+        $inputFilterManager = Bootstrap::getService(InputFilterPluginManager::class);
+
+        if(!$inputFilterManager instanceof InputFilterPluginManager) {
+            throw new Exception('Invalid class.');
+        }
+
+        return $inputFilterManager;
+    }
+
+    /**
+     * @throws Exception
+     */
+    private function getInputFilter(string $name): InputFilterInterface
+    {
+        $inputFilterManager = $this->getInputFilterManager();
+        $inputFilter = $inputFilterManager->get($name);
+
+        if(! $inputFilter instanceof InputFilterInterface) {
+            throw new Exception('Invalid class.');
+        }
+
+        return $inputFilter;
+    }
+
+    private function getInputFilterConfig(): array
+    {
+        $config = Bootstrap::getConfig();
+
+        return is_array($config['input_filters'])? $config['input_filters']: [];
+    }
+
+    private function getInputFilterAliases(): array
+    {
+        $config = $this->getInputFilterConfig();
+
+        return is_array($config['aliases'])? $config['aliases']: [];
+    }
 }