From 995088fd3c1ec6d7f5e4bde1721c951ba091fa64 Mon Sep 17 00:00:00 2001 From: Joseph Tasker Date: Thu, 13 Feb 2025 13:30:12 +0000 Subject: [PATCH 1/3] Modified target.json and updated README.md Updated the target.json and README to indicate the purpose and functionality of the property due to the previous confusion of a true or false value when its a if defined option. --- README.md | 4 ++++ target.json | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ec584184..bcb96359 100644 --- a/README.md +++ b/README.md @@ -13,3 +13,7 @@ Consequently, these, while generally more stable than the `feature/` or `tests/` Releases are selected tags intended to be stable and production-ready; and are the recommended ones to use for anyone implementing or using the CODAL codebase. Each GitHub Release changelog will include the changes since the previous Release (not for just that specific tag only), and the changelog will also include changes in the project dependencies (codal-core, codal-nrf52, codal-nrf-sdk) as these don't have individual changelogs. + +## Target Properties +# CONFIG_NFCT_PINS_AS_GPIOS +Controls the NFC functionality of the nRF52833, Comment/remove the line to enable the antenna and NFC capabilities. \ No newline at end of file diff --git a/target.json b/target.json index dce155d4..ceb69a82 100644 --- a/target.json +++ b/target.json @@ -9,7 +9,7 @@ "config":{ "MBED_CONF_NORDIC_NRF_LF_CLOCK_SRC": "NRF_LF_SRC_XTAL", "CONFIG_GPIO_AS_PINRESET": 1, - "CONFIG_NFCT_PINS_AS_GPIOS": 1, + "CONFIG_NFCT_PINS_AS_GPIOS": "TO ENABLE THE NFC ANTENNA PLEASE DELETE/COMMENT OUT THIS LINE", "DEVICE_SRAM_BASE":"0x20000000", "DEVICE_SRAM_END":"0x20020000", "DEVICE_STACK_BASE":"DEVICE_SRAM_END", From b67ae53ccaee7b98ebd6fe9df0fc9250ff9a0b25 Mon Sep 17 00:00:00 2001 From: Joseph Tasker Date: Thu, 13 Feb 2025 13:31:35 +0000 Subject: [PATCH 2/3] Updated README format for header Corrected the subheading to be the correct size. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index bcb96359..6b1175c1 100644 --- a/README.md +++ b/README.md @@ -15,5 +15,5 @@ Releases are selected tags intended to be stable and production-ready; and are t Each GitHub Release changelog will include the changes since the previous Release (not for just that specific tag only), and the changelog will also include changes in the project dependencies (codal-core, codal-nrf52, codal-nrf-sdk) as these don't have individual changelogs. ## Target Properties -# CONFIG_NFCT_PINS_AS_GPIOS +### CONFIG_NFCT_PINS_AS_GPIOS Controls the NFC functionality of the nRF52833, Comment/remove the line to enable the antenna and NFC capabilities. \ No newline at end of file From d0435110c796a99d24b7a36d5ab6a70167ee682f Mon Sep 17 00:00:00 2001 From: Joseph Tasker Date: Tue, 18 Feb 2025 14:46:34 +0000 Subject: [PATCH 3/3] Updated String Text Changed text to used repeatedly on other variables facing the same issue. --- target.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target.json b/target.json index ceb69a82..e28abd31 100644 --- a/target.json +++ b/target.json @@ -9,7 +9,7 @@ "config":{ "MBED_CONF_NORDIC_NRF_LF_CLOCK_SRC": "NRF_LF_SRC_XTAL", "CONFIG_GPIO_AS_PINRESET": 1, - "CONFIG_NFCT_PINS_AS_GPIOS": "TO ENABLE THE NFC ANTENNA PLEASE DELETE/COMMENT OUT THIS LINE", + "CONFIG_NFCT_PINS_AS_GPIOS": "ENABLED - Delete entire line to Disable", "DEVICE_SRAM_BASE":"0x20000000", "DEVICE_SRAM_END":"0x20020000", "DEVICE_STACK_BASE":"DEVICE_SRAM_END",