Skip to content

Commit f92b178

Browse files
committed
access: Make HandledAccess implementations explicit
With a generic HandledAccess implementation for all PrivateHandledAccess implementations, the documentations does not show the actual types. Make these implementations explicit to improve the documentation. Signed-off-by: Mickaël Salaün <mic@digikod.net>
1 parent 5ad4038 commit f92b178

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

src/access.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ pub trait Access: BitFlag + private::Sealed {
1515
// This HandledAccess trait is useful to document the API.
1616
pub trait HandledAccess: Access {}
1717

18-
impl<A> HandledAccess for A where A: PrivateHandledAccess {}
19-
2018
pub trait PrivateHandledAccess: HandledAccess {
2119
fn ruleset_handle_access(
2220
ruleset: &mut Ruleset,

src/fs.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
use crate::compat::private::OptionCompatLevelMut;
22
use crate::{
33
uapi, Access, AddRuleError, AddRulesError, CompatError, CompatLevel, CompatResult, CompatState,
4-
Compatible, HandleAccessError, HandleAccessesError, PathBeneathError, PathFdError,
5-
PrivateHandledAccess, PrivateRule, Rule, Ruleset, RulesetCreated, RulesetError,
4+
Compatible, HandleAccessError, HandleAccessesError, HandledAccess, PathBeneathError,
5+
PathFdError, PrivateHandledAccess, PrivateRule, Rule, Ruleset, RulesetCreated, RulesetError,
66
TailoredCompatLevel, TryCompat, ABI,
77
};
88
use enumflags2::{bitflags, make_bitflags, BitFlags};
@@ -159,6 +159,8 @@ fn consistent_access_fs_rw() {
159159
}
160160
}
161161

162+
impl HandledAccess for AccessFs {}
163+
162164
impl PrivateHandledAccess for AccessFs {
163165
fn ruleset_handle_access(
164166
ruleset: &mut Ruleset,

src/net.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
use crate::compat::private::OptionCompatLevelMut;
22
use crate::{
33
uapi, Access, AddRuleError, AddRulesError, CompatError, CompatLevel, CompatResult, CompatState,
4-
Compatible, HandleAccessError, HandleAccessesError, PrivateHandledAccess, PrivateRule, Rule,
5-
Ruleset, RulesetCreated, TailoredCompatLevel, TryCompat, ABI,
4+
Compatible, HandleAccessError, HandleAccessesError, HandledAccess, PrivateHandledAccess,
5+
PrivateRule, Rule, Ruleset, RulesetCreated, TailoredCompatLevel, TryCompat, ABI,
66
};
77
use enumflags2::{bitflags, BitFlags};
88
use std::mem::zeroed;
@@ -60,6 +60,8 @@ impl Access for AccessNet {
6060
}
6161
}
6262

63+
impl HandledAccess for AccessNet {}
64+
6365
impl PrivateHandledAccess for AccessNet {
6466
fn ruleset_handle_access(
6567
ruleset: &mut Ruleset,

0 commit comments

Comments
 (0)