Merge pull request #11 from langchain-ai/palash/subagent-fix

fix: update subagents

Author: Palashio

examples/.gitignore

@@ -0,0 +1,3 @@
+
+# LangGraph API
+.langgraph_api

examples/research-agent.ts

@@ -0,0 +1,3 @@
+
+# LangGraph API
+.langgraph_api

examples/research/.gitignore

@@ -0,0 +1,7 @@
+{
+  "dependencies": ["../"],
+  "graphs": {
+    "research": "./research-agent.ts:agent"
+  },
+  "env": ".env"
+}

examples/research/langgraph.json

@@ -0,0 +1,216 @@
+/* eslint-disable no-console */
+import { createDeepAgent, type SubAgent } from "../../src/index.js";
+import { tool } from "@langchain/core/tools";
+import { z } from "zod";
+import "dotenv/config";
+import { TavilySearch } from "@langchain/tavily";
+
+type Topic = "general" | "news" | "finance";
+
+// Search tool to use to do research
+const internetSearch = tool(
+  async ({
+    query,
+    maxResults = 5,
+    topic = "general" as Topic,
+    includeRawContent = false,
+  }: {
+    query: string;
+    maxResults?: number;
+    topic?: Topic;
+    includeRawContent?: boolean;
+  }) => {
+    /**
+     * Run a web search
+     */
+
+    // Note: You'll need to install and import tavily-js or similar package
+    // For now, this is a placeholder that shows the structure
+    const tavilySearch = new TavilySearch({
+      maxResults,
+      tavilyApiKey: process.env.TAVILY_API_KEY,
+      includeRawContent,
+      topic,
+    });
+    const tavilyResponse = await tavilySearch.invoke({ query });
+
+    return tavilyResponse;
+  },
+  {
+    name: "internet_search",
+    description: "Run a web search",
+    schema: z.object({
+      query: z.string().describe("The search query"),
+      maxResults: z
+        .number()
+        .optional()
+        .default(5)
+        .describe("Maximum number of results to return"),
+      topic: z
+        .enum(["general", "news", "finance"])
+        .optional()
+        .default("general")
+        .describe("Search topic category"),
+      includeRawContent: z
+        .boolean()
+        .optional()
+        .default(false)
+        .describe("Whether to include raw content"),
+    }),
+  },
+);
+
+const subResearchPrompt = `You are a dedicated researcher. Your job is to conduct research based on the users questions.
+
+Conduct thorough research and then reply to the user with a detailed answer to their question
+
+only your FINAL answer will be passed on to the user. They will have NO knowledge of anything except your final message, so your final report should be your final message!`;
+
+const researchSubAgent: SubAgent = {
+  name: "research-agent",
+  description:
+    "Used to research more in depth questions. Only give this researcher one topic at a time. Do not pass multiple sub questions to this researcher. Instead, you should break down a large topic into the necessary components, and then call multiple research agents in parallel, one for each sub question.",
+  prompt: subResearchPrompt,
+  tools: ["internet_search"],
+};
+
+const subCritiquePrompt = `You are a dedicated editor. You are being tasked to critique a report.
+
+You can find the report at \`final_report.md\`.
+
+You can find the question/topic for this report at \`question.txt\`.
+
+The user may ask for specific areas to critique the report in. Respond to the user with a detailed critique of the report. Things that could be improved.
+
+You can use the search tool to search for information, if that will help you critique the report
+
+Do not write to the \`final_report.md\` yourself.
+
+Things to check:
+- Check that each section is appropriately named
+- Check that the report is written as you would find in an essay or a textbook - it should be text heavy, do not let it just be a list of bullet points!
+- Check that the report is comprehensive. If any paragraphs or sections are short, or missing important details, point it out.
+- Check that the article covers key areas of the industry, ensures overall understanding, and does not omit important parts.
+- Check that the article deeply analyzes causes, impacts, and trends, providing valuable insights
+- Check that the article closely follows the research topic and directly answers questions
+- Check that the article has a clear structure, fluent language, and is easy to understand.
+`;
+
+const critiqueSubAgent: SubAgent = {
+  name: "critique-agent",
+  description:
+    "Used to critique the final report. Give this agent some infomration about how you want it to critique the report.",
+  prompt: subCritiquePrompt,
+};
+
+// Prompt prefix to steer the agent to be an expert researcher
+const researchInstructions = `You are an expert researcher. Your job is to conduct thorough research, and then write a polished report.
+
+The first thing you should do is to write the original user question to \`question.txt\` so you have a record of it.
+
+Use the research-agent to conduct deep research. It will respond to your questions/topics with a detailed answer.
+
+When you think you enough information to write a final report, write it to \`final_report.md\`
+
+You can call the critique-agent to get a critique of the final report. After that (if needed) you can do more research and edit the \`final_report.md\`
+You can do this however many times you want until are you satisfied with the result.
+
+Only edit the file once at a time (if you call this tool in parallel, there may be conflicts).
+
+Here are instructions for writing the final report:
+
+<report_instructions>
+
+CRITICAL: Make sure the answer is written in the same language as the human messages! If you make a todo plan - you should note in the plan what language the report should be in so you dont forget!
+Note: the language the report should be in is the language the QUESTION is in, not the language/country that the question is ABOUT.
+
+Please create a detailed answer to the overall research brief that:
+1. Is well-organized with proper headings (# for title, ## for sections, ### for subsections)
+2. Includes specific facts and insights from the research
+3. References relevant sources using [Title](URL) format
+4. Provides a balanced, thorough analysis. Be as comprehensive as possible, and include all information that is relevant to the overall research question. People are using you for deep research and will expect detailed, comprehensive answers.
+5. Includes a "Sources" section at the end with all referenced links
+
+You can structure your report in a number of different ways. Here are some examples:
+
+To answer a question that asks you to compare two things, you might structure your report like this:
+1/ intro
+2/ overview of topic A
+3/ overview of topic B
+4/ comparison between A and B
+5/ conclusion
+
+To answer a question that asks you to return a list of things, you might only need a single section which is the entire list.
+1/ list of things or table of things
+Or, you could choose to make each item in the list a separate section in the report. When asked for lists, you don't need an introduction or conclusion.
+1/ item 1
+2/ item 2
+3/ item 3
+
+To answer a question that asks you to summarize a topic, give a report, or give an overview, you might structure your report like this:
+1/ overview of topic
+2/ concept 1
+3/ concept 2
+4/ concept 3
+5/ conclusion
+
+If you think you can answer the question with a single section, you can do that too!
+1/ answer
+
+REMEMBER: Section is a VERY fluid and loose concept. You can structure your report however you think is best, including in ways that are not listed above!
+Make sure that your sections are cohesive, and make sense for the reader.
+
+For each section of the report, do the following:
+- Use simple, clear language
+- Use ## for section title (Markdown format) for each section of the report
+- Do NOT ever refer to yourself as the writer of the report. This should be a professional report without any self-referential language. 
+- Do not say what you are doing in the report. Just write the report without any commentary from yourself.
+- Each section should be as long as necessary to deeply answer the question with the information you have gathered. It is expected that sections will be fairly long and verbose. You are writing a deep research report, and users will expect a thorough answer.
+- Use bullet points to list out information when appropriate, but by default, write in paragraph form.
+
+REMEMBER:
+The brief and research may be in English, but you need to translate this information to the right language when writing the final answer.
+Make sure the final answer report is in the SAME language as the human messages in the message history.
+
+Format the report in clear markdown with proper structure and include source references where appropriate.
+
+<Citation Rules>
+- Assign each unique URL a single citation number in your text
+- End with ### Sources that lists each source with corresponding numbers
+- IMPORTANT: Number sources sequentially without gaps (1,2,3,4...) in the final list regardless of which sources you choose
+- Each source should be a separate line item in a list, so that in markdown it is rendered as a list.
+- Example format:
+  [1] Source Title: URL
+  [2] Source Title: URL
+- Citations are extremely important. Make sure to include these, and pay a lot of attention to getting these right. Users will often use these citations to look into more information.
+</Citation Rules>
+</report_instructions>
+
+You have access to a few tools.
+
+## \`internet_search\`
+
+Use this to run an internet search for a given query. You can specify the number of results, the topic, and whether raw content should be included.
+`;
+
+// Create the agent
+const agent = createDeepAgent({
+  tools: [internetSearch],
+  instructions: researchInstructions,
+  subagents: [critiqueSubAgent, researchSubAgent],
+}).withConfig({ recursionLimit: 1000 });
+
+// Invoke the agent
+async function main() {
+  const result = await agent.invoke({
+    messages: [{ role: "user", content: "what is langgraph?" }],
+  });
+  console.log(result);
+}
+
+export { agent, internetSearch };
+
+// Run if this file is executed directly
+if (import.meta.url === `file://${process.argv[1]}`) {
+  main();
+}

examples/research/research-agent.ts

@@ -17,6 +17,22 @@ import type { StructuredTool } from "@langchain/core/tools";
 import { z } from "zod";
 import { DeepAgentState } from "./state.js";
 
+/**
+ * Base prompt that provides instructions about available tools
+ * Ported from Python implementation to ensure consistent behavior
+ */
+const BASE_PROMPT = `You have access to a number of standard tools
+
+## \`write_todos\`
+
+You have access to the \`write_todos\` tools to help you manage and plan tasks. Use these tools VERY frequently to ensure that you are tracking your tasks and giving the user visibility into your progress.
+These tools are also EXTREMELY helpful for planning tasks, and for breaking down larger complex tasks into smaller steps. If you do not use this tool when planning, you may forget to do important tasks - and that is unacceptable.
+
+It is critical that you mark todos as completed as soon as you are done with a task. Do not batch up multiple tasks before marking them as completed.
+## \`task\`
+
+- When doing web search, prefer to use the \`task\` tool in order to reduce context usage.`;
+
 /**
  * Built-in tools that are always available in Deep Agents
  */
@@ -69,11 +85,16 @@ export function createDeepAgent<
     allTools.push(taskTool);
   }
 
+  // Combine instructions with base prompt like Python implementation
+  const finalInstructions = instructions
+    ? instructions + BASE_PROMPT
+    : BASE_PROMPT;
+
   // Return createReactAgent with proper configuration
   return createReactAgent({
     llm: model,
     tools: allTools,
     stateSchema,
-    messageModifier: instructions,
+    messageModifier: finalInstructions,
   });
 }