Skip to content

Commit 740e246

Browse files
fixing the standard integration tests in PR-491
credit for the original fix goes to SYED-M-HUSSAIN
1 parent e071fbc commit 740e246

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

libs/aws/langchain_aws/chat_models/bedrock_converse.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,9 +1170,9 @@ def _parse_stream_event(event: Dict[str, Any]) -> Optional[BaseMessageChunk]:
11701170
if "messageStart" in event:
11711171
# TODO: needed?
11721172
return (
1173-
AIMessageChunk(content="")
1173+
AIMessageChunk(content=[])
11741174
if event["messageStart"]["role"] == "assistant"
1175-
else HumanMessageChunk(content="")
1175+
else HumanMessageChunk(content=[])
11761176
)
11771177
elif "contentBlockStart" in event:
11781178
block = {
@@ -1189,8 +1189,9 @@ def _parse_stream_event(event: Dict[str, Any]) -> Optional[BaseMessageChunk]:
11891189
index=event["contentBlockStart"]["contentBlockIndex"],
11901190
)
11911191
)
1192-
# Keep content as list during streaming to preserve merging compatibility
1192+
# always keep block inside a list to preserve merging compatibility
11931193
content = [block]
1194+
11941195
return AIMessageChunk(content=content, tool_call_chunks=tool_call_chunks)
11951196
elif "contentBlockDelta" in event:
11961197
block = {
@@ -1207,12 +1208,13 @@ def _parse_stream_event(event: Dict[str, Any]) -> Optional[BaseMessageChunk]:
12071208
index=event["contentBlockDelta"]["contentBlockIndex"],
12081209
)
12091210
)
1210-
# Keep content as list during streaming to preserve merging compatibility
1211+
# always keep block inside a list to preserve merging compatibility
12111212
content = [block]
1213+
12121214
return AIMessageChunk(content=content, tool_call_chunks=tool_call_chunks)
12131215
elif "contentBlockStop" in event:
12141216
# TODO: needed?
1215-
return AIMessageChunk(content="")
1217+
return AIMessageChunk(content=[])
12161218
elif "messageStop" in event:
12171219
# TODO: snake case response metadata?
12181220
return AIMessageChunk(content="", response_metadata=event["messageStop"])

libs/aws/tests/integration_tests/chat_models/test_bedrock_converse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ def test_structured_output_thinking_force_tool_use() -> None:
455455
},
456456
}
457457
with pytest.raises(llm.client.exceptions.ValidationException):
458-
response = llm.client.converse(messages=messages, **params)
458+
llm.client.converse(messages=messages, **params)
459459

460460

461461
def test_bedrock_pdf_inputs() -> None:

0 commit comments

Comments
 (0)