Remove no-untyped-def escapes (#17)

From langchain-ai/langchain#30873

---------

Co-authored-by: Eugene Yurtsev <[email protected]>

Author: cbornet

libs/community/langchain_community/chat_models/baichuan.py

@@ -575,8 +575,8 @@ def _chat(self, messages: List[BaseMessage], **kwargs: Any) -> requests.Response
         )
         return res
 
-    def _create_payload_parameters(  # type: ignore[no-untyped-def]
-        self, messages: List[BaseMessage], **kwargs
+    def _create_payload_parameters(
+        self, messages: List[BaseMessage], **kwargs: Any
     ) -> Dict[str, Any]:
         parameters = {**self._default_params, **kwargs}
         temperature = parameters.pop("temperature", 0.3)
@@ -600,7 +600,7 @@ def _create_payload_parameters(  # type: ignore[no-untyped-def]
 
         return payload
 
-    def _create_headers_parameters(self, **kwargs) -> Dict[str, Any]:  # type: ignore[no-untyped-def]
+    def _create_headers_parameters(self, **kwargs: Any) -> Dict[str, Any]:
         parameters = {**self._default_params, **kwargs}
         default_headers = parameters.pop("headers", {})
         api_key = ""

libs/community/langchain_community/chat_models/minimax.py

@@ -439,8 +439,8 @@ def _create_chat_result(self, response: Union[dict, BaseModel]) -> ChatResult:
         }
         return ChatResult(generations=generations, llm_output=llm_output)
 
-    def _create_payload_parameters(  # type: ignore[no-untyped-def]
-        self, messages: List[BaseMessage], is_stream: bool = False, **kwargs
+    def _create_payload_parameters(
+        self, messages: List[BaseMessage], is_stream: bool = False, **kwargs: Any
     ) -> Dict[str, Any]:
         """Create API request body parameters."""
         message_dicts = [_convert_message_to_dict(m) for m in messages]

libs/community/langchain_community/document_loaders/chm.py

@@ -1,5 +1,8 @@
 from pathlib import Path
-from typing import TYPE_CHECKING, Any, Dict, List, Union
+from types import TracebackType
+from typing import TYPE_CHECKING, Any, Dict, List, Optional, Union
+
+from typing_extensions import Self
 
 from langchain_community.document_loaders.unstructured import UnstructuredFileLoader
 
@@ -65,10 +68,15 @@ def __init__(self, path: str):
         self.file = chm.CHMFile()
         self.file.LoadCHM(path)
 
-    def __enter__(self):  # type: ignore[no-untyped-def]
+    def __enter__(self) -> Self:
         return self
 
-    def __exit__(self, exc_type, exc_value, traceback):  # type: ignore[no-untyped-def]
+    def __exit__(
+        self,
+        exc_type: Optional[type[BaseException]],
+        exc_value: Optional[BaseException],
+        traceback: Optional[TracebackType],
+    ) -> None:
         if self.file:
             self.file.CloseCHM()
 

libs/community/langchain_community/document_loaders/mediawikidump.py

@@ -1,13 +1,16 @@
 import logging
 from pathlib import Path
-from typing import Iterator, Optional, Sequence, Union
+from typing import TYPE_CHECKING, Iterator, Optional, Sequence, Union
 
 from langchain_core.documents import Document
 
 from langchain_community.document_loaders.base import BaseLoader
 
 logger = logging.getLogger(__name__)
 
+if TYPE_CHECKING:
+    import mwxml
+
 
 class MWDumpLoader(BaseLoader):
     """Load `MediaWiki` dump from an `XML` file.
@@ -60,7 +63,7 @@ def __init__(
         self.skip_redirects = skip_redirects
         self.stop_on_error = stop_on_error
 
-    def _load_dump_file(self):  # type: ignore[no-untyped-def]
+    def _load_dump_file(self) -> "mwxml.Dump":
         try:
             import mwxml
         except ImportError as e:
@@ -70,7 +73,7 @@ def _load_dump_file(self):  # type: ignore[no-untyped-def]
 
         return mwxml.Dump.from_file(open(self.file_path, encoding=self.encoding))
 
-    def _load_single_page_from_dump(self, page) -> Document:  # type: ignore[no-untyped-def, return]
+    def _load_single_page_from_dump(self, page: "mwxml.Page") -> Document:  # type: ignore[return]
         """Parse a single page."""
         try:
             import mwparserfromhell

libs/community/langchain_community/document_loaders/parsers/doc_intelligence.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import logging
-from typing import TYPE_CHECKING, Any, Iterator, List, Optional
+from typing import TYPE_CHECKING, Any, Iterator, List, Optional, Union
 
 from langchain_core.documents import Document
 
@@ -34,20 +34,24 @@ def __init__(
 
         kwargs = {}
 
-        if api_key is None and azure_credential is None:
+        credential: Union[AzureKeyCredential, TokenCredential]
+        if azure_credential:
+            if api_key is not None:
+                raise ValueError(
+                    "Only one of api_key or azure_credential should be provided."
+                )
+            credential = azure_credential
+        elif api_key is not None:
+            credential = AzureKeyCredential(api_key)
+        else:
             raise ValueError("Either api_key or azure_credential must be provided.")
 
-        if api_key and azure_credential:
-            raise ValueError(
-                "Only one of api_key or azure_credential should be provided."
-            )
-
         if api_version is not None:
             kwargs["api_version"] = api_version
 
         self.client = DocumentIntelligenceClient(
             endpoint=api_endpoint,
-            credential=azure_credential or AzureKeyCredential(api_key),
+            credential=credential,
             headers={"x-ms-useragent": "langchain-parser/1.0.0"},
             **kwargs,
         )

libs/community/langchain_community/embeddings/gradient_ai.py

@@ -169,5 +169,5 @@ class TinyAsyncGradientEmbeddingClient:  #: :meta private:
     It might be entirely removed in the future.
     """
 
-    def __init__(self, *args, **kwargs) -> None:  # type: ignore[no-untyped-def]
+    def __init__(self, *args: Any, **kwargs: Any) -> None:
         raise ValueError("Deprecated,TinyAsyncGradientEmbeddingClient was removed.")

libs/community/langchain_community/embeddings/oci_generative_ai.py

@@ -1,10 +1,13 @@
 from enum import Enum
-from typing import Any, Dict, Iterator, List, Mapping, Optional
+from typing import TYPE_CHECKING, Any, Dict, Iterator, List, Mapping, Optional
 
 from langchain_core.embeddings import Embeddings
 from langchain_core.utils import pre_init
 from pydantic import BaseModel, ConfigDict
 
+if TYPE_CHECKING:
+    import oci
+
 CUSTOM_ENDPOINT_PREFIX = "ocid1.generativeaiendpoint"
 
 
@@ -122,12 +125,14 @@ def validate_environment(cls, values: Dict) -> Dict:  # pylint: disable=no-self-
                 client_kwargs.pop("signer", None)
             elif values["auth_type"] == OCIAuthType(2).name:
 
-                def make_security_token_signer(oci_config):  # type: ignore[no-untyped-def]
+                def make_security_token_signer(
+                    oci_config: dict[str, Any],
+                ) -> "oci.auth.signers.SecurityTokenSigner":
                     pk = oci.signer.load_private_key_from_file(
                         oci_config.get("key_file"), None
                     )
                     with open(
-                        oci_config.get("security_token_file"), encoding="utf-8"
+                        str(oci_config.get("security_token_file")), encoding="utf-8"
                     ) as f:
                         st_string = f.read()
                     return oci.auth.signers.SecurityTokenSigner(st_string, pk)

libs/community/langchain_community/embeddings/yandex.py

@@ -159,18 +159,20 @@ def _create_retry_decorator(llm: YandexGPTEmbeddings) -> Callable[[Any], Any]:
     )
 
 
-def _embed_with_retry(llm: YandexGPTEmbeddings, **kwargs: Any) -> Any:
+def _embed_with_retry(llm: YandexGPTEmbeddings, **kwargs: Any) -> list[list[float]]:
     """Use tenacity to retry the embedding call."""
     retry_decorator = _create_retry_decorator(llm)
 
     @retry_decorator
-    def _completion_with_retry(**_kwargs: Any) -> Any:
+    def _completion_with_retry(**_kwargs: Any) -> list[list[float]]:
         return _make_request(llm, **_kwargs)
 
     return _completion_with_retry(**kwargs)
 
 
-def _make_request(self: YandexGPTEmbeddings, texts: List[str], **kwargs):  # type: ignore[no-untyped-def]
+def _make_request(
+    self: YandexGPTEmbeddings, texts: List[str], **kwargs: Any
+) -> list[list[float]]:
     try:
         import grpc
 

libs/community/langchain_community/graphs/ontotext_graphdb_graph.py

@@ -93,10 +93,11 @@ def __init__(
         self.graph = rdflib.Graph(store, identifier=None, bind_namespaces="none")
         self._check_connectivity()
 
+        ontology_schema_graph: "rdflib.Graph"
         if local_file:
             ontology_schema_graph = self._load_ontology_schema_from_file(
                 local_file,
-                local_file_format,  # type: ignore[arg-type]
+                local_file_format,
             )
         else:
             self._validate_user_query(query_ontology)  # type: ignore[arg-type]
@@ -140,7 +141,9 @@ def _check_connectivity(self) -> None:
             )
 
     @staticmethod
-    def _load_ontology_schema_from_file(local_file: str, local_file_format: str = None):  # type: ignore[no-untyped-def, assignment]
+    def _load_ontology_schema_from_file(
+        local_file: str, local_file_format: Optional[str] = None
+    ) -> "rdflib.ConjunctiveGraph":
         """
         Parse the ontology schema statements from the provided file
         """
@@ -177,7 +180,7 @@ def _validate_user_query(query_ontology: str) -> None:
                 "Invalid query type. Only CONSTRUCT queries are supported."
             )
 
-    def _load_ontology_schema_with_query(self, query: str):  # type: ignore[no-untyped-def]
+    def _load_ontology_schema_with_query(self, query: str) -> "rdflib.Graph":
         """
         Execute the query for collecting the ontology schema statements
         """
@@ -188,6 +191,9 @@ def _load_ontology_schema_with_query(self, query: str):  # type: ignore[no-untyp
         except ParserError as e:
             raise ValueError(f"Generated SPARQL statement is invalid\n{e}")
 
+        if not results.graph:
+            raise ValueError("Missing graph in results.")
+
         return results.graph
 
     @property

libs/community/langchain_community/graphs/tigergraph_graph.py

@@ -77,7 +77,7 @@ def generate_schema(
         """
         return self._conn.getSchema(force=True)
 
-    def refresh_schema(self):  # type: ignore[no-untyped-def]
+    def refresh_schema(self) -> None:
         self.generate_schema()
 
     def query(self, query: str) -> Dict[str, Any]:  # type: ignore[override]