vectorstores[azure_search]: fix regression in 0.3.24 (#77)

Co-authored-by: Chester Curme <[email protected]>

Author: marcgibbons

libs/community/langchain_community/vectorstores/azuresearch.py

@@ -2,6 +2,7 @@
 
 import asyncio
 import base64
+import copy
 import itertools
 import json
 import logging
@@ -375,7 +376,9 @@ def __init__(
             default_fields=default_fields,
             user_agent=user_agent,
             cors_options=cors_options,
-            additional_search_client_options=additional_search_client_options,
+            additional_search_client_options=copy.deepcopy(
+                additional_search_client_options
+            ),
             azure_credential=azure_credential,
         )
 

libs/community/tests/unit_tests/vectorstores/test_azure_search.py

@@ -3,6 +3,7 @@
 from unittest.mock import patch
 
 import pytest
+from pytest_socket import SocketBlockedError
 
 from langchain_community.vectorstores.azuresearch import AzureSearch
 from tests.integration_tests.vectorstores.fake_embeddings import FakeEmbeddings
@@ -192,6 +193,40 @@ def mock_create_index() -> None:
         assert vector_store.client._api_version == "test"
 
 
+@pytest.mark.requires("azure.search.documents")
+def test_additional_search_options_retry_policy() -> None:
+    """
+    Reproduces bug captured in:
+    https://github.com/langchain-ai/langchain-community/issues/76
+    """
+    from azure.core.exceptions import HttpResponseError
+    from azure.core.pipeline.policies import RetryPolicy
+    from azure.search.documents.indexes import SearchIndexClient
+
+    def mock_create_index() -> None:
+        pytest.fail("Should not create index in this test")
+
+    with patch.multiple(
+        SearchIndexClient, get_index=mock_default_index, create_index=mock_create_index
+    ):
+        vector_store = create_vector_store(
+            additional_search_client_options={
+                "retry_policy": RetryPolicy(
+                    total_retries=3,
+                    backoff_factor=0.5,
+                    timeout=5,
+                ),
+            }
+        )
+        assert vector_store.client is not None
+
+        # Bug previously raised an:
+        #  AttributeError: 'coroutine' object has no attribute 'http_response'.
+        # Expect a network connection to be made (and blocked).
+        with pytest.raises((HttpResponseError, SocketBlockedError)):
+            list(vector_store.client.search())
+
+
 @pytest.mark.requires("azure.search.documents")
 def test_ids_used_correctly() -> None:
     """Check whether vector store uses the document ids when provided with them."""