[langchain-db2] Update integration tests suite #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiweiHeOSS
reviewed
Jul 14, 2025
| @@ -27,12 +28,12 @@ def test_table_exists_test() -> None: | |||
| try: | |||
| import ibm_db_dbi # type: ignore | |||
| except ImportError: | |||
| return | |||
| pytest.fail("ibm_db_dbi package is required to run this test") | |||
There was a problem hiding this comment.
Hi @MateuszOssGit. I set it to return before because on the machine with no ibm_db_dbi and no connection to db2, the this testcase is not able to run. I think the integration test relies on the ibm_db_dbi and the connection to db2. Not sure if the integration test in the CI pipeline can pass if you change them like this.
|
Closing due to @yiweiHeOSS comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update integration tests suite