Naming things: `streamable-http` vs. `http`

Hi there,

thanks a stack for conceiving this excellent adapter. We made a demo using it over here.

- https://github.com/crate/cratedb-examples/pull/1033

As we just started using it, we observed it does not accept `transport=http` yet. `http` seems to be the designated new label which was introduced as `streamable-http` beforehand.

https://github.com/langchain-ai/langchain-mcp-adapters/blob/49a13ecf321d80a6df90ea2e4893ee5c4fefb75b/langchain_mcp_adapters/sessions.py#L375-L407

In this spirit, do you think this one-line change for line 381 would be applicable?

```python
elif transport in {"http", "streamable-http", "streamable_http"}: 
```

With kind regards,
Andreas.


	if transport == "sse":
	if "url" not in params:
	msg = "'url' parameter is required for SSE connection"
	raise ValueError(msg)
	async with _create_sse_session(**params) as session:
	yield session
	elif transport == "streamable_http":
	if "url" not in params:
	msg = "'url' parameter is required for Streamable HTTP connection"
	raise ValueError(msg)
	async with _create_streamable_http_session(**params) as session:
	yield session
	elif transport == "stdio":
	if "command" not in params:
	msg = "'command' parameter is required for stdio connection"
	raise ValueError(msg)
	if "args" not in params:
	msg = "'args' parameter is required for stdio connection"
	raise ValueError(msg)
	async with _create_stdio_session(**params) as session:
	yield session
	elif transport == "websocket":
	if "url" not in params:
	msg = "'url' parameter is required for Websocket connection"
	raise ValueError(msg)
	async with _create_websocket_session(**params) as session:
	yield session
	else:
	msg = (
	f"Unsupported transport: {transport}. "
	f"Must be one of: 'stdio', 'sse', 'websocket', 'streamable_http'"
	)
	raise ValueError(msg)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Naming things: `streamable-http` vs. `http` #267

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Naming things: streamable-http vs. http #267

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Naming things: `streamable-http` vs. `http` #267