update typing

Author: blink1073

libs/langchain-mongodb/langchain_mongodb/retrievers/hybrid_search.py

@@ -86,12 +86,12 @@ def _get_relevant_documents(
         # Get the appropriate value for k.
         is_top_k_set = False
         with warnings.catch_warnings():
-            # Ignore warnings raised by base class.
+            # Ignore warning raised by checking the value of top_k.
             warnings.simplefilter("ignore", DeprecationWarning)
             if self.top_k is not None:
                 is_top_k_set = True
         default_k = self.k if not is_top_k_set else self.top_k
-        k = kwargs.get("k", default_k)
+        k: int = kwargs.get("k", default_k)  # type:ignore[assignment]
 
         # First we build up the aggregation pipeline,
         # then it is passed to the server to execute

libs/langchain-mongodb/tests/integration_tests/test_cache.py

@@ -157,7 +157,7 @@ def test_mongodb_cache(
         _execute_test(prompt, llm, response)
     finally:
         get_llm_cache().clear()
-        get_llm_cache().close()
+        get_llm_cache().close()  # type:ignore[attr-defined]
 
 
 @pytest.mark.parametrize(
@@ -209,4 +209,4 @@ def test_mongodb_atlas_cache_matrix(
         generations=llm_generations, llm_output={}
     )
     get_llm_cache().clear()
-    get_llm_cache().close()
+    get_llm_cache().close()  # type:ignore[attr-defined]

libs/langchain-mongodb/tests/integration_tests/test_chat_message_histories.py

@@ -42,4 +42,4 @@ def test_memory_with_message_store() -> None:
     memory.chat_memory.clear()
 
     assert memory.chat_memory.messages == []
-    memory.chat_memory.close()
+    memory.chat_memory.close()  # type:ignore[attr-defined]

libs/langchain-mongodb/tests/integration_tests/test_retrievers_standard.py

@@ -68,6 +68,8 @@ def setup_test() -> tuple[Collection, MongoDBAtlasVectorSearch]:
 
 
 class TestMongoDBAtlasFullTextSearchRetriever(RetrieversIntegrationTests):
+    _coll: Collection
+
     @classmethod
     def setup_class(cls):
         cls._coll, _ = setup_test()
@@ -98,6 +100,9 @@ def retriever_query_example(self) -> str:
 
 
 class TestMongoDBAtlasHybridSearchRetriever(RetrieversIntegrationTests):
+    _coll: Collection
+    _vs: MongoDBAtlasVectorSearch
+
     @classmethod
     def setup_class(cls):
         cls._coll, cls._vs = setup_test()

libs/langchain-mongodb/tests/integration_tests/test_tools.py

@@ -1,17 +1,24 @@
 from typing import Type
 
+import pytest
 from langchain_tests.integration_tests import ToolsIntegrationTests
 
 from langchain_mongodb.agent_toolkit.tool import (
     InfoMongoDBDatabaseTool,
     ListMongoDBDatabaseTool,
+    MongoDBDatabase,
     QueryMongoDBCheckerTool,
     QueryMongoDBDatabaseTool,
 )
 from tests.utils import create_database, create_llm
 
+# Ignore ResourceWarning raised by base class.
+pytestmark = pytest.mark.filterwarnings("ignore:unclosed:ResourceWarning")
+
 
 class TestQueryMongoDBDatabaseToolIntegration(ToolsIntegrationTests):
+    _db: MongoDBDatabase
+
     @classmethod
     def setup_class(cls):
         cls._db = create_database()
@@ -34,6 +41,8 @@ def tool_invoke_params_example(self) -> dict:
 
 
 class TestInfoMongoDBDatabaseToolIntegration(ToolsIntegrationTests):
+    _db: MongoDBDatabase
+
     @classmethod
     def setup_class(cls):
         cls._db = create_database()
@@ -56,6 +65,8 @@ def tool_invoke_params_example(self) -> dict:
 
 
 class TestListMongoDBDatabaseToolIntegration(ToolsIntegrationTests):
+    _db: MongoDBDatabase
+
     @classmethod
     def setup_class(cls):
         cls._db = create_database()
@@ -78,6 +89,8 @@ def tool_invoke_params_example(self) -> dict:
 
 
 class TestQueryMongoDBCheckerToolIntegration(ToolsIntegrationTests):
+    _db: MongoDBDatabase
+
     @classmethod
     def setup_class(cls):
         cls._db = create_database()

libs/langchain-mongodb/tests/unit_tests/test_index.py

@@ -1,4 +1,5 @@
 from time import sleep
+from typing import Generator
 
 import pytest
 from pymongo import MongoClient
@@ -12,7 +13,7 @@
 
 
 @pytest.fixture
-def collection() -> Collection:
+def collection() -> Generator[Collection]:
     """Collection on MongoDB Cluster, not an Atlas one."""
     client: MongoClient = MongoClient()
     yield client["db"]["collection"]