fix(types): safely cast ShellToolMiddleware in factory to satisfy mypy strict mode

aroun-coumar · aroun-coumar · commit 6051bb94b9d7 · 2025-10-30T00:15:33.000+05:30
diff --git a/libs/langchain_v1/langchain/agents/factory.py b/libs/langchain_v1/langchain/agents/factory.py
@@ -1312,10 +1312,11 @@ async def amodel_node(state: AgentState, runtime: Runtime[ContextT]) -> dict[str
         )
         last_mw = middleware_w_before_agent[-1]
         if isinstance(last_mw, ShellToolMiddleware):
-            graph.add_node("restore_shell", last_mw.restore_from_metadata)  # type: ignore[attr-defined]
+            mw: ShellToolMiddleware = last_mw
+            graph.add_node("restore_shell", mw.restore_from_metadata)
 
             graph.add_conditional_edges(
-                f"{last_mw.name}.before_agent",  # type: ignore[attr-defined]
+                f"{mw.name}.before_agent",
                 lambda state: state.get("resume_from") == "interrupt",
                 {
                     True: "restore_shell",

Original file line number	Diff line number	Diff line change
`@@ -1312,10 +1312,11 @@ async def amodel_node(state: AgentState, runtime: Runtime[ContextT]) -> dict[str`
`1312`	`1312`	`)`
`1313`	`1313`	`last_mw = middleware_w_before_agent[-1]`
`1314`	`1314`	`if isinstance(last_mw, ShellToolMiddleware):`
`1315`		`- graph.add_node("restore_shell", last_mw.restore_from_metadata) # type: ignore[attr-defined]`
	`1315`	`+ mw: ShellToolMiddleware = last_mw`
	`1316`	`+ graph.add_node("restore_shell", mw.restore_from_metadata)`
`1316`	`1317`
`1317`	`1318`	`graph.add_conditional_edges(`
`1318`		`- f"{last_mw.name}.before_agent", # type: ignore[attr-defined]`
	`1319`	`+ f"{mw.name}.before_agent",`
`1319`	`1320`	`lambda state: state.get("resume_from") == "interrupt",`
`1320`	`1321`	`{`
`1321`	`1322`	`True: "restore_shell",`