ruff: restore stacklevels, disable autofixing (#31919)

mdrxy · web-flow · commit 71b361936dc0 · 2025-07-08T12:55:47.000-04:00
diff --git a/libs/core/pyproject.toml b/libs/core/pyproject.toml
@@ -101,6 +101,8 @@ ignore = [
     "PLC0415",
     "PLR2004",
 ]
+unfixable = ["PLW1510",]
+
 flake8-annotations.allow-star-arg-any = true
 flake8-annotations.mypy-init-return = true
 flake8-type-checking.runtime-evaluated-base-classes = ["pydantic.BaseModel","langchain_core.load.serializable.Serializable","langchain_core.runnables.base.RunnableSerializable"]
diff --git a/libs/langchain/langchain/__init__.py b/libs/langchain/langchain/__init__.py
@@ -29,12 +29,12 @@ def _warn_on_import(name: str, replacement: Optional[str] = None) -> None:
         warnings.warn(
             f"Importing {name} from langchain root module is no longer supported. "
             f"Please use {replacement} instead.",
-            stacklevel=2,
+            stacklevel=3,
         )
     else:
         warnings.warn(
             f"Importing {name} from langchain root module is no longer supported.",
-            stacklevel=2,
+            stacklevel=3,
         )
 
 
diff --git a/libs/langchain/langchain/chains/base.py b/libs/langchain/langchain/chains/base.py
@@ -255,7 +255,7 @@ def raise_callback_manager_deprecation(cls, values: dict) -> Any:
             warnings.warn(
                 "callback_manager is deprecated. Please use callbacks instead.",
                 DeprecationWarning,
-                stacklevel=2,
+                stacklevel=4,
             )
             values["callbacks"] = values.pop("callback_manager", None)
         return values
diff --git a/libs/langchain/langchain/chains/conversational_retrieval/base.py b/libs/langchain/langchain/chains/conversational_retrieval/base.py
@@ -504,7 +504,7 @@ def raise_deprecation(cls, values: dict) -> Any:
         warnings.warn(
             "`ChatVectorDBChain` is deprecated - "
             "please use `from langchain.chains import ConversationalRetrievalChain`",
-            stacklevel=2,
+            stacklevel=4,
         )
         return values
 
diff --git a/libs/langchain/langchain/chains/llm_checker/base.py b/libs/langchain/langchain/chains/llm_checker/base.py
@@ -112,7 +112,7 @@ def raise_deprecation(cls, values: dict) -> Any:
                 "Directly instantiating an LLMCheckerChain with an llm is deprecated. "
                 "Please instantiate with question_to_checked_assertions_chain "
                 "or using the from_llm class method.",
-                stacklevel=2,
+                stacklevel=5,
             )
             if (
                 "question_to_checked_assertions_chain" not in values
diff --git a/libs/langchain/langchain/chains/llm_math/base.py b/libs/langchain/langchain/chains/llm_math/base.py
@@ -177,7 +177,7 @@ def raise_deprecation(cls, values: dict) -> Any:
                 "Directly instantiating an LLMMathChain with an llm is deprecated. "
                 "Please instantiate with llm_chain argument or using the from_llm "
                 "class method.",
-                stacklevel=2,
+                stacklevel=5,
             )
             if "llm_chain" not in values and values["llm"] is not None:
                 prompt = values.get("prompt", PROMPT)
diff --git a/libs/langchain/langchain/chains/llm_summarization_checker/base.py b/libs/langchain/langchain/chains/llm_summarization_checker/base.py
@@ -118,7 +118,7 @@ def raise_deprecation(cls, values: dict) -> Any:
                 "Directly instantiating an LLMSummarizationCheckerChain with an llm is "
                 "deprecated. Please instantiate with"
                 " sequential_chain argument or using the from_llm class method.",
-                stacklevel=2,
+                stacklevel=5,
             )
             if "sequential_chain" not in values and values["llm"] is not None:
                 values["sequential_chain"] = _load_sequential_chain(
diff --git a/libs/langchain/langchain/chains/natbot/base.py b/libs/langchain/langchain/chains/natbot/base.py
@@ -74,7 +74,7 @@ def raise_deprecation(cls, values: dict) -> Any:
                 "Directly instantiating an NatBotChain with an llm is deprecated. "
                 "Please instantiate with llm_chain argument or using the from_llm "
                 "class method.",
-                stacklevel=2,
+                stacklevel=5,
             )
             if "llm_chain" not in values and values["llm"] is not None:
                 values["llm_chain"] = PROMPT | values["llm"] | StrOutputParser()
diff --git a/libs/langchain/langchain/chains/qa_with_sources/vector_db.py b/libs/langchain/langchain/chains/qa_with_sources/vector_db.py
@@ -77,7 +77,7 @@ def raise_deprecation(cls, values: dict) -> Any:
         warnings.warn(
             "`VectorDBQAWithSourcesChain` is deprecated - "
             "please use `from langchain.chains import RetrievalQAWithSourcesChain`",
-            stacklevel=2,
+            stacklevel=5,
         )
         return values
 
diff --git a/libs/langchain/langchain/chains/query_constructor/parser.py b/libs/langchain/langchain/chains/query_constructor/parser.py
@@ -162,7 +162,7 @@ def date(self, item: Any) -> ISO8601Date:
             warnings.warn(
                 "Dates are expected to be provided in ISO 8601 date format "
                 "(YYYY-MM-DD).",
-                stacklevel=2,
+                stacklevel=3,
             )
         return {"date": item, "type": "date"}
 
diff --git a/libs/langchain/langchain/evaluation/schema.py b/libs/langchain/langchain/evaluation/schema.py
@@ -124,12 +124,12 @@ def _check_evaluation_args(
             msg = f"{self.__class__.__name__} requires an input string."
             raise ValueError(msg)
         if input_ is not None and not self.requires_input:
-            warn(self._skip_input_warning, stacklevel=2)
+            warn(self._skip_input_warning, stacklevel=3)
         if self.requires_reference and reference is None:
             msg = f"{self.__class__.__name__} requires a reference string."
             raise ValueError(msg)
         if reference is not None and not self.requires_reference:
-            warn(self._skip_reference_warning, stacklevel=2)
+            warn(self._skip_reference_warning, stacklevel=3)
 
 
 class StringEvaluator(_EvalArgsMixin, ABC):
diff --git a/libs/langchain/langchain/indexes/vectorstore.py b/libs/langchain/langchain/indexes/vectorstore.py
@@ -183,7 +183,7 @@ def _get_in_memory_vectorstore() -> type[VectorStore]:
         "Using InMemoryVectorStore as the default vectorstore."
         "This memory store won't persist data. You should explicitly"
         "specify a vectorstore when using VectorstoreIndexCreator",
-        stacklevel=2,
+        stacklevel=3,
     )
     return InMemoryVectorStore
 
diff --git a/libs/langchain/langchain/memory/chat_memory.py b/libs/langchain/langchain/memory/chat_memory.py
@@ -58,7 +58,7 @@ def _get_input_output(
                     f"'{self.__class__.__name__}' got multiple output keys:"
                     f" {outputs.keys()}. The default 'output' key is being used."
                     f" If this is not desired, please manually set 'output_key'.",
-                    stacklevel=2,
+                    stacklevel=3,
                 )
             else:
                 msg = (
diff --git a/libs/langchain/langchain/memory/combined.py b/libs/langchain/langchain/memory/combined.py
@@ -42,7 +42,7 @@ def check_input_key(cls, value: list[BaseMemory]) -> list[BaseMemory]:
                     "When using CombinedMemory, "
                     "input keys should be so the input is known. "
                     f" Was not set on {val}",
-                    stacklevel=2,
+                    stacklevel=5,
                 )
         return value
 
diff --git a/libs/langchain/pyproject.toml b/libs/langchain/pyproject.toml
@@ -198,6 +198,7 @@ ignore = [
     "SLF001",  # Private member access
     "UP007",   # pyupgrade: non-pep604-annotation-union
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 pydocstyle.convention = "google"
 pyupgrade.keep-runtime-typing = true
diff --git a/libs/partners/anthropic/pyproject.toml b/libs/partners/anthropic/pyproject.toml
@@ -114,6 +114,7 @@ ignore = [
     "UP045",   # non-pep604-annotation-optional
     "SIM105",  # Rarely useful
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]
diff --git a/libs/partners/chroma/pyproject.toml b/libs/partners/chroma/pyproject.toml
@@ -109,6 +109,7 @@ ignore = [
     "D107",    # Missing docstring in __init__
     "UP007",   # pyupgrade: non-pep604-annotation-union
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]
diff --git a/libs/partners/deepseek/pyproject.toml b/libs/partners/deepseek/pyproject.toml
@@ -95,6 +95,7 @@ ignore = [
     "D107",    # Missing docstring in __init__
     "UP007",   # pyupgrade: non-pep604-annotation-union
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]
diff --git a/libs/partners/exa/pyproject.toml b/libs/partners/exa/pyproject.toml
@@ -100,6 +100,7 @@ ignore = [
     "SLF001",  # Private member access
     "UP007",   # pyupgrade: non-pep604-annotation-union
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]
diff --git a/libs/partners/fireworks/pyproject.toml b/libs/partners/fireworks/pyproject.toml
@@ -104,6 +104,7 @@ ignore = [
     "SLF001",  # Private member access
     "UP007",   # pyupgrade: non-pep604-annotation-union
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]
diff --git a/libs/partners/groq/pyproject.toml b/libs/partners/groq/pyproject.toml
@@ -97,6 +97,7 @@ ignore = [
     "SLF001",  # Private member access
     "UP007",   # pyupgrade: non-pep604-annotation-union
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]
diff --git a/libs/partners/huggingface/pyproject.toml b/libs/partners/huggingface/pyproject.toml
@@ -112,6 +112,7 @@ ignore = [
     "SLF001",  # Private member access
     "UP007",   # pyupgrade: non-pep604-annotation-union
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]
diff --git a/libs/partners/mistralai/pyproject.toml b/libs/partners/mistralai/pyproject.toml
@@ -104,6 +104,7 @@ ignore = [
     "UP007",   # pyupgrade: non-pep604-annotation-union
     "UP045",   # pyupgrade: non-pep604-annotation-optional
 ]
+unfixable = ["B028"] # People should intentionally tune the stacklevel
 
 [tool.coverage.run]
 omit = ["tests/*"]

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,8 @@ ignore = [`
`101`	`101`	`"PLC0415",`
`102`	`102`	`"PLR2004",`
`103`	`103`	`]`
	`104`	`+unfixable = ["PLW1510",]`
	`105`	`+`
`104`	`106`	`flake8-annotations.allow-star-arg-any = true`
`105`	`107`	`flake8-annotations.mypy-init-return = true`
`106`	`108`	`flake8-type-checking.runtime-evaluated-base-classes = ["pydantic.BaseModel","langchain_core.load.serializable.Serializable","langchain_core.runnables.base.RunnableSerializable"]`
Original file line number	Diff line number	Diff line change
`@@ -29,12 +29,12 @@ def _warn_on_import(name: str, replacement: Optional[str] = None) -> None:`
`29`	`29`	`warnings.warn(`
`30`	`30`	`f"Importing {name} from langchain root module is no longer supported. "`
`31`	`31`	`f"Please use {replacement} instead.",`
`32`		`- stacklevel=2,`
	`32`	`+ stacklevel=3,`
`33`	`33`	`)`
`34`	`34`	`else:`
`35`	`35`	`warnings.warn(`
`36`	`36`	`f"Importing {name} from langchain root module is no longer supported.",`
`37`		`- stacklevel=2,`
	`37`	`+ stacklevel=3,`
`38`	`38`	`)`
`39`	`39`
`40`	`40`
Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,7 @@ def raise_callback_manager_deprecation(cls, values: dict) -> Any:`
`255`	`255`	`warnings.warn(`
`256`	`256`	`"callback_manager is deprecated. Please use callbacks instead.",`
`257`	`257`	`DeprecationWarning,`
`258`		`- stacklevel=2,`
	`258`	`+ stacklevel=4,`
`259`	`259`	`)`
`260`	`260`	`values["callbacks"] = values.pop("callback_manager", None)`
`261`	`261`	`return values`
Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ def raise_deprecation(cls, values: dict) -> Any:`
`504`	`504`	`warnings.warn(`
`505`	`505`	"`ChatVectorDBChain` is deprecated - "
`506`	`506`	"please use `from langchain.chains import ConversationalRetrievalChain`",
`507`		`- stacklevel=2,`
	`507`	`+ stacklevel=4,`
`508`	`508`	`)`
`509`	`509`	`return values`
`510`	`510`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ def raise_deprecation(cls, values: dict) -> Any:`
`112`	`112`	`"Directly instantiating an LLMCheckerChain with an llm is deprecated. "`
`113`	`113`	`"Please instantiate with question_to_checked_assertions_chain "`
`114`	`114`	`"or using the from_llm class method.",`
`115`		`- stacklevel=2,`
	`115`	`+ stacklevel=5,`
`116`	`116`	`)`
`117`	`117`	`if (`
`118`	`118`	`"question_to_checked_assertions_chain" not in values`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ def raise_deprecation(cls, values: dict) -> Any:`
`177`	`177`	`"Directly instantiating an LLMMathChain with an llm is deprecated. "`
`178`	`178`	`"Please instantiate with llm_chain argument or using the from_llm "`
`179`	`179`	`"class method.",`
`180`		`- stacklevel=2,`
	`180`	`+ stacklevel=5,`
`181`	`181`	`)`
`182`	`182`	`if "llm_chain" not in values and values["llm"] is not None:`
`183`	`183`	`prompt = values.get("prompt", PROMPT)`
Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ def raise_deprecation(cls, values: dict) -> Any:`
`118`	`118`	`"Directly instantiating an LLMSummarizationCheckerChain with an llm is "`
`119`	`119`	`"deprecated. Please instantiate with"`
`120`	`120`	`" sequential_chain argument or using the from_llm class method.",`
`121`		`- stacklevel=2,`
	`121`	`+ stacklevel=5,`
`122`	`122`	`)`
`123`	`123`	`if "sequential_chain" not in values and values["llm"] is not None:`
`124`	`124`	`values["sequential_chain"] = _load_sequential_chain(`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ def raise_deprecation(cls, values: dict) -> Any:`
`74`	`74`	`"Directly instantiating an NatBotChain with an llm is deprecated. "`
`75`	`75`	`"Please instantiate with llm_chain argument or using the from_llm "`
`76`	`76`	`"class method.",`
`77`		`- stacklevel=2,`
	`77`	`+ stacklevel=5,`
`78`	`78`	`)`
`79`	`79`	`if "llm_chain" not in values and values["llm"] is not None:`
`80`	`80`	`values["llm_chain"] = PROMPT \| values["llm"] \| StrOutputParser()`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ def raise_deprecation(cls, values: dict) -> Any:`
`77`	`77`	`warnings.warn(`
`78`	`78`	"`VectorDBQAWithSourcesChain` is deprecated - "
`79`	`79`	"please use `from langchain.chains import RetrievalQAWithSourcesChain`",
`80`		`- stacklevel=2,`
	`80`	`+ stacklevel=5,`
`81`	`81`	`)`
`82`	`82`	`return values`
`83`	`83`
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ def date(self, item: Any) -> ISO8601Date:`
`162`	`162`	`warnings.warn(`
`163`	`163`	`"Dates are expected to be provided in ISO 8601 date format "`
`164`	`164`	`"(YYYY-MM-DD).",`
`165`		`- stacklevel=2,`
	`165`	`+ stacklevel=3,`
`166`	`166`	`)`
`167`	`167`	`return {"date": item, "type": "date"}`
`168`	`168`