Skip to content

Commit ffbe5b2

Browse files
authored
partners: fix default value for stop_sequences in ChatGroq (#28924)
- **Description:** This PR addresses an issue with the `stop_sequences` field in the `ChatGroq` class. Currently, the field is defined as: ```python stop: Optional[Union[List[str], str]] = Field(None, alias="stop_sequences") ``` This causes the language server (LSP) to raise an error indicating that the `stop_sequences` parameter must be implemented. The issue occurs because `Field(None, alias="stop_sequences")` is different compared to `Field(default=None, alias="stop_sequences")`. ![image](https://github.com/user-attachments/assets/bfc34cb1-c664-4c31-b856-8f18419c7350) To resolve the issue, the field is updated to: ```python stop: Optional[Union[List[str], str]] = Field(default=None, alias="stop_sequences") ``` While this issue does not affect runtime behavior, it ensures compatibility with LSPs and improves the development experience. - **Issue:** N/A - **Dependencies:** None
1 parent 5940ed3 commit ffbe5b2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

libs/partners/groq/langchain_groq/chat_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ class Joke(BaseModel):
305305
"""Model name to use."""
306306
temperature: float = 0.7
307307
"""What sampling temperature to use."""
308-
stop: Optional[Union[List[str], str]] = Field(None, alias="stop_sequences")
308+
stop: Optional[Union[List[str], str]] = Field(default=None, alias="stop_sequences")
309309
"""Default stop sequences."""
310310
model_kwargs: Dict[str, Any] = Field(default_factory=dict)
311311
"""Holds any model parameters valid for `create` call not explicitly specified."""

0 commit comments

Comments
 (0)