BlobLoader.yield_blobs returns Iterable, it should be Iterator like in BaseLoader

[gabayben]

Checked

• I searched existing ideas and did not find a similar one
• I added a very descriptive title
• I've clearly described the feature request and motivation for it

Feature request

BlobLoader.yield_blobs returns Iterable, it should be Iterator like in BaseLoader

Motivation

BaseLoader.lazy_load yields an Iterator. The method in BlobLoader is call yield yield_blobs, yet it returns an Iterable. The return type should be Iterator[Blob].

Proposal (If applicable)

BaseLoader.lazy_load yields an Iterator. The method in BlobLoader is call yield yield_blobs, yet it returns an Iterable. The return type should be Iterator[Blob].

[gbaian10]

Are you expecting this abstract class to be modified so that all objects inheriting from it implement the __next__ method?

[gabayben]

No, just that the yield_blobs method should return Iterator instead of Iterable.
So it should be:
def yield_blobs(...) -> Iterator[Blob]

[gbaian10]

Oh, I see. I mistakenly thought Blob needed to be an Iterator.
It is indeed an Iterator because it's a generator.

If it's explicitly a generator, I'd prefer it to be written as Generator[Blob, None, None].

However, it seems that LangChain often writes generators as Iterator[...]?

[gabayben]

Oh ok I see. It's alright then. I'll close this ticket.